From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x233.google.com (mail-lf0-x233.google.com [IPv6:2a00:1450:4010:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 258B43B25E for ; Wed, 5 Oct 2016 11:42:05 -0400 (EDT) Received: by mail-lf0-x233.google.com with SMTP id b75so84082380lfg.3 for ; Wed, 05 Oct 2016 08:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ALoGye/6xU0233e3kO2gFKWJk53/hh1hYT1P8e6o8tk=; b=PPgzViVH2rNQCdc3LDOvn9ROym6mFVkucb6jKnqwTTbj7b76uXeiIhY6GH1nJUekjj VL7/RF4v10O6Q1TMsqcDmqUDoLrwqQPM/oCI+XBLxzDQ4genB0ajzpxSVQ8HUbwZPu2N on/ddYW2xXSjf0WIODNY5hjsazsX2Z69ox4G9yK80t3+aHuFsqFZr9S3C+UZnwY9mI1/ E90QRlEsMREwi5+5C4B+wpyDxaP+ZVLbOlQsV3J/0HZrz8Wd0kNjId1DTBZbAlCWCqyZ 9kFkD5En1ue3Tm5Qv50VSTQJiE1HydJibu+abWL2X2mpsIHMSzJaoO5OWx+W0TZpEBfw h+iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ALoGye/6xU0233e3kO2gFKWJk53/hh1hYT1P8e6o8tk=; b=LAKeOoq3qsuRUJYQsH+lA+R+pGuoPNvlQxwdhlmPdwyLZFTFC16JwUHOpifbio7eM0 AWwQm3vfVqZ8ULMvZMpsZnQ9Q4BHKIDaKK3cwtQt+E0JVq4xpqmRz+PObirimgPjDHHy IVmF6TOaZDUWPFJm5dULeZAMKTns5N2vVCBIHii6FFlAEk5SnvQf6lCC4UL1ZFKgzKA2 +/zY4n/Mmv0Xl3J2YNxC9tpiFmI+k+wuIjALVsg5sspXZniwE7oKyjETIx8+kv9Qk3wa Wl7jlD/3WfBIHr6zUTYYjRo0pLukairvnFYBxGz6PuLs2kykRyihPcoa3YdQmBmnLH54 5uWg== X-Gm-Message-State: AA6/9RkW6wSFCwIFCTGz9uXFEP8y/HcWMgRK3NF/YV5vmtlr8JMXBrzZ2xFs0XK2gX2p2Q== X-Received: by 10.46.71.79 with SMTP id u76mr4348364lja.14.1475682123722; Wed, 05 Oct 2016 08:42:03 -0700 (PDT) Received: from [192.168.100.13] (37-33-90-35.bb.dnainternet.fi. [37.33.90.35]) by smtp.gmail.com with ESMTPSA id h7sm593310ljh.21.2016.10.05.08.42.02 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Oct 2016 08:42:03 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Jonathan Morton In-Reply-To: <70363372-13a0-a88f-840e-b8e10c685ed7@darbyshire-bryant.me.uk> Date: Wed, 5 Oct 2016 18:42:01 +0300 Cc: cake@lists.bufferbloat.net Content-Transfer-Encoding: quoted-printable Message-Id: References: <70363372-13a0-a88f-840e-b8e10c685ed7@darbyshire-bryant.me.uk> To: Kevin Darbyshire-Bryant X-Mailer: Apple Mail (2.3124) Subject: Re: [Cake] BUG_ON vs WARN_ON X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 15:42:05 -0000 > On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant = wrote: >=20 > How amenable are you to changing all 4 BUG_ON instances in cake to = WARN_ON? >=20 > Linus isn't a complete fan and I'm thinking that producing a stack = trace and trying to carry on is more helpful to a remote accessed, no = serial interface type device than just killing the kernel dead. >=20 > Quite possibly other bad things(tm) will happen shortly after...or = maybe there will be enough time look at dmesg for that stack trace. The two in cake_heap_swap() can probably go away completely - they were = there to make sure the heap algorithms were working correctly. They = never did trigger, as it happens. The other two are genuine serious bugs (array overflow) if they ever = trigger. It=E2=80=99s safer to leave them as-is. - Jonathan Morton