From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 84E773B2A4 for ; Sun, 29 Apr 2018 07:40:48 -0400 (EDT) Received: from [192.168.1.133] ([79.192.244.250]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MQdAP-1enCQ21Y3p-00U0UI; Sun, 29 Apr 2018 13:40:43 +0200 Date: Sun, 29 Apr 2018 13:40:27 +0200 User-Agent: K-9 Mail for Android In-Reply-To: <36AF888D-0AE5-4062-99FC-A6DB9CFA75D3@toke.dk> References: <87wowr2e8t.fsf@toke.dk> <36AF888D-0AE5-4062-99FC-A6DB9CFA75D3@toke.dk> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----NBNY1PN7QQR8DQP7MRG6W0TZV3FICO" Content-Transfer-Encoding: 7bit To: cake@lists.bufferbloat.net, =?ISO-8859-1?Q?Toke_H=F8iland-J=F8rgensen?= , Ryan Mounce CC: Cake List From: Sebastian Moeller Message-ID: X-Provags-ID: V03:K1:qgQXTqGRSu66gkCHp3ica8IAsn9jBidWqNh7a0167xa6w4e1EyT rzjBJ7597cAawGKmXlThaRJSVOkr4Ul/Vzc8DH9NMqCxifOjMwX5xZhFAfuaPJlpG07zIon u3w4yMpxQXrfbJboCKjEFRfDVTKuFI5KroYde3ill6pNggNwXbVHvx8X/r6z3dGVaaztnUY 7Mld/Ix0Lv5L0Eoq+hDpQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:EH/8jqrPk4A=:redBdVrtPdFfiKrjRdmmVR hwkI+H611nQuAB92/oEOY5GgO6w75u91M/pmuKyaOb7Fchn4LAQQcDvENLTypCMZ5no2dAKcS R2B4sR1LmrvA7qD4Hv6K0J1ywQxRQQCCrbRI5UgHN9wGFSHoRqG7Z7x4Qwjm7iNnpmMn+2HCx XcXTT9UYsH/7auUProq3dZdKsgFG0VwDKsdaZs6giO8ErhzSHiylZG3o337qEi6U3OiLPdD03 o2R4W+Zu+on6SD6GcbbAtjgD5s/w8EY0qNlU3ZdYfgb8QRpyB9DFRmSbmR6PjcMrzAZipD03u sIo9jtlDp0SLchfQfaSIRL1DkZy2spmLYEePThFg0cD6VxK8Yt9Z1/JTZcxuBHNB2xO6woiEz l/ff3rB+RWDRfqTupbRTxgv7ESkIL1AHXHbOX/UXauVQXIxheN5/CRShx9/pEdCqXRxrWAoD7 /Yx0hRMQN70vTmCLoLzZLWyBGJx4rBhbR68TJDZjnIbIr2vAC6mDTzaNvHSg75a7Bcj3uB/1b Tq/avilTZikUQLZ1Zs0WjDR12twmcg+erCXxzSoZB9lJkzle0CZ1RQDxTGa8JBL4EpsqLbokD s6cLQRzcZndPsj0wj7ROao0sowYKd8o3s6qNQDivsYzTjx6dqkdEE00eVOUXU6BurARJidOwj UhIPZSTW5wP0DZPw37oVJd0d0C4TFqiXM6zUfYcxCHb8Wg01rLy4jWx6iUR/b6KXHN/KgQ+ZH sTEwLD8or+dexP+tLE3KLUdYgl0ftG9PFnNG6A+fIL2ShGUKF6vtb9VLWz7fJrlYCffx5SbXE Ski0lbp Subject: Re: [Cake] Hopefully fixed ACK filter for v6 X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2018 11:40:48 -0000 ------NBNY1PN7QQR8DQP7MRG6W0TZV3FICO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Toke,=20 I certainly am thankful for your work, and believe you deserve $CAKE and $= BEVERAGE, I am also leaf to believe 'the cake is a lie' https://m=2Eyoutube= =2Ecom/watch?v=3Dqdrs3gr_GAs ;) Mange Tak Sebastian On April 29, 2018 12:45:26 PM GMT+02:00, "Toke H=C3=B8iland-J=C3=B8rgensen= " wrote: > > >On 29 April 2018 03:01:55 CEST, Ryan Mounce wrot= e: >>On 29 April 2018 at 07:19, Toke H=C3=B8iland-J=C3=B8rgensen >wrote: >>> Think I finally managed to fix the ACK filter so it works for both >>6in4 >>> and regular v6 (the latter seems to have been broken since the >commit >>> "e6b72c2 ack_filter: make less aggressive by default" which >>accidentally >>> reversed the address compare logic)=2E It should also be safe against >>> weirdly fragmented packets (ha! famous last words!)=2E >>> >>> If someone wants to either eyeball the code and/or test the ACK >>filter >>> please do=2E I'm planning to resubmit the patch to netdev sometime >>> tomorrow evening :) >> >>Eyeballing now, only a couple of comments=2E >> >>- Initialisation of iph and ipv6h can be moved before the while() >>loop=2E The compiler probably does this anyway=2E > >Yeah, figured I'd let the compiler deal with that=2E=2E=2E > >>- Whether it is worth the complexity of restoring the >>skb->encapsulation check within cake_get_tcphdr to handle other cases >>of encapsulated v4/v6 traffic=2E I may find some time to test this later >>today=2E > >The reason I removed the check for skb->encapsulation was that in my >tests it wasn't actually set for 6in4 traffic=2E > >And looking at the code that touches it, that field seems to mostly be >related to offloads? Or did you actually see any effect of using it >when you added it initially? :P > >>Everything else looks good to me, much cleaner=2E > >Awesome, thanks for taking a look! > >>Thank you so much for your efforts so far in getting cake upstream, >>and in particular to rescue ACK filtering=2E We may have to send you a >>real cake! > >Haha, you're very welcome=2E Real cake will be appreciated, but don't >feel any obligations ;) > >-Toke >_______________________________________________ >Cake mailing list >Cake@lists=2Ebufferbloat=2Enet >https://lists=2Ebufferbloat=2Enet/listinfo/cake --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------NBNY1PN7QQR8DQP7MRG6W0TZV3FICO Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Toke,

I certainly am thankful for your work, and believe you deserve $CAKE and $= BEVERAGE, I am also leaf to believe 'the cake is a lie' https://m=2Eyoutube=2Ecom/= watch?v=3Dqdrs3gr_GAs ;)



Mange Tak

Sebastian

On April 29, 2018 12:45:26 PM = GMT+02:00, "Toke H=C3=B8iland-J=C3=B8rgensen" <toke@toke=2Edk&= gt; wrote:


On 29 April 2018 03:01:55 CEST, Ryan Mounce =
<ryan@mounce=2Ecom=2Eau> wrote:
On 29 April 2018 at 07:19, Toke H=C3=B8iland-J=C3=B8rgensen =
<toke@toke=2Edk> wrote:
 Think I finally managed to fix the ACK filter so it works for both<=
br>
6in4
 a=
nd regular v6 (the latter seems to have been broken since the commit
 "e=
6b72c2 ack_filter: make less aggressive by default" which
a=
ccidentally
 reversed t=
he address compare logic)=2E It should also be safe against
 weirdly fra=
gmented packets (ha! famous last words!)=2E

 If someone wants to eit=
her eyeball the code and/or test the ACK
filter
 please do=2E I'm planning to resu=
bmit the patch to netdev sometime
 tomorrow evening :)
<=
br>Eyeballing now, only a couple of comments=2E

- Initialisation of =
iph and ipv6h can be moved before the while()
loop=2E The compiler proba=
bly does this anyway=2E

Yeah, figured I'd let the compi= ler deal with that=2E=2E=2E

- Whether it is worth the complexity of restoring the
skb->= encapsulation check within cake_get_tcphdr to handle other cases
of enca= psulated v4/v6 traffic=2E I may find some time to test this later
today= =2E

The reason I removed the check for skb->encapsul= ation was that in my tests it wasn't actually set for 6in4 traffic=2E
And looking at the code that touches it, that field seems to mostly be re= lated to offloads? Or did you actually see any effect of using it when you = added it initially? :P

Everything else looks good to me, much cleaner=2E

A= wesome, thanks for taking a look!

Thank you so much for your efforts so far in getting cake up= stream,
and in particular to rescue ACK filtering=2E We may have to send= you a
real cake!

Haha, you're very welcome=2E Real = cake will be appreciated, but don't feel any obligations ;)

-Toke

Cake mailing list
Cake@lists=2Ebufferbloat=2Enet
https://lists=2Ebufferbloa= t=2Enet/listinfo/cake

--
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E ------NBNY1PN7QQR8DQP7MRG6W0TZV3FICO--