From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by huchra.bufferbloat.net (Postfix) with ESMTP id 86E8E21F1B5 for ; Thu, 15 Oct 2015 00:56:43 -0700 (PDT) Received: from u-089-d065.biologie.uni-tuebingen.de ([134.2.89.65]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MKHtm-1Zkyxr0X6E-001efi; Thu, 15 Oct 2015 09:55:53 +0200 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) From: Sebastian Moeller In-Reply-To: <30FE7948-754A-4599-B2A1-CB3BD5CF873F@gmail.com> Date: Thu, 15 Oct 2015 09:55:45 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <561E3865.6070909@darbyshire-bryant.me.uk> <30FE7948-754A-4599-B2A1-CB3BD5CF873F@gmail.com> To: Jonathan Morton X-Mailer: Apple Mail (2.1878.6) X-Provags-ID: V03:K0:gd/OLrNsOFCVpW3kSnI91jA5iqlGBN4zQzSIDTOs1S0rQF1WAep dbL2AT/Px1mKiDajAx7JSULef1y1+mg2zzBjcdWwK9dkOMGzjfIBUnTYEget/IYVq1hYr5P Pw5Bd0hCD12tUJipUj9TUqRvF2/NEVfDuYkSaqLSzW8rWOI7dze76FKYDJqTat4SpzRwLFS XYEp3ETALQl7QtILrl9oA== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZZKD3aX3das=:r7E2jEF1hW76ts+ZgYMNfe 905qDktabWhiMhvcwC96kBLrCn+4JgJkt+LBa3URenYtzrSsmwzvgczrpik1a8in/36f5CviI nwY6fwCFhbLXufiIvdIKd40mt+GjQRKhovjtc0i+vsCzM718wK3jybJfjXIxaG4juE4REM6qm pyD+I831AcaPqJHZIAO/l+vIsR7GUJgiOW/+D9kN9pp/q9tYfRnIWjRExnDBWA8BiWDjgwRSk VGOI7OzmrD5cAZfSRp0KzGranwMtT2ajtSgb/AV+Y8C+Zz6qajavzUuFpfJpOFt/+jaqkbxkC 7Ym36PD2sHZo2B6gI5Eq9FCrKTINWv/Rj+ioEXIPjWPASGsoL8SjuK45FmRVrTrmZhjq6d3cP Jj16xocsnA0LWC8bOpi8L1cmXaVvmzwMQnG5CdQwRUjXJJo2/AVKL/Zz47YCiv3+TioXlzZUE w74vvk7cP7k1RxmbxzcYMhtRGCnLRlmtTycA1AlMzJZCZe9z5RXCD5Dfr7gLusUYKLRpd2tuF k8y8uiwn7GPQ8UBH+k5zvxiXl5E4DybjXDMjdRmUzKME325/HuUeEw2GxaCG0IcManNr0huDm PRLXywslY/4aCgITSR8ZX1312kkBwX7FrKim5v28yBX1z2pTu82YTkWaPMPgrFd7UHb6EuPrp XPFxwkmwc1Z0hr88IM17qitXTjwTINS4r98hd8+ADajJ0yoa378a1PPajSgnxIFtlcxQOxqkr KIoUIW5736XXOw3xYhxm7ZFQ/KVtfRpVTiXXpZgmSmMV/ZtI2HKsSYvF/b9CK/hjw+fGOAw4t n52uwgt Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Loving the progress on Cake (tins) - tc? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2015 07:58:01 -0000 Hi Jonathan, On Oct 15, 2015, at 06:42 , Jonathan Morton = wrote: >=20 >> On 14 Oct, 2015, at 14:11, Kevin Darbyshire-Bryant = wrote: >>=20 >> Is there a matching update to user space 'tc' yet and I've just = missed >> it? I can see there's been quite a change to the stats structures & >> output so I definitely understand its not a trivial change to 'tc' so >> maybe requires more bake time. >=20 > Toke=92s repo has now been updated accordingly. It still understands = the old format as well as the new one. However, it *does not* read the = interim format, because it cannot be distinguished reliably from the old = format, and the two are mutually incompatible. I guess that is fine, as cake is not upstreamed we can just go = and break backward compatibility. Is there a way to detect that though = to inform the user that they need to upgrade tc and sch_cake to get it = working again? (I have not tested that, so there might be a warning = already...) >=20 > The new stats struct can be extended with new statistics when = required. The old one could be extended with a larger number of = classes/tins, but that proved to be less useful. Although I had left a = generous amount of padding originally, all that space was eventually = used up. >=20 > Also put in now are keywords for the RTT parameter: >=20 > datacentre =3D 100 us > lan =3D 1 ms (covers both ethernet and home wifi) > metro =3D 10 ms > regional =3D 30 ms > internet =3D 100 ms (default) > oceanic =3D 300 ms > satellite =3D 1 second > interplanetary =3D 1 hour This I like, quite a lot! I do wonder though why you keep the = target clamped at 5ms? Especially for the last two that seems not too = helpful. Also would you accept a change to also allow manual setting of = the target (mainly to allow people to do some research, the great thing = about your cake design is that it does the =93right things=94 per = default, but it would be great if it also allowed crazy things if people = ask nicely ;) ). One more question, I noticed that the symbolic overhead names = work quite unexpectedly in that basically the last one specified wins, = except if the last one is via-ethernet, ether-fcs or ether-vlan. We do = not document or enforce the ordering of these keyword in any way, so = this sure will confuse people. My proposal would be to make all additive = (well via-ethernet stays subtractive) so any combination will just = evaluate to the sum of the individual components (I would also include = raw and conservative into the additive list, all in the spirit of having = a simple to explain rationale: all overheads are additive and the = symbolic names really are just constants; note I would then also include = the components, like pppoe pppoe llc snap vcmix individually (though I = ned to check wether these are real constants)). I am volunteering to do = these changes if nobody objects that is. Best Regards Sebastian >=20 > - Jonathan Morton >=20 > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake