From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 89C833B29E for ; Mon, 2 Jul 2018 01:35:33 -0400 (EDT) Received: by mail-wr0-x231.google.com with SMTP id t6-v6so1792090wrn.7 for ; Sun, 01 Jul 2018 22:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heistp.net; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PrqL9Fw6gY3G1r3xkIltJeaZ+NYARI7GG7ubG6102sc=; b=jsr0+7pNTdXOVp74sfA6t6L+B5yL6pymO5A7DwfNPpZ+2Ju87V+uJUzItoKIUZHFdc PMo/qp9mMjFD4o9wkxKCxojrCMvSaPAnwtDACCTVXvBzBtophgI7GXrnt4k4rWtID/zr I4RWnK1IToMmQdbF3ZBOHzWU97Hfoa/l3SYIsLCmIHg6QhfCpvXetyzLDB1XQ9RSyLgl 70lPwbUE9/F8jXKBVBnOseYROo3cJkjcwg1VCi3ySHQ8jq+vE76rpqy3txHSdvzfjXtq 0rtoMKxNZxyvrE6O7TvKVjtit8vWE0m0/+YklDmx4Qfke1/IFIjn8JxGsM0+AWZyCx5u LCmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=PrqL9Fw6gY3G1r3xkIltJeaZ+NYARI7GG7ubG6102sc=; b=JQ63FmVrC7M6Tk4LD17TqCVbG/JXyoYg/zhI5iKMpGsdQLbUwL5mzOBcyMQMAgkPvc nqh1rzvfQhyWjc3Tienry+x++TfJvWc7JIKtJmCa/jrRYjlGmf6JgfB3uKa+JKU3DBWm xK1j+1v+RWSSukEhwTcLLjQFfSDL0x9y3sbjV/jsM2JW6fgXijkJKR+T3fHRp8680cJe ST44tEUmhDEKxoZcnwsmbE/j8L68fpDG/1mJufgl/HvTE6/jJfMtKPe1InjYh8+9+yzI wsiXn2T98j7eHzOwLTpWfoEkT2m8YbaZbZ+DOnIw2+tVOdfvtHht87S3yeUSo6nXLlJV +7Vg== X-Gm-Message-State: APt69E2FVtziZf/JYeAOj0Zl1tB3SH8xLUUgblwDyA0VZHEZ7+JPDlLU 63lrJ4S4291/AgKnyHjNqCfm5A== X-Google-Smtp-Source: AAOMgpdTa+X/2VvRBQ/RdqmJ44p6bmEEEA5uKckvG/AMJ+y+AZWy1cOtvQmWNV4I724gc4ejmRg7ng== X-Received: by 2002:adf:fc8c:: with SMTP id g12-v6mr18180286wrr.216.1530509732701; Sun, 01 Jul 2018 22:35:32 -0700 (PDT) Received: from tron.luk.heistp.net (h-1169.lbcfree.net. [185.193.85.130]) by smtp.gmail.com with ESMTPSA id c128-v6sm5087381wma.17.2018.07.01.22.35.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jul 2018 22:35:32 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) From: Pete Heist In-Reply-To: Date: Mon, 2 Jul 2018 07:35:30 +0200 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Cake List Content-Transfer-Encoding: quoted-printable Message-Id: References: <874lhik871.fsf@toke.dk> To: Dave Taht X-Mailer: Apple Mail (2.3445.8.2) Subject: Re: [Cake] single letter names X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 05:35:33 -0000 > On Jul 2, 2018, at 12:00 AM, Dave Taht wrote: >=20 > I assume l and r are left and right, but m, mb, a and so on are rather > arbitrary. >=20 > I don't care about this enough to change it. > On Sun, Jul 1, 2018 at 4:33 PM Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >>=20 >> Dave Taht writes: >>=20 >>> at least a comment in the code would help. >>>=20 >>> https://lwn.net/Articles/758353/ >>=20 >> I do believe you have commit access=E2=80=A6 One of the Go founders (Andrew Gerrand) gave the rule of thumb that the = greater the distance between a name=E2=80=99s declaration and its uses, = the longer the name should be = (https://talks.golang.org/2014/names.slide). There can be exceptions, = but I rather like and prefer well chosen single letter names for locals = in many cases due to less typing and that the structure can be = understood more quickly. Comments as appropriate that help readers = figure out why the particular letter was chosen are nice, of course, = when it=E2=80=99s not obvious, but that=E2=80=99s just my $0.02=E2=80=A6 = :)