From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id BAE723B29E for ; Sun, 5 Feb 2023 16:44:30 -0500 (EST) Received: by mail-wm1-x333.google.com with SMTP id n28-20020a05600c3b9c00b003ddca7a2bcbso7471278wms.3 for ; Sun, 05 Feb 2023 13:44:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=tLBTWX51Ppp3EXjXUY4F+KgYuJVrauwKqkfIhoMM/jU=; b=cQ/7c9Zy/NeIqPfjj5mF3lVmhxQ90P+swn9N2mEvk2FdMMkJXTKeNc0hezwGH3NCPp xEPrBt3Ns0obS7NSt86/LPV+gXhXIADKIu4uTet/9q1dXSSpI+K06Uz9oVBfhNa8lKNl rtBkZNocUpSP/4nmyDVxRAvPShyIJwagjyEy3adxJZWSkgdd9BqdyiJXvB6xVph7uPCp upOBUzVzAaIsJKbn5H3oJEf0bY8GbWCQKjjPHd8h/Vo0dYH4PIMgYrHuS4dKQ2C9YaY7 M5bFSp8G+ZxLZpsREGxv8mhqZ8d3ZTc7qghjyRwhAQESyl/nyIgh744PdqS7qCtF+zQb hAQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tLBTWX51Ppp3EXjXUY4F+KgYuJVrauwKqkfIhoMM/jU=; b=f3k9VrDJJppwxsNdfMrz5R1o1wUAyaNEehfHHtk+ds0GO1QZXRnZMlnTMOkgLNbpSP PbO2ylHrk/CoZIdPbh6mtByhGneBwAUoYs1up0fkJ6uPKuLC3qz7XU0tuOS9ZC+rsXo4 pFnSe8khmG0uRAzROqPgRzAQ9XUryFYObnqFSkurCZu3+6MGYSi2LkcuMGW8PBUUV+AA f43NkJj/E6Npdg0pwkxnpncvk2z2MvnkmEicRjvPmFNiFiYIELLEX3JNp4whfi5aYEX1 StgPgX5JXJjT2PBpF8INe7UxmEVrW9fAiQEesjI0e0Dp8hmB4QEqlEVGl6cTgY1KSIaF 1izA== X-Gm-Message-State: AO0yUKUmW3ngw1LI19TwKBCOE5eNvLKAQuNJiGn6wR5ydChtZYf/Uzbg AG5K/2dvzRIA+mFKDP88inKoamlhTnGb1A4UVwUSo6fB0p4= X-Google-Smtp-Source: AK7set9mpHN0y/VCygO/lcqawX27vNGvMsm9IUqUoyEfl6qxnLbr5qDir4ZQ9cQg8Wc3bGopGcUTJnHcnc6KpTMuP0o= X-Received: by 2002:a05:600c:310c:b0:3dd:1ca4:9bf4 with SMTP id g12-20020a05600c310c00b003dd1ca49bf4mr772980wmo.205.1675633468812; Sun, 05 Feb 2023 13:44:28 -0800 (PST) MIME-Version: 1.0 From: Dave Taht Date: Sun, 5 Feb 2023 13:44:16 -0800 Message-ID: To: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Cake] flow dissection vs encapsulated traffic? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2023 21:44:30 -0000 In looking how the code has morphed since I last looked at it, I found myself staring at this bit... skb_flow_dissect_flow_keys(skb, &keys, FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL); // so we have delved deeply into the packet at this point... finding various encapsulations... then we get to: /* Don't use the SKB hash if we change the lookup keys from conntra= ck */ if (nat_enabled && cake_update_flowkeys(&keys, skb)) use_skbhash =3D false; This leverages skb_protocol(), which as best as I can tell just peers into the *vlan headers*, not deeper into the packet... Then we proceed merrily into the update_flowkeys code thinking it is the outer type (ipv4), not the inner, then dissect away, using a v4 union... Am I reading this wrong? Please tell me I am reading this wrong... --=20 This song goes out to all the folk that thought Stadia would work: https://www.linkedin.com/posts/dtaht_the-mushroom-song-activity-69813666656= 07352320-FXtz Dave T=C3=A4ht CEO, TekLibre, LLC