Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Pete Heist <pete@heistp.net>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Cake vs fq_codel and c/burst on an ER-X bridge
Date: Tue, 11 Sep 2018 11:42:52 -0700	[thread overview]
Message-ID: <CAA93jw41hGyrMx9PRegyP-UvNj1_ifhYY6t5r4aH8B7ftGJX8Q@mail.gmail.com> (raw)
In-Reply-To: <CAA93jw7o_yiHzO0t8ZJJ3F-Uam7s=2Ybq6yANoSto0LAYhiG-Q@mail.gmail.com>

Next time I have sufficient spare brain cells I would like to try
shaping across cores. I don't know how to
share a bit of data between qdiscs as yet, so my plan to prove it out,
is to use a static variable for time_next_packet (has to be 32 bits
also), and atomically update it between the ksoftirq threads on each
hardware queue.

https://github.com/dtaht/fq_codel_fast/

Don't know if we can round effectively to ns at 32 bits

That would do less work per core with larger intervals between
reschedules with sufficient multiplexing.

In addition to that problem, shaping inbound across cores is currently
serialized to one core (I think) by the sch_ingress qdisc. There was
some new work *way* earlier in the path
https://lwn.net/Articles/763056/ recently - and to try and find some
why to bypass the ingress and mirred portions of the path, and just
pull directly from that would help.

On Tue, Sep 11, 2018 at 11:29 AM Dave Taht <dave.taht@gmail.com> wrote:
>
> that was me shaping at 900.
> On Tue, Sep 11, 2018 at 11:27 AM Pete Heist <pete@heistp.net> wrote:
> >
> >
> > > On Sep 11, 2018, at 10:20 AM, Dave Taht <dave.taht@gmail.com> wrote:
> > >
> > > What I "fixed" was on the apu2 with the burst/cburst change, I went
> > > from completely bottlenecked on one softirq to having 3 eat cpu, and
> > > from 400mbps to 900mbps. Now, that's a quad core and the e1000 (?)
> > > driver. The edgerouter X is a dual core, and you did see a small
> > > improvement in throughput, but I'd hoped for more.
> >
> >
> > That’s rather dramatic. When you do your tests, do you set the shaper to a high number and see how high actual throughput goes, or do you do it some other way? Just in case, I tried setting the ER-X to 350Mbit. htb+fq_codel topped out at 149Mbit, and with c/burst 96000 186 Mbit, so in both types of tests it was about a 25% increase, not small, but unfortunately not 2x!
> >
> > Pete
> >
>
>
> --
>
> Dave Täht
> CEO, TekLibre, LLC
> http://www.teklibre.com
> Tel: 1-669-226-2619



-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619

  reply	other threads:[~2018-09-11 18:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 10:19 [Cake] Cake on elements of a bridge Georgios Amanakis
2018-09-04 10:31 ` Toke Høiland-Jørgensen
2018-09-04 12:01   ` Georgios Amanakis
2018-09-06 17:37     ` Pete Heist
2018-09-06 18:04       ` Toke Høiland-Jørgensen
2018-09-06 18:51         ` Pete Heist
2018-09-10 19:29           ` Pete Heist
2018-09-10 19:55             ` Dave Taht
2018-09-10 22:40               ` [Cake] Cake vs fq_codel and c/burst on an ER-X bridge Pete Heist
2018-09-11  7:54                 ` Sebastian Moeller
2018-09-11  8:20                   ` Dave Taht
2018-09-11  8:20                     ` Sebastian Moeller
2018-09-11  8:30                       ` Dave Taht
2018-09-11  8:43                         ` Sebastian Moeller
2018-09-11 18:27                     ` Pete Heist
2018-09-11 18:29                       ` Dave Taht
2018-09-11 18:42                         ` Dave Taht [this message]
2018-09-19 13:27                     ` Sebastian Moeller
2018-09-19 17:02                       ` Dave Taht
2018-09-20 10:34                         ` Sebastian Moeller
2018-09-20 17:05                           ` Dave Taht
2018-09-20 18:19                             ` Sebastian Moeller
2018-09-20 18:31                               ` Dave Taht
2018-09-11 18:09                   ` Pete Heist
2018-09-11 18:28                     ` Sebastian Moeller
2018-09-11 18:45                       ` Pete Heist
2018-09-11 18:47                         ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw41hGyrMx9PRegyP-UvNj1_ifhYY6t5r4aH8B7ftGJX8Q@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=pete@heistp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox