From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22a.google.com (mail-qt0-x22a.google.com [IPv6:2607:f8b0:400d:c0d::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 6699D3BA8E for ; Wed, 6 Dec 2017 02:05:10 -0500 (EST) Received: by mail-qt0-x22a.google.com with SMTP id i40so6680609qti.8 for ; Tue, 05 Dec 2017 23:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7VgIyZwsQlMCxjJ4a1rNZwkuJn6sUBlyfvWjnM/PPr0=; b=O6pRPzCZT/G2B1eSpSb581PYUjdT+2xu68VaeZcIU+ZJWbidJ4v0RLGy8a/936bh+/ HJ8UWYh2srkmiursKode7VnqAqedlO/Kz0zOVVwnQPr3SjIkeRvs+UTkoTZvjUcGpTY2 xgBv0mBoRrS1BYR0KcDicb9bQ0TjGfadQzy+49W4LTD++WuLCSGyTZcLluR3j//h9QEu CsOnAMcZso7JBgGzGfQH4vQZQ71exdqr0bt7Fwxlg8BbaV2ERbFg4GOHwPLoGU6A3TPG Tt0WiU2f4SEVo+3VFjZfXPgAldBXgrA254ey9UBvXtKLbPq+SHK5el8n1hWyaq1cfZve vGpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7VgIyZwsQlMCxjJ4a1rNZwkuJn6sUBlyfvWjnM/PPr0=; b=jlRDqsdvQH7NgwuHAv2A8R0qXkTum4M0PjXbDRZ+N+ga/3CEQG0W7qkhsoaxBsnHDy yOHqRC1OmQLgAVIkRYQMwGq7CGt8Rd0Xbi5ELz4+pYrSa7Q/5mnPaNs8wxZni5vLPYrk L0qqCtjMK5lclCrc/jf9GVsQSt3XJZhqafJcwSrTzatxzWOCGGTmxn+hhdw8xDl0S8QJ powTdHC+geL9fRME0WLgVmKwngLppXtAIPp3q/JHUluwxNjqHaSF7nCj0CO94qYqLphw zeJUmxQK6be5S4OS9DOe5uM+2ZymVrqGYYrqqSykaKEkQLq6IKIV4ZXTSp936qkgaV41 7tnw== X-Gm-Message-State: AKGB3mIn/YaiewsSSf0bJm5XRVmfWq7WBCaoGQWR81ZVPNpTItpnWJAk P17vlMftEvpgku54Ndf5gaPVtohfeQLEWXvTYZs= X-Google-Smtp-Source: AGs4zMaM1XhGAm9cOVcw1iMGVepcTp2ONAdDgftvnYdQDtv2kttMyHTdIlvWmuxDIWeACBTyXJf2AZKAGHpv2mMUeis= X-Received: by 10.55.165.129 with SMTP id o123mr22812812qke.8.1512543909967; Tue, 05 Dec 2017 23:05:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Tue, 5 Dec 2017 23:05:09 -0800 (PST) In-Reply-To: References: From: Dave Taht Date: Tue, 5 Dec 2017 23:05:09 -0800 Message-ID: To: Jonathan Morton Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] set filtered acks to bulk mode X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 07:05:10 -0000 On Tue, Dec 5, 2017 at 10:08 PM, Jonathan Morton wr= ote: > This is all sorts of wrong. Going 1 out of 2 on untested patches for the day is not too horrible. (sorry for crashing your router Ryan!!) > First, setting the enum isn't sufficient to actually make the flow bulk. > You need to move it to the bulk queue-of-queues and update the stats > counters too. That's probably why it's crashing for Ryan. I had figured that would happen on the next round. :( > > Second, I fail to see why this is necessary or even desirable. If there = are > enough acks to activate the filter, then I assume it should be treated as > bulk already. Or, if the filter itself thins out the acks enough to make= it > sparse, then it still makes sense to deliver those acks timely Consider the case where you are emptying the queue on a regular basis. As this is indeed, a bulk flow at this point, there is no need to give it any extra boost. > so as to > maximise the reduced information they carry. Remember too that Codel > implements head drop precisely to minimise the feedback lag via ack. > > - Jonathan Morton --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619