Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] [PATCH net-next 3/3] Add support for building the new cake qdisc
Date: Mon, 4 Dec 2017 20:48:41 -0800	[thread overview]
Message-ID: <CAA93jw47QsySzN60my=iTop9CUH2zueG8xT6z0kWt9MerXQ3Qw@mail.gmail.com> (raw)
In-Reply-To: <201712051010.18kFjMiy%fengguang.wu@intel.com>

grump.

On Mon, Dec 4, 2017 at 8:41 PM, kbuild test robot <lkp@intel.com> wrote:
> Hi Dave,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on net-next/master]
>
> url:    https://github.com/0day-ci/linux/commits/Dave-Taht/Add-Common-Applications-Kept-Enhanced-cake-qdisc/20171205-053924
> config: parisc-allmodconfig (attached as .config)
> compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # save the attached .config to linux build tree
>         make.cross ARCH=parisc
>
> All warnings (new ones prefixed by >>):
>
>    net/sched/sch_cake.c: In function 'cake_dump_stats':
>>> net/sched/sch_cake.c:2530:1: warning: the frame size of 1424 bytes is larger than 1280 bytes [-Wframe-larger-than=]
>     }
>     ^
>
> vim +2530 net/sched/sch_cake.c
>
> 8c28e37b Dave Taht 2017-12-03  2479
> 8c28e37b Dave Taht 2017-12-03  2480  static int cake_dump_stats(struct Qdisc *sch, struct gnet_dump *d)
> 8c28e37b Dave Taht 2017-12-03  2481  {
> 8c28e37b Dave Taht 2017-12-03  2482     struct cake_sched_data *q = qdisc_priv(sch);
> 8c28e37b Dave Taht 2017-12-03  2483     struct tc_cake_xstats *st = kvzalloc(sizeof(*st), GFP_KERNEL);
> 8c28e37b Dave Taht 2017-12-03  2484     int i;
> 8c28e37b Dave Taht 2017-12-03  2485
> 8c28e37b Dave Taht 2017-12-03  2486     if (!st)
> 8c28e37b Dave Taht 2017-12-03  2487             return -ENOMEM;
> 8c28e37b Dave Taht 2017-12-03  2488
> 8c28e37b Dave Taht 2017-12-03  2489     st->version = 5;
> 8c28e37b Dave Taht 2017-12-03  2490     st->max_tins = TC_CAKE_MAX_TINS;
> 8c28e37b Dave Taht 2017-12-03  2491     st->tin_cnt = q->tin_cnt;
> 8c28e37b Dave Taht 2017-12-03  2492
> 8c28e37b Dave Taht 2017-12-03  2493     for (i = 0; i < q->tin_cnt; i++) {
> 8c28e37b Dave Taht 2017-12-03  2494             struct cake_tin_data *b = &q->tins[q->tin_order[i]];
> 8c28e37b Dave Taht 2017-12-03  2495
> 8c28e37b Dave Taht 2017-12-03  2496             st->threshold_rate[i] = b->tin_rate_bps;
> 8c28e37b Dave Taht 2017-12-03  2497             st->target_us[i]      = cobalt_time_to_us(b->cparams.target);
> 8c28e37b Dave Taht 2017-12-03  2498             st->interval_us[i]    = cobalt_time_to_us(b->cparams.interval);
> 8c28e37b Dave Taht 2017-12-03  2499
> 8c28e37b Dave Taht 2017-12-03  2500             /* TODO FIXME: add missing aspects of these composite stats */
> 8c28e37b Dave Taht 2017-12-03  2501             st->sent[i].packets       = b->packets;
> 8c28e37b Dave Taht 2017-12-03  2502             st->sent[i].bytes         = b->bytes;
> 8c28e37b Dave Taht 2017-12-03  2503             st->dropped[i].packets    = b->tin_dropped;
> 8c28e37b Dave Taht 2017-12-03  2504             st->ecn_marked[i].packets = b->tin_ecn_mark;
> 8c28e37b Dave Taht 2017-12-03  2505             st->backlog[i].bytes      = b->tin_backlog;
> 8c28e37b Dave Taht 2017-12-03  2506             st->ack_drops[i].packets  = b->ack_drops;
> 8c28e37b Dave Taht 2017-12-03  2507
> 8c28e37b Dave Taht 2017-12-03  2508             st->peak_delay_us[i] = cobalt_time_to_us(b->peak_delay);
> 8c28e37b Dave Taht 2017-12-03  2509             st->avge_delay_us[i] = cobalt_time_to_us(b->avge_delay);
> 8c28e37b Dave Taht 2017-12-03  2510             st->base_delay_us[i] = cobalt_time_to_us(b->base_delay);
> 8c28e37b Dave Taht 2017-12-03  2511
> 8c28e37b Dave Taht 2017-12-03  2512             st->way_indirect_hits[i] = b->way_hits;
> 8c28e37b Dave Taht 2017-12-03  2513             st->way_misses[i]        = b->way_misses;
> 8c28e37b Dave Taht 2017-12-03  2514             st->way_collisions[i]    = b->way_collisions;
> 8c28e37b Dave Taht 2017-12-03  2515
> 8c28e37b Dave Taht 2017-12-03  2516             st->sparse_flows[i]      = b->sparse_flow_count +
> 8c28e37b Dave Taht 2017-12-03  2517                                        b->decaying_flow_count;
> 8c28e37b Dave Taht 2017-12-03  2518             st->bulk_flows[i]        = b->bulk_flow_count;
> 8c28e37b Dave Taht 2017-12-03  2519             st->unresponse_flows[i]  = b->unresponsive_flow_count;
> 8c28e37b Dave Taht 2017-12-03  2520             st->spare[i]             = 0;
> 8c28e37b Dave Taht 2017-12-03  2521             st->max_skblen[i]        = b->max_skblen;
> 8c28e37b Dave Taht 2017-12-03  2522     }
> 8c28e37b Dave Taht 2017-12-03  2523     st->capacity_estimate = q->avg_peak_bandwidth;
> 8c28e37b Dave Taht 2017-12-03  2524     st->memory_limit      = q->buffer_limit;
> 8c28e37b Dave Taht 2017-12-03  2525     st->memory_used       = q->buffer_max_used;
> 8c28e37b Dave Taht 2017-12-03  2526
> 8c28e37b Dave Taht 2017-12-03  2527     i = gnet_stats_copy_app(d, st, sizeof(*st));
> 8c28e37b Dave Taht 2017-12-03  2528     cake_free(st);
> 8c28e37b Dave Taht 2017-12-03  2529     return i;
> 8c28e37b Dave Taht 2017-12-03 @2530  }
> 8c28e37b Dave Taht 2017-12-03  2531
>
> :::::: The code at line 2530 was first introduced by commit
> :::::: 8c28e37b67a2c9259e413f7dc39d6c84c08e8c75 Add Common Applications Kept Enhanced (cake) qdisc
>
> :::::: TO: Dave Taht <dave.taht@gmail.com>
> :::::: CC: 0day robot <fengguang.wu@intel.com>
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619

  parent reply	other threads:[~2017-12-05  4:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-03 22:06 [Cake] [PATCH net-next 0/3] Add Common Applications Kept Enhanced (cake) qdisc Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 2/3] Add Common Applications Kept Enhanced (cake) qdisc Dave Taht
2017-12-03 22:06 ` [Cake] [PATCH net-next 3/3] Add support for building the new cake qdisc Dave Taht
     [not found]   ` <201712051010.18kFjMiy%fengguang.wu@intel.com>
2017-12-05  4:48     ` Dave Taht [this message]
2018-04-24 11:44 ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-04-24 11:44   ` [Cake] [PATCH iproute2-next v2] Add support for cake qdisc Toke Høiland-Jørgensen
2018-04-24 12:30     ` [Cake] [PATCH iproute2-next v3] " Toke Høiland-Jørgensen
2018-04-24 14:44       ` Stephen Hemminger
2018-04-24 14:45       ` Stephen Hemminger
2018-04-24 14:52         ` Toke Høiland-Jørgensen
2018-04-24 15:10           ` Stephen Hemminger
2018-04-24 15:38             ` Toke Høiland-Jørgensen
2018-04-24 15:11   ` [Cake] [PATCH net-next v2] Add Common Applications Kept Enhanced (cake) qdisc Stephen Hemminger
2018-04-24 15:14   ` Stephen Hemminger
2018-04-24 15:32     ` Georgios Amanakis
2018-04-24 15:41       ` Toke Høiland-Jørgensen
     [not found]         ` <CACvFP_hzHY+=qPh6_=_++UhbnAU1xjPguY7fNzG0TSVhYm0V3Q@mail.gmail.com>
2018-04-24 15:51           ` Georgios Amanakis
2018-04-24 16:03             ` Toke Høiland-Jørgensen
2018-04-26 19:16   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA93jw47QsySzN60my=iTop9CUH2zueG8xT6z0kWt9MerXQ3Qw@mail.gmail.com' \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox