From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com [IPv6:2607:f8b0:400d:c0d::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2C2833B29E for ; Mon, 4 Dec 2017 23:48:42 -0500 (EST) Received: by mail-qt0-x243.google.com with SMTP id e2so26352183qti.0 for ; Mon, 04 Dec 2017 20:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=zrsEuqGarFEXvFWXpYmeKrq2H66hgEs4+NIGtDwmcAo=; b=Mcl9JypAEkkkBpV4ndCA/yLOZ8xf8PZa6wvvYly2iislqLPDOWGUmtJzTV2PLNZBId l4OUXLpkM2SVn6gu3i6UTAfzVeYXlIOQ9sekO0wLlMsM1FHYVI9Wl7Ui0rnU0RhZ0sA7 aDSvDq03Wgltg4CGVx7cy8ffWlTeUaXJaru7OuRNXk7KQ3vgOdp+D8mfSG+mzvwjcys5 Ea560uXuUfZasoIFu/YZFZ2kNNODgSgcBQre+83xjAXZZ0HITyI8VrO/gaKUD8tZwmAL 3XN1+ITnu9t2GrzNhCt4vqgM8M8QJX4hbfeahXJPZfkHJUrNTw6d9EOaxoVQBn+A8Wg0 1Rtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=zrsEuqGarFEXvFWXpYmeKrq2H66hgEs4+NIGtDwmcAo=; b=d0pC4F+Q3jTNebcOytZ+UkkNAd0Bv0s4Ry7Y6DY35x64p3B4iITQIQzRHGtB4Oc9xe tQsVEhQ6tbxvi2G9BnvCDKtAtGLy2zDUxx4o1dsUpsF6vzyqqbAaYz7R2RbFwCn0qVYC zAnkxG8F5TyWig7eyBpVffh2ZU8+pxhq2Pd09S+DRgD5HRmSrs2GtYDPze5tH7/GJNyJ EC5htnPJrCPATB49j6t+gBgQi/3l5s0RekbD/uWQxAf9gBhhP0I2/8JZq7mwVQIkeQIl qHuY88DWoSGrBtN4H7JjVbnnyL/o6ByAScJ7C65GdtrL6I+kjD7iQE+ppXGKNh6Sw10X NDkA== X-Gm-Message-State: AKGB3mLWB8ThDjrrB3gBW2csOKFAg6OjhumXgXdmOqylOLz6athSUmoZ tRnY67fYYVEg4LZz0exSGyrg/IsU5Tnht81tI0A= X-Google-Smtp-Source: AGs4zMbyiNrHjqUBFatVtLljmDzEUcAVhyHH3E0WFnz2xQWCKme2N6ikIRRn/ZautYYCJCoi7953UhcDICNfUKfao/I= X-Received: by 10.55.120.199 with SMTP id t190mr21482931qkc.63.1512449321485; Mon, 04 Dec 2017 20:48:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Mon, 4 Dec 2017 20:48:41 -0800 (PST) In-Reply-To: <201712051010.18kFjMiy%fengguang.wu@intel.com> References: <1512338775-3270-4-git-send-email-dave.taht@gmail.com> <201712051010.18kFjMiy%fengguang.wu@intel.com> From: Dave Taht Date: Mon, 4 Dec 2017 20:48:41 -0800 Message-ID: To: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next 3/3] Add support for building the new cake qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 04:48:42 -0000 grump. On Mon, Dec 4, 2017 at 8:41 PM, kbuild test robot wrote: > Hi Dave, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: https://github.com/0day-ci/linux/commits/Dave-Taht/Add-Common-App= lications-Kept-Enhanced-cake-qdisc/20171205-053924 > config: parisc-allmodconfig (attached as .config) > compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=3Dparisc > > All warnings (new ones prefixed by >>): > > net/sched/sch_cake.c: In function 'cake_dump_stats': >>> net/sched/sch_cake.c:2530:1: warning: the frame size of 1424 bytes is l= arger than 1280 bytes [-Wframe-larger-than=3D] > } > ^ > > vim +2530 net/sched/sch_cake.c > > 8c28e37b Dave Taht 2017-12-03 2479 > 8c28e37b Dave Taht 2017-12-03 2480 static int cake_dump_stats(struct Qd= isc *sch, struct gnet_dump *d) > 8c28e37b Dave Taht 2017-12-03 2481 { > 8c28e37b Dave Taht 2017-12-03 2482 struct cake_sched_data *q =3D qdi= sc_priv(sch); > 8c28e37b Dave Taht 2017-12-03 2483 struct tc_cake_xstats *st =3D kvz= alloc(sizeof(*st), GFP_KERNEL); > 8c28e37b Dave Taht 2017-12-03 2484 int i; > 8c28e37b Dave Taht 2017-12-03 2485 > 8c28e37b Dave Taht 2017-12-03 2486 if (!st) > 8c28e37b Dave Taht 2017-12-03 2487 return -ENOMEM; > 8c28e37b Dave Taht 2017-12-03 2488 > 8c28e37b Dave Taht 2017-12-03 2489 st->version =3D 5; > 8c28e37b Dave Taht 2017-12-03 2490 st->max_tins =3D TC_CAKE_MAX_TINS= ; > 8c28e37b Dave Taht 2017-12-03 2491 st->tin_cnt =3D q->tin_cnt; > 8c28e37b Dave Taht 2017-12-03 2492 > 8c28e37b Dave Taht 2017-12-03 2493 for (i =3D 0; i < q->tin_cnt; i++= ) { > 8c28e37b Dave Taht 2017-12-03 2494 struct cake_tin_data *b = =3D &q->tins[q->tin_order[i]]; > 8c28e37b Dave Taht 2017-12-03 2495 > 8c28e37b Dave Taht 2017-12-03 2496 st->threshold_rate[i] =3D= b->tin_rate_bps; > 8c28e37b Dave Taht 2017-12-03 2497 st->target_us[i] =3D= cobalt_time_to_us(b->cparams.target); > 8c28e37b Dave Taht 2017-12-03 2498 st->interval_us[i] =3D= cobalt_time_to_us(b->cparams.interval); > 8c28e37b Dave Taht 2017-12-03 2499 > 8c28e37b Dave Taht 2017-12-03 2500 /* TODO FIXME: add missin= g aspects of these composite stats */ > 8c28e37b Dave Taht 2017-12-03 2501 st->sent[i].packets = =3D b->packets; > 8c28e37b Dave Taht 2017-12-03 2502 st->sent[i].bytes = =3D b->bytes; > 8c28e37b Dave Taht 2017-12-03 2503 st->dropped[i].packets = =3D b->tin_dropped; > 8c28e37b Dave Taht 2017-12-03 2504 st->ecn_marked[i].packets= =3D b->tin_ecn_mark; > 8c28e37b Dave Taht 2017-12-03 2505 st->backlog[i].bytes = =3D b->tin_backlog; > 8c28e37b Dave Taht 2017-12-03 2506 st->ack_drops[i].packets = =3D b->ack_drops; > 8c28e37b Dave Taht 2017-12-03 2507 > 8c28e37b Dave Taht 2017-12-03 2508 st->peak_delay_us[i] =3D = cobalt_time_to_us(b->peak_delay); > 8c28e37b Dave Taht 2017-12-03 2509 st->avge_delay_us[i] =3D = cobalt_time_to_us(b->avge_delay); > 8c28e37b Dave Taht 2017-12-03 2510 st->base_delay_us[i] =3D = cobalt_time_to_us(b->base_delay); > 8c28e37b Dave Taht 2017-12-03 2511 > 8c28e37b Dave Taht 2017-12-03 2512 st->way_indirect_hits[i] = =3D b->way_hits; > 8c28e37b Dave Taht 2017-12-03 2513 st->way_misses[i] = =3D b->way_misses; > 8c28e37b Dave Taht 2017-12-03 2514 st->way_collisions[i] = =3D b->way_collisions; > 8c28e37b Dave Taht 2017-12-03 2515 > 8c28e37b Dave Taht 2017-12-03 2516 st->sparse_flows[i] = =3D b->sparse_flow_count + > 8c28e37b Dave Taht 2017-12-03 2517 = b->decaying_flow_count; > 8c28e37b Dave Taht 2017-12-03 2518 st->bulk_flows[i] = =3D b->bulk_flow_count; > 8c28e37b Dave Taht 2017-12-03 2519 st->unresponse_flows[i] = =3D b->unresponsive_flow_count; > 8c28e37b Dave Taht 2017-12-03 2520 st->spare[i] = =3D 0; > 8c28e37b Dave Taht 2017-12-03 2521 st->max_skblen[i] = =3D b->max_skblen; > 8c28e37b Dave Taht 2017-12-03 2522 } > 8c28e37b Dave Taht 2017-12-03 2523 st->capacity_estimate =3D q->avg_= peak_bandwidth; > 8c28e37b Dave Taht 2017-12-03 2524 st->memory_limit =3D q->buff= er_limit; > 8c28e37b Dave Taht 2017-12-03 2525 st->memory_used =3D q->buff= er_max_used; > 8c28e37b Dave Taht 2017-12-03 2526 > 8c28e37b Dave Taht 2017-12-03 2527 i =3D gnet_stats_copy_app(d, st, = sizeof(*st)); > 8c28e37b Dave Taht 2017-12-03 2528 cake_free(st); > 8c28e37b Dave Taht 2017-12-03 2529 return i; > 8c28e37b Dave Taht 2017-12-03 @2530 } > 8c28e37b Dave Taht 2017-12-03 2531 > > :::::: The code at line 2530 was first introduced by commit > :::::: 8c28e37b67a2c9259e413f7dc39d6c84c08e8c75 Add Common Applications K= ept Enhanced (cake) qdisc > > :::::: TO: Dave Taht > :::::: CC: 0day robot > > --- > 0-DAY kernel test infrastructure Open Source Technology Ce= nter > https://lists.01.org/pipermail/kbuild-all Intel Corpora= tion --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619