From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x242.google.com (mail-qt0-x242.google.com [IPv6:2607:f8b0:400d:c0d::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 71C9E3B29E for ; Sun, 1 Jul 2018 10:02:49 -0400 (EDT) Received: by mail-qt0-x242.google.com with SMTP id a18-v6so11848147qtj.4 for ; Sun, 01 Jul 2018 07:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vUArVD6ABWblzMhMqrKb5lD8mJRJMkzolM5pKdiqJjs=; b=lG7FiRH0hj0UT5F4Bk/SkwaujArK/zXGihfKJE80mFMNoiBjt6UXfQ5+4IyNDCy4X6 B5aHlaygBwHexaRBrypGoLbpt28UYRVYf3JBpxpAO0ywQvUHOqNW9ZquzLb8jvbS9RKK /lGujHTc19WnKFHA3HoFU60Otlw+AHNTIMSjejsAZPgSZYAdpB1o+28wh7aIE2TekVvl 4L0eXy8GSPUM5Ev3s5gsh70sErVdYHhcnIxd6BxmE/n19oTrqyINMLZVbdkjKDpv4Kew KzwvYPAHffPDVhO9h0+GuhzvBIYQq+3GruQyvd0mBI5MqxnP7H0sRpl9MwMqhA2MfZtJ Pu8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vUArVD6ABWblzMhMqrKb5lD8mJRJMkzolM5pKdiqJjs=; b=pIbpawvPXSyk9eNjyazE2wdhvexNLuypRK36jBBX9qDUntYmgtdWqPtILM6AM3p6Ai QDuXlwn6rSF/zawReKAMpwaHsYFnmN10Xq/mK7ZeG9Mrugm1PIfKzi0M0G7ge4noR/oS s4LKTIwOZ4yNnx++SQnLVGoB/WtJSEvFTHjXOmcPx7ugkkRpWt54c4RK6M8JkN3xthLN 0xprFtxv85qWLwJ0gsrl2l8RC6fNhHf/lQHC87e7mCr9gzgkWFPZ0CJfvNlZxYhyKnCh Xq/3vSR7TzMZPZREURbyc1H0OHxkuGjHIPy9c5eLttDapjpCt3FgUI0nbrua9CTLPG4q LRDw== X-Gm-Message-State: APt69E0nDIHUxyOKiclRhD2GFQ55rLtmf7Splecw/MeE5Eke/60FFkXV TDlpgZ6ZnaKYK4M3YVgbsKwe5wZ7YCHicw8v1Xc= X-Google-Smtp-Source: AAOMgpfAjBgUOYHG7Zra14jeWVoEy9dXMHMU2XqoxyrzgeIgaVPasanrfdvnNmkXmF8NMhga6P18/UZYZnYOYEoGKGY= X-Received: by 2002:aed:2686:: with SMTP id q6-v6mr8714577qtd.199.1530453768821; Sun, 01 Jul 2018 07:02:48 -0700 (PDT) MIME-Version: 1.0 References: <6DF9A5E0-EFD5-4519-9889-BC0A7B9BD48E@darbyshire-bryant.me.uk> <1A8BA286-6B31-4581-86C9-6855AC28C245@heistp.net> <673EAD3F-AB09-4B90-88BB-5DCE0BD65534@heistp.net> <6FE8D434-01BE-41A1-BD6B-EFFD67AC8784@heistp.net> In-Reply-To: From: Dave Taht Date: Sun, 1 Jul 2018 10:02:59 -0400 Message-ID: To: Pete Heist Cc: Kevin Darbyshire-Bryant , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Cake on openwrt - falling behind X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 14:02:49 -0000 I'm in no position to help (on the road). But please test also cake's 4 and 8 tin modes on arm and mips. Does cake besteffort work on mips? On Sun, Jul 1, 2018 at 9:49 AM Pete Heist wrote: > > Ok, my reboots were because I need to compile with om-watchdog support, o= therwise the OM2P=E2=80=99s hardware watchdog reboots every few minutes. Th= us, my sysupgrades were not _actually_ working (watchdog was interrupting t= hem), thus the unknown symbols / dependency problems, etc, so that=E2=80=99= s behind me. :/ > > And yes, I get no tin stats without the patch. With the patch, I get tin = stats as expected. This is probably nothing new. > > I also compiled on a Raspi 2 (32-bit ARM) running Debian 9.4, and it work= s as expected without the patch. This probably just confirms what George re= ported, because I think his wrt1900acs also uses 32-bit ARM. > > So yes, MIPS 32-bit, both le and be are both fails. What next? We could t= est more archs, but it might be more productive to attempt to figure it out= in the code when I can at least repro it on MIPS. > > You mentioned earlier netlink_parse_nested doesn=E2=80=99t seem to handle= 64-bit values but I=E2=80=99m not seeing where that is. I=E2=80=99m gettin= g my head around how stats work so just writing out loud=E2=80=A6looks like= there are qstats from struct Qdisc then the tin stats which are probably c= ustom for Cake and stored at some address obtained from qdisc_priv, which i= s right after the regular Qdisc struct. Interesting. I=E2=80=99m searching = now for how this data ends up in tc=E2=80=99s hands, which looks like happe= ns in cake_print_xstats with parse_rtattr_nested, then the printing gets un= derway, and at some point if st[TCA_CAKE_STATS_TIN_STATS] is true it gets i= nto the tin printing business. What=E2=80=99s the condition that fails to m= ake the tin stats not be printed? Best I know is to add debugging statement= s to figure it out, which I might give a try later today. Am I on the right= track? > > > On Jul 1, 2018, at 9:18 AM, Pete Heist wrote: > > > > Ok, so I=E2=80=99ve got to figure out what=E2=80=99s up with my build i= n general, so I=E2=80=99m blowing away my source tree and will build master= without any patches. > > > > I don=E2=80=99t know if the kernel panics and unknown symbols are relat= ed somehow, but they=E2=80=99re not helping(!) so I=E2=80=99ll try to get p= ast that. I don=E2=80=99t actually get logs in /sys/kernel/debug/crashlog, = so I can=E2=80=99t even prove it=E2=80=99s a panic, but it=E2=80=99s reboot= ing that usually happens just as I do something net related, like start typ= ing in ssh or do an scp, after some period of inactivity. If it=E2=80=99s r= eproducible on an unpatched build I=E2=80=99ll head over to the OpenWRT uni= verse. > > > > (the stats alignment is just proportional vs fixed fonts- they look fin= e in vim) > > > >> On Jul 1, 2018, at 4:37 AM, Georgios Amanakis wr= ote: > >> > >> The stats got mangled in by the email, in the terminal they are > >> properly aligned. > >> > >> > >> ---------- Forwarded message ---------- > >> From: Georgios Amanakis > >> Date: Sat, Jun 30, 2018 at 10:35 PM > >> Subject: Re: [Cake] Cake on openwrt - falling behind > >> To: Pete Heist > >> > >> > >> I just tested this on my wrt1900acs but it is behaving as it should. I > >> used Kevin's RFC patches for iproute2 and kmod-sched-cake. > >> > >> root@lede:/tmp# tc -s qdisc show dev eth0 > >> qdisc cake 8004: root refcnt 9 bandwidth 2500Kbit diffserv3 > >> triple-isolate split-gso rtt 100.0ms raw overhead 0 > >> Sent 122745 bytes 691 pkt (dropped 0, overlimits 419 requeues 0) > >> backlog 0b 0p requeues 0 > >> memory used: 6416b of 4Mb > >> capacity estimate: 2500Kbit > >> min/max network layer size: 42 / 1186 > >> min/max overhead-adjusted size: 42 / 1186 > >> average network hdr offset: 13 > >> > >> Bulk Best Effort Voice > >> thresh 156248bit 2500Kbit 625Kbit > >> target 116.3ms 7.3ms 29.1ms > >> interval 232.6ms 102.3ms 124.1ms > >> pk_delay 0us 196us 8.6ms > >> av_delay 0us 13us 1.3ms > >> sp_delay 0us 2us 38us > >> backlog 0b 0b 0b > >> pkts 0 414 277 > >> bytes 0 38367 84378 > >> way_inds 0 0 0 > >> way_miss 0 20 2 > >> way_cols 0 0 0 > >> drops 0 0 0 > >> marks 0 0 0 > >> ack_drop 0 0 0 > >> sp_flows 0 1 0 > >> bk_flows 0 0 1 > >> un_flows 0 0 0 > >> max_len 0 206 1186 > >> quantum 300 300 300 > >> > >> root@lede:/tmp# opkg list-installed | grep cake > >> kmod-sched-cake - 4.14.50+2018-06-26-0520a6cb-1 > >> > >> root@lede:/tmp# uname -a > >> Linux lede 4.14.50 #0 SMP Wed Jun 27 21:48:32 2018 armv7l GNU/Linux > >> > >> George > >> > >> On Sat, Jun 30, 2018 at 7:20 PM, Pete Heist wrote: > >>> Ok, same result (unknown symbols and routine crashing) after a make c= lean and re-build, but I just force installed the kmod-sched-cake package w= ith --force-depends and it seems to work. This reproduces it, right? no sta= ts and the debug output? > >>> > >>> root@LEDE:~# tc qdisc add dev eth0 root cake > >>> root@LEDE:~# tc -s -d qdisc show dev eth0 > >>> qdisc cake 8001: root refcnt 2 bandwidth unlimited diffserv3 triple-i= solate rtt 100.0ms raw overhead 0 > >>> tca_stats 2005579564 tca_stats2 0 tca_xstats 0 > >>> calling print_tcstats_attr() > >>> print_tcstats_attr() > >>> got stats > >>> Sent 9070 bytes 66 pkts (dropped 0, overlimits 0) > >>> got xstats 0 tca_stats 2005579564 tca_stats2 0 tca_xstats 0 > >>> > >>> root@LEDE:~# cat /proc/cpuinfo > >>> system type : Atheros AR7240 rev 2 > >>> machine : OpenMesh OM2P > >>> processor : 0 > >>> cpu model : MIPS 24Kc V7.4 > >>> BogoMIPS : 265.42 > >>> wait instruction : yes > >>> microsecond timers : yes > >>> tlb_entries : 16 > >>> extra interrupt vector : yes > >>> hardware watchpoint : yes, count: 4, address/irw mask: [0x0ffc, 0= x0ffc, 0x0ffb, 0x0ffb] > >>> isa : mips1 mips2 mips32r1 mips32r2 > >>> ASEs implemented : mips16 > >>> shadow register sets : 1 > >>> kscratch registers : 0 > >>> package : 0 > >>> core : 0 > >>> VCED exceptions : not available > >>> VCEI exceptions : not available > >>> > >> _______________________________________________ > >> Cake mailing list > >> Cake@lists.bufferbloat.net > >> https://lists.bufferbloat.net/listinfo/cake > > > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619