From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x229.google.com (mail-qk0-x229.google.com [IPv6:2607:f8b0:400d:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id CCACD3BA8E for ; Thu, 23 Nov 2017 16:55:55 -0500 (EST) Received: by mail-qk0-x229.google.com with SMTP id w125so22467686qkb.6 for ; Thu, 23 Nov 2017 13:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=WOSrUlFWcnsDKijll5nUo3BJGda8aWJwtxLl4bBi1/g=; b=H2a4PKzEkJ0Y8Hi2pNSk2Y9DaB9WvQ1BA7y95FgCBL7SATumuozJ9Z2uvoHmRwEvJT hR19RijfKQD623V390EQLRLO5FLt9rbJO9abyAFtsOEJ6wkLMWnzHI9SO9NxpStF0Bqd GGqq/C67n2EBF9Pl5xSI7i/93JlCCmOSr5mxELQ9GYqkwTCbQ5O7qDeoeh7Wo02ZCpac +yXWy1rcWG1ZIQ1vrtNtu6I/uBeUZy+TiqQ0SflL8sxObqd6CX0P1e6fXLIZDkBrGku8 VDZDOdWBRaT9cEv7fBQ8wSioGe3iWvNvggVRDdEUFLB6lkuwfQosAeD65d5ueKOMlaK8 8Teg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc :content-transfer-encoding; bh=WOSrUlFWcnsDKijll5nUo3BJGda8aWJwtxLl4bBi1/g=; b=Aj/DaSAwDJNOetXM7NqWnbngDsYKy18sNsjSTGZ4g/TTQjsV96ShpjFkY5Syy9YNxg eROiL6nOxbgagNK9fYF0JHDNCT7MiedG4ayf1Z4GEc9Rt6px61TftIxvx3tRc1z1QmJb OnzCqVE+8s/7E+7tjOA3po9rUOEGekCk8TOFG7TuvRP8UsG1M0gzO4jXcay7FRLYWhX6 JVcrQko4rhog5vnQ4quHiajbY0apxZ22R3fF8i5sQuLPwafkJRs423Tpb/uoZ6AFUTfW EwZxhSflktviOO5UA6WAy5c3bdASR2wqIaWy/R5JSCrJrWrtsdHt0SoIh8xO/De1xVCK tBGg== X-Gm-Message-State: AJaThX7cBOu5rjaCWewf+XIL1Gr87kLLUQSLakAq3zXgS4nfBxzNXmEY Ll6F4hXFtG4Liq97zJ97NoO1ewAA54UJYETHuXg= X-Google-Smtp-Source: AGs4zMZTnDtemKra9StN1tFxI4pf4v3eNqnIwKIPWpcSALFpgyZqww4HRvYCQHuJIBFGnB8hPcQkzuMvaKCwqClf8fA= X-Received: by 10.55.201.155 with SMTP id m27mr17739664qkl.299.1511474155283; Thu, 23 Nov 2017 13:55:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Thu, 23 Nov 2017 13:55:54 -0800 (PST) From: Dave Taht Date: Thu, 23 Nov 2017 13:55:54 -0800 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Dave Taht , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Cake] signed-off-by requests X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 21:55:55 -0000 If anyone wants to add a signed-of-by, acked-by, or tested-by to the next patchset let me know. On Tue, Nov 21, 2017 at 11:46 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Dave Taht writes: > >> And now I can comment. >> >> I've added this version to a for_upstream branch in the hope that future >> commits can be kept in sync. >> >> Is there anything more that should be added to the commit message? >> Should I be less snarky? >> >>> while presenting an API simple enough that even an ISP can configure >>> it. > > I chuckled at this part at least. I'd say keep it ;) > >>> Example of use on an ISP uplink: >>> >>> tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter >>> >>> Cake can also be used in unlimited mode to drive packets at the speed >>> of the underlying link. >>> >>> Cake is filled with: >>> >>> * A hybrid Codel/Blue AQM algorithm, =E2=80=9CCobalt=E2=80=9D, tied to = an FQ_Codel >>> derived Flow Queuing system, which autoconfigures based on the bandwi= dth. >>> * A unique "triple-isolate" mode (the default) which balances per-flow >>> and per-host flow FQ even through NAT. >>> * An integral deficit based shaper with extensive dsl and docsis suppor= t >>> that can also be used in unlimited mode. > > "dsl and docsis link layer compensation support"? Not sure someone > who hasn't drunk the koolaid understands how a shaper can have "dsl and > docsis support" > >>> * 8 way set associative queuing to reduce flow collisions to a >>>minimum. > > 8-way set-associative hashing > >>> * A reasonable interpretation of various diffserv latency/loss >>>tradeoffs. > > Heh. Not sure the word 'reasonable' can reasonably be applied to > diffserv ;) > >>> * Support for washing diffserv for entering and exiting traffic. > > The term 'washing' is also internal; explain it? ("washing (zeroing) > diffserv markings") > >>> * Perfect support for interacting with Docsis 3.0 shapers. > > What does that mean? > >>> * Extensive support for DSL framing types. > > Aren't you just repeating yourself from above now? > >>> * (New) Support for ack filtering. >>> - 20 % better throughput at a 16x1 down/up ratio on the rrul test. > > From the PoV of an upstream submission it's all new, isn't it? Also, > this is the only place where you cite benchmark results. > >>> * Extensive statistics for measuring, loss, ecn markings, latency varia= tion. >>> >>> There are some features still considered experimental, notably the >>> ingress_autorate bandwidth estimator and cobalt itself. >>> >>> Various versions shipping have been available as an out of tree build f= or >>> kernel versions going back to 3.10, as the embedded router world has be= en >>> running a few years behind mainline Linux. A stable version has been >>> generally available on lede-17.01 and later. >>> >>> sch_cake replaces a combination of iptables, tc filter, htb and fq_code= l in >>> the sqm-scripts, with sane defaults and vastly easier configuration. > > s/easier/simpler/ > >>> Cake's principal author is Jonathan Morton, with contributions from >>> Kevin Darbyshire-Bryant, Toke H=C3=B8iland-J=C3=B8rgensen, Sebastian Mo= eller, >>> Ryan Mounce, Dean Scarff, Guido Sarducci, Nils Andreas Svee, Dave T=C3= =A4ht, and >>> Loganaden Velvindron. > > But no Signed-off-by? :) > > > -Toke --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619