From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 1E4D93B29E for ; Tue, 8 Jan 2019 15:44:59 -0500 (EST) Received: by mail-qk1-x736.google.com with SMTP id q1so3130718qkf.13 for ; Tue, 08 Jan 2019 12:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=evgMpGQAgcKUZ4Ogb+XhQDI2mKGTDux4HEOxWbq9wWE=; b=kkSYNX3LeMfFA5AwxB8GCmqWJbwo2HLloOuRkpoLlumzduqVV5UayxentEOP50SaJN MaXKtZoR5bkDAaKEPFjf5TUu0EaHrp7yI7nXTGx/zOxc1iotDJKbqdI7ihg7tjkpfdmL zBInFm4QJkm447v/c3Dz2mkw8QFk88XzL9LENW+CtAM13eZRBvuZG6JQMr31cGbNXvQb 3xfUlIg1yeWN6oLF8ixrYCw+MOMLkzPhAf73kW1oPDVmRIcwe8rCdDcCLYdzTNUsYGCt gNY3OWfFST/U+YEp6BSea2htPnweSmHHJMr1wqPbyv5trt03ZYUXVGmN2UpFgJlhBHAB pnxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=evgMpGQAgcKUZ4Ogb+XhQDI2mKGTDux4HEOxWbq9wWE=; b=PmtODJnlECQNcZoQB1UKebAWq+nvWuhIjPBmdRpN7XRQytfIJ5jZ5BXiDRmO+gLda/ uFOh54zd/CII/+4hGl7K0qjGeizzxMXgIa/Ori3PX+zOLouJrfFXr5kgGId6zS9RhHsl DKHA4uXmDTjPPQ4JHdqUFT2mpO0SHFB36EzrJFOCPvQ6i+oQgRs30MwcMQon3iu10rt0 mFH6EkQQcpcCpCfkW07b+bu/shJBVGfs49wvDrguDqJVTF6hnuvttMNyKLTY0/wJWkKq oyXJaC07Hgq8eSSLPRutW4Aitr9Gw3fgu+mG9M4JzcLnj0faK12A2e8ExolQS53N9dVN 2LhA== X-Gm-Message-State: AJcUukfwVXNOz1nN2B2SdwCElq225nIZdZm+PBo5Sd29HbPcwE8tp+qM fQQjZRWcZLgQqhZNtkEZG00BeYFdxzvF79HDAlBs9w== X-Google-Smtp-Source: ALg8bN582XH3IZ9ccwyayjfm8VoXkHE7s1t8ZDmzA8BywtCCdSCeevMkyJ1aYUkndmEpaF7KT2bzQ3dS0sE1KLYl7GI= X-Received: by 2002:a05:620a:1013:: with SMTP id z19mr2896475qkj.65.1546980298468; Tue, 08 Jan 2019 12:44:58 -0800 (PST) MIME-Version: 1.0 References: <87wonjxvss.fsf@toke.dk> <0077CC34-490F-4D76-82D3-BE37B27F2E1C@heistp.net> <49A6DCF8-BE98-47F4-9C66-6B4288390A58@heistp.net> <87tvinxos7.fsf@toke.dk> <87r2drxnal.fsf@toke.dk> <45D43135-318B-48AD-B09B-69BBB034CE12@heistp.net> <87o98vxm57.fsf@toke.dk> <797FCC60-0048-4EF6-80BC-19707E9173FB@heistp.net> <87lg3zxdyr.fsf@toke.dk> <87imz2yiet.fsf@toke.dk> <252DC221-7024-4834-9757-96335372A5A7@heistp.net> <87ftu6yc2y.fsf@toke.dk> <11DD478A-E61D-4D62-92B3-30B9A9A9572E@heistp.net> <874laly07v.fsf@toke.dk> <75345B18-E171-44C8-B059-9F6A6A663CAC@heistp.net> <87sgy4wvqq.fsf@toke.dk> <4FB89A19-314E-4B45-BEF3-83DB04A90C08@heistp.net> <39B9038B-42DF-41B6-9D78-6B71DCB06B2A@heistp.net> In-Reply-To: <39B9038B-42DF-41B6-9D78-6B71DCB06B2A@heistp.net> From: Dave Taht Date: Tue, 8 Jan 2019 12:44:44 -0800 Message-ID: To: Pete Heist Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2019 20:44:59 -0000 On Tue, Jan 8, 2019 at 12:03 PM Pete Heist wrote: > > Here=E2=80=99s the re-test with the patched version and HTB. Looks like s= uccess, nice work! I note that I'm big on having the flent.gz files around also. In this case, by eyeball, split-gso appears to have about 130us less latency, but a cdf comparison of split vs no-split woud show that more easily. > Split GSO on: > > https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_split1.s= vg > https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_split2.s= vg > https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_split3.s= vg > > Split GSO off: > > https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_no_split= 1.svg > https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_no_split= 2.svg > https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_no_split= 3.svg > > Your patch in the latest kernels looks simpler. Bringing the patch back t= o prior kernel versions would be appreciated, but I can understand how 3.16= becomes less and less relevant as time goes on, although, it=E2=80=99s not= at end of life yet. :) > > Interesting how download rate control in each of the graphs with GSO spli= tting on looks accurate to the point where flent=E2=80=99s throughput graph= scale is at 0.02 Mbit per step, and one can see that values coming back fr= om netperf are probably quantized to 0.01 Mbit... > > > On Jan 7, 2019, at 4:07 PM, Pete Heist wrote: > > > > Sorry, that=E2=80=99s without the patch, will give that a try when I ha= ve a chance and post the results, probably tomorrow... > > > >> On Jan 7, 2019, at 12:30 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> > >> Pete Heist writes: > >> > >>>> On Jan 6, 2019, at 9:56 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >>>> > >>>> Pete Heist writes: > >>>> > >>>>> Lastly, is using cake as a leaf to htb risky until a fix is made? I= =E2=80=99ve > >>>>> been doing that for a while without any apparent issues, though I= =E2=80=99m > >>>>> hesitating now to try that in a production environment. > >>>> > >>>> Hmm, that's a good question. I would expect so; but I would also exp= ect > >>>> the issue to show up pretty much straight away, so if you haven't hi= t it > >>>> yet, I may be wrong. I'll do some more digging... Should probably al= so > >>>> try to replicate all this stuff on my own machine :) > >>> > >>> > >>> Ok, after what I=E2=80=99m seeing on my APU1 tests on 3.16.7, I=E2=80= =99m definitely > >>> not putting split GSO into production. I just turned it on and off > >>> three times and here=E2=80=99s what I got: > >>> > >>> Split GSO on: > >>> > >>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_split_gso.svg > >>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_split_gso2.sv= g > >>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_split_gso3.sv= g > >>> > >>> Split GSO off: > >>> > >>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_no_split_gso.= svg > >>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_no_split_gso2= .svg > >>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_no_split_gso3= .svg > >>> > >>> I=E2=80=99ve seen these square waves before with htb and wondered whe= re they > >>> came from, and I think we may finally have an answer! What manner of > >>> thing causes this I don=E2=80=99t know, but there=E2=80=99s a chance = you may end up > >>> finding out=E2=80=A6 :) > >> > >> Is this without the patch to CAKE that adjusts the qlen? And have you > >> tried running with that patch (with HTB)? > >> > >> -Toke > > > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-205-9740