Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Sebastian Moeller <moeller0@gmx.de>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc
Date: Thu, 23 Nov 2017 14:26:25 -0800	[thread overview]
Message-ID: <CAA93jw4X+QofL0Ebh2ieC07txvyD04oH-dECuTuG3dZn83o6aQ@mail.gmail.com> (raw)
In-Reply-To: <3707E8F3-F795-49C1-89AE-2EB259483928@gmx.de>

On Thu, Nov 23, 2017 at 2:20 PM, Sebastian Moeller <moeller0@gmx.de> wrote:
> And it turns out the current head has this fixed already...
>
> I guess this must be Kevin's fix, I could have sworn that I had that in my repository when I started testing, but I guess I tried juggling a few repositories too many on too many computers.
>
> So it seems this was fixed all along, well it made me try git bisect so all was good...

Groovy!

> Just for documentation:
>
> 1) Building (from inside the sch_cake repository:
>
> sudo tc qdisc delete root dev eth0 ; sudo rmmod sch_cake ; tc -s qdisc show dev eth0 ; make ; sudo make install
>
> 2) Testing:
> sudo ../iproute2-cake-next/tc/tc qdisc delete root  dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root dev eth0 cake raw overhead 0 ; ../iproute2-cake-next/tc/tc -s qdisc show dev eth0
>
>
> Results
> user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc delete root  dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root dev eth0 cake raw overhead 0 ; ../iproute2-cake-next/tc/tc -s qdisc show dev eth0
> [...]
> GOOD: qdisc cake 8035: root refcnt 6 unlimited diffserv3 triple-isolate rtt 100.0ms raw total_overhead 14 hard_header_len 14
> BAD: qdisc cake 8035: root refcnt 6 unlimited diffserv3 triple-isolate rtt 100.0ms raw total_overhead 14 hard_header_len 14     # note with the added "raw" keyword this always worked
> [...]
>
> user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc delete root  dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root dev eth0 cake overhead 0 ; ../iproute2-cake-next/tc/tc -s qdisc show dev eth0
> [...]
> GOOD: qdisc cake 8036: root refcnt 6 unlimited diffserv3 triple-isolate rtt 100.0ms noatm overhead 0 via-ethernet total_overhead 0 hard_header_len 14
> BAD: qdisc cake 8036: root refcnt 6 unlimited diffserv3 triple-isolate rtt 100.0ms noatm overhead 14 via-ethernet total_overhead 14 hard_header_len 14
> [...]
>
> user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc delete root  dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root dev eth0 cake ethernet ; ../iproute2-cake-next/tc/tc -s qdisc show dev eth0
> [...]
> GOOD: qdisc cake 8037: root refcnt 6 unlimited diffserv3 triple-isolate rtt 100.0ms noatm overhead 38 via-ethernet total_overhead 38 hard_header_len 14 mpu 84
> BAD: qdisc cake 8037: root refcnt 6 unlimited diffserv3 triple-isolate rtt 100.0ms noatm overhead 14 via-ethernet total_overhead 14 hard_header_len 14 mpu 84
> [...]
>
> The BAD results are from memory so might be off in the "overhead N" and "via-ethernet" results but the total_overhead and hard_header_len looked quite similar to the reported ones...
>
> Best Regards
>         Sebastian
>
>
>
>> On Nov 23, 2017, at 23:02, Sebastian Moeller <moeller0@gmx.de> wrote:
>>
>> And git bisect gave:
>>
>> user@work-horse:~/CODE/sch_cake$ git bisect bad
>> 031998e4eee58cbc706711eba8c54684f07306be is the first bad commit
>> commit 031998e4eee58cbc706711eba8c54684f07306be
>> Author: Dave Taht <dave.taht@gmail.com>
>> Date:   Sun Nov 19 19:02:06 2017 -0800
>>
>>    sch_cake: make more checkpatch compliant
>>
>> :100644 100644 97a4727e6ed9b9451567568b027e65dd9937112c e6a4b09ae8bebab5ae07b94b469184669ab6e27f M      sch_cake.c
>> user@work-horse:~/CODE/sch_cake$
>>
>> as the likely culprit, now let's see whether I can figure out why. (The git bisect thing, even though I had to skip a few commits makes bug hunting almost fun).
>>
>>
>> Best Regards
>>
>>> On Nov 23, 2017, at 22:43, Sebastian Moeller <moeller0@gmx.de> wrote:
>>>
>>> 9789742cfc596d48583ba4cdbc8f38d026121fa6
>>
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
>



-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619

      reply	other threads:[~2017-11-23 22:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22  0:09 Dave Taht
2017-11-22  0:09 ` [Cake] [PATCH 1/3] pkt_sched.h: add support for sch_cake API Dave Taht
2017-11-22  0:55   ` Stephen Hemminger
2017-11-22  0:58     ` Dave Taht
2017-11-22 21:38       ` Stephen Hemminger
2017-11-22 22:35         ` Dave Taht
2017-11-24 13:33       ` Marcelo Ricardo Leitner
2017-11-24 20:53         ` Dave Taht
     [not found]     ` <CAJq5cE2j9o1vHhxEecHkKMUv65d-BxDvXNJXPWh=WHmXVqNUQA@mail.gmail.com>
     [not found]       ` <CAJq5cE36nijxKM6dpRPK2d8axZwf=35a8D=2oArPjusRKALLpA@mail.gmail.com>
2017-11-22  6:59         ` Jonathan Morton
2017-11-22  0:09 ` [Cake] [PATCH 2/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Dave Taht
2017-11-22  0:55   ` Dave Taht
2017-11-22  2:33     ` Ryan Mounce
2017-11-22  7:46     ` Toke Høiland-Jørgensen
2017-11-22  0:09 ` [Cake] [PATCH 3/3] Add support for building the new cake qdisc Dave Taht
2017-11-22 11:02 ` [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc Sebastian Moeller
2017-11-22 18:03   ` Dave Taht
2017-11-23  7:54     ` Sebastian Moeller
2017-11-23 21:43     ` Sebastian Moeller
2017-11-23 22:02       ` Sebastian Moeller
2017-11-23 22:20         ` Sebastian Moeller
2017-11-23 22:26           ` Dave Taht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw4X+QofL0Ebh2ieC07txvyD04oH-dECuTuG3dZn83o6aQ@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=moeller0@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox