From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 01D423BA8E for ; Thu, 23 Nov 2017 17:26:26 -0500 (EST) Received: by mail-qk0-x233.google.com with SMTP id d125so22537751qkc.12 for ; Thu, 23 Nov 2017 14:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dvyLiikt3LbGTqvAQa7M4Os9QCqMmxZLVKBW5rILbWU=; b=dQN+EPCjV0AWREF8GunfQQUGgU09SHcHoO+VVNAfWdJZ104Uis0WndvpN/nIF9Vce6 XMGQKwFAVer6BVGjSyTj2hY8LTHGUOGL8k/HvfPHi4BA8h11q8EVTGsAVY5eL/bK4RkS WWclT/kNFrJSNptjVx5jQwCzGLcYBvv44bigqZdO/hJaXdLM0++tfOIgGXXSvYtCpgYE 9bDoOh6gx++XhBTcO2WnxkGrTYeW/766Y4j951pSCNz0zX/Isx2mbGOeloxjCZczjb3n 4o5nEn2S7tiMwVHe/tAs4LutET4+u35coblxlPYaN41KmsfGHgBhCTCgr5azEEHE2GZd kXpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dvyLiikt3LbGTqvAQa7M4Os9QCqMmxZLVKBW5rILbWU=; b=U43Ir55cRvy4dyJV4adSTugqqPvodESRj70ybPK4rq3b2IeCtcjxSVTGvK52DX0MTR fGbJ5guS4jCvJ004MIOy1I8WzTk0ccn2HCyfODxhR6bSplLHW/R+qr1fgsrfWabbFj7l 3PNDynZ0Qzjg1RRWaOh3NXNTtauuznyecgQVnlSZEArMFRB3cYNFFTvS/MXqodJnX2uL FRlq2guZOOHRK0DILmKcm81h6TpIqs1mwn1XsrljsDmxXVwrLj8oEOiRsSQECK4riopW OVdgBZrWaHXVDUUmTOjimHWAXSkmKJRl0C/yQ0OqD/oYjTKQO8oupaa3uTRRoOzmHVxD w5ng== X-Gm-Message-State: AJaThX7qgi+SgE4ijyCIj7eK2UZlG4vzE2Am9kth5FbNf/2ctJHjhdAF SKiUE2EqNzZ/yBH3hpJi60ep/nQJxiC8NVsKfzQ= X-Google-Smtp-Source: AGs4zMa/+/DtooMmi88uxmSmBfgRdRq0GqU74ZYx6/s3EHKFJfa5rECgg+jUGUs1LeoIacmgNEPADngc2TK/aToaF0Q= X-Received: by 10.55.188.6 with SMTP id m6mr2822216qkf.75.1511475986427; Thu, 23 Nov 2017 14:26:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Thu, 23 Nov 2017 14:26:25 -0800 (PST) In-Reply-To: <3707E8F3-F795-49C1-89AE-2EB259483928@gmx.de> References: <1511309382-24060-1-git-send-email-dave.taht@gmail.com> <0AE259AC-DB97-42CE-9E0D-33FBF11159AD@gmx.de> <6E3AF126-B32C-4625-A443-FD048493B161@gmx.de> <3707E8F3-F795-49C1-89AE-2EB259483928@gmx.de> From: Dave Taht Date: Thu, 23 Nov 2017 14:26:25 -0800 Message-ID: To: Sebastian Moeller Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH 0/3] Add Common Applications Kept Enhanced (sch_cake) qdisc X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2017 22:26:27 -0000 On Thu, Nov 23, 2017 at 2:20 PM, Sebastian Moeller wrote: > And it turns out the current head has this fixed already... > > I guess this must be Kevin's fix, I could have sworn that I had that in m= y repository when I started testing, but I guess I tried juggling a few rep= ositories too many on too many computers. > > So it seems this was fixed all along, well it made me try git bisect so a= ll was good... Groovy! > Just for documentation: > > 1) Building (from inside the sch_cake repository: > > sudo tc qdisc delete root dev eth0 ; sudo rmmod sch_cake ; tc -s qdisc sh= ow dev eth0 ; make ; sudo make install > > 2) Testing: > sudo ../iproute2-cake-next/tc/tc qdisc delete root dev eth0 ; sudo ../ip= route2-cake-next/tc/tc qdisc add root dev eth0 cake raw overhead 0 ; ../ipr= oute2-cake-next/tc/tc -s qdisc show dev eth0 > > > Results > user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc d= elete root dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root dev = eth0 cake raw overhead 0 ; ../iproute2-cake-next/tc/tc -s qdisc show dev et= h0 > [...] > GOOD: qdisc cake 8035: root refcnt 6 unlimited diffserv3 triple-isolate r= tt 100.0ms raw total_overhead 14 hard_header_len 14 > BAD: qdisc cake 8035: root refcnt 6 unlimited diffserv3 triple-isolate rt= t 100.0ms raw total_overhead 14 hard_header_len 14 # note with the adde= d "raw" keyword this always worked > [...] > > user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc d= elete root dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root dev = eth0 cake overhead 0 ; ../iproute2-cake-next/tc/tc -s qdisc show dev eth0 > [...] > GOOD: qdisc cake 8036: root refcnt 6 unlimited diffserv3 triple-isolate r= tt 100.0ms noatm overhead 0 via-ethernet total_overhead 0 hard_header_len 1= 4 > BAD: qdisc cake 8036: root refcnt 6 unlimited diffserv3 triple-isolate rt= t 100.0ms noatm overhead 14 via-ethernet total_overhead 14 hard_header_len = 14 > [...] > > user@work-horse:~/CODE/sch_cake$ sudo ../iproute2-cake-next/tc/tc qdisc d= elete root dev eth0 ; sudo ../iproute2-cake-next/tc/tc qdisc add root dev = eth0 cake ethernet ; ../iproute2-cake-next/tc/tc -s qdisc show dev eth0 > [...] > GOOD: qdisc cake 8037: root refcnt 6 unlimited diffserv3 triple-isolate r= tt 100.0ms noatm overhead 38 via-ethernet total_overhead 38 hard_header_len= 14 mpu 84 > BAD: qdisc cake 8037: root refcnt 6 unlimited diffserv3 triple-isolate rt= t 100.0ms noatm overhead 14 via-ethernet total_overhead 14 hard_header_len = 14 mpu 84 > [...] > > The BAD results are from memory so might be off in the "overhead N" and "= via-ethernet" results but the total_overhead and hard_header_len looked qui= te similar to the reported ones... > > Best Regards > Sebastian > > > >> On Nov 23, 2017, at 23:02, Sebastian Moeller wrote: >> >> And git bisect gave: >> >> user@work-horse:~/CODE/sch_cake$ git bisect bad >> 031998e4eee58cbc706711eba8c54684f07306be is the first bad commit >> commit 031998e4eee58cbc706711eba8c54684f07306be >> Author: Dave Taht >> Date: Sun Nov 19 19:02:06 2017 -0800 >> >> sch_cake: make more checkpatch compliant >> >> :100644 100644 97a4727e6ed9b9451567568b027e65dd9937112c e6a4b09ae8bebab5= ae07b94b469184669ab6e27f M sch_cake.c >> user@work-horse:~/CODE/sch_cake$ >> >> as the likely culprit, now let's see whether I can figure out why. (The = git bisect thing, even though I had to skip a few commits makes bug hunting= almost fun). >> >> >> Best Regards >> >>> On Nov 23, 2017, at 22:43, Sebastian Moeller wrote: >>> >>> 9789742cfc596d48583ba4cdbc8f38d026121fa6 >> >> _______________________________________________ >> Cake mailing list >> Cake@lists.bufferbloat.net >> https://lists.bufferbloat.net/listinfo/cake > --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619