From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x22a.google.com (mail-qk0-x22a.google.com [IPv6:2607:f8b0:400d:c09::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7C3033B2A4 for ; Sat, 7 Jul 2018 03:07:29 -0400 (EDT) Received: by mail-qk0-x22a.google.com with SMTP id b129-v6so7428570qke.7 for ; Sat, 07 Jul 2018 00:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YfBWZnvhE+IDdbCPIinIUhKtqfQb/rSvc6CnQDP03Rs=; b=EkZj9stcPGw9PZYkDv1ZHIHYXOKu0cvg3+sVPF1HukPa0UZ7b6InUn+I8n7MvRgnGi Zrm0ls/n6Q33um4/yMssuMIfQrNMfD68T0irwDqFS39sLsr5gbKmPqajHSc4jCNIQULg vH+O5IC21bT/QcpGPuFVJ4+hDau9FQdUUajA7QXjT378pX2qWYfVgEInV+IH/c+B5gS3 Qr5JXInil8muwIQkDb6vAd2K79lfocmxbBGwypyZe/hOeZXVgIT9qorv+POB2e2E743q ViOA5gOMttXfVf3WlcbVhMT7oXGGUzD26XLNzAjor6pDrEmKBG/k9i7nM+RTUyKn6onF 8cxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YfBWZnvhE+IDdbCPIinIUhKtqfQb/rSvc6CnQDP03Rs=; b=tLFCWScYk19yW+6IRg6ie3oV28xW00zdCNTuafI/lBoQfEzhPOBfS8ZTgWR8mLYT+e ldxjToZq8Yrc0WJV2mm8tg2MNFV19ikb7RH+PEWjjVOVJMvrm+cw6U069QeN53QgHOo0 N5HWmlifRdlCXOx8jIvpIFFMsK7yiyxX3vjjQTLkBiBmp7P6+fzkVOOKG2QwTz38+5CT GBVzJSNLpPaHDM00h0Voe1jUlvkKVV0TLB0QNFTHNIdFYbJ6umol9aXIiTH/yKxT/lAO VLOXJbwP6N43DMu8jlspzHBNYuDRCDL6ZF2AtEwoDsoMFZ+2UeAWDLJdaEFdxZlogifE 6TEw== X-Gm-Message-State: APt69E2nmM9v6IOeuHLmUf5QP5yrrsLWuRSCXisJxoAcJXsMxxFY8IXv R2IFYXJ12IH17/Yvcd4WvcCCAdvDW3zOHlklUEg= X-Google-Smtp-Source: AAOMgpcyQfidRS1Bt6FY04c2XsIa4HOWtlqguMO5viQ3fg2EisDXgU4hmz7aJSVPJ9EXcMiYalDSZl/rR/+q2GNxBg8= X-Received: by 2002:a37:210a:: with SMTP id h10-v6mr11191065qkh.263.1530947249052; Sat, 07 Jul 2018 00:07:29 -0700 (PDT) MIME-Version: 1.0 References: <20180706115745.2791-1-toke@toke.dk> <87a7r4bmlk.fsf@toke.dk> <874lhcbiux.fsf@toke.dk> <871scgbijw.fsf@toke.dk> In-Reply-To: <871scgbijw.fsf@toke.dk> From: Dave Taht Date: Fri, 6 Jul 2018 21:07:17 -1000 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Jonathan Morton , Cake List Content-Type: multipart/alternative; boundary="000000000000f31f160570636e05" Subject: Re: [Cake] [PATCH] Keep an internal counter for total queue length X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2018 07:07:29 -0000 --000000000000f31f160570636e05 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I am curious as to the cpu and thruput difference between pfifo, htb + fqcodel v cake at these insane speeds. On Fri, Jul 6, 2018, 3:27 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > Jonathan Morton writes: > > >> On 6 Jul, 2018, at 4:21 pm, Toke H=C3=B8iland-J=C3=B8rgensen > wrote: > >> > >>> I'm handling it without using any extra permanent state, just making > >>> use of what's already there. Take a look at latest commit. > >> > >> Yup, that also fixes the infinite loop issue. I'm fine with doing it > >> this way; however, it doesn't handle the other places where we check > >> whether sch->q.qlen is nonzero. Are you sure that is not going to give > >> us more problems down the road? :) > > > > The other places are checking whether the queue is empty for the > > purposes of updating the shaper state. They are therefore much less > > critical, and I think self-correcting. > > Right, cool. In that case I think we are good to go for another upstream > submission; I'll get that done later today :) > > -Toke > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake > --000000000000f31f160570636e05 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I am curious as to the cpu and thruput difference between= pfifo,=C2=A0 htb + fqcodel v cake at these insane speeds.


On Fri, Ju= l 6, 2018, 3:27 AM Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> wrote:
Jonathan Morton <chromatix99@gmail.com> writes:

>> On 6 Jul, 2018, at 4:21 pm, Toke H=C3=B8iland-J=C3=B8rgensen <<= a href=3D"mailto:toke@toke.dk" target=3D"_blank" rel=3D"noreferrer">toke@to= ke.dk> wrote:
>>
>>> I'm handling it without using any extra permanent state, j= ust making
>>> use of what's already there. Take a look at latest commit.=
>>
>> Yup, that also fixes the infinite loop issue. I'm fine with do= ing it
>> this way; however, it doesn't handle the other places where we= check
>> whether sch->q.qlen is nonzero. Are you sure that is not going = to give
>> us more problems down the road? :)
>
> The other places are checking whether the queue is empty for the
> purposes of updating the shaper state. They are therefore much less > critical, and I think self-correcting.

Right, cool. In that case I think we are good to go for another upstream submission; I'll get that done later today :)

-Toke
_______________________________________________
Cake mailing list
Cake@lists.bufferbloat.net
https://lists.bufferbloat.net/listinfo/cake
--000000000000f31f160570636e05--