From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id EE9A83CB38 for ; Mon, 9 Dec 2024 19:25:14 -0500 (EST) Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-5f2bdbca73cso351234eaf.2 for ; Mon, 09 Dec 2024 16:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733790314; x=1734395114; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XxV+mAVeS0Tuzvt9QheWEZ7UQEwvL15JnzRI7m+7QSk=; b=KgrPcvFraHQkpeQAm7D3Bn+bMBAylX9xaA04Aqn+2iOdM9gkC6w0bMYwoa7o/lILL3 BDLSrLTYk6pgX9pR8uJ1MGX8hXnUGc1g40zj0cDG7tv+dx3DdIPTok6RzJd1v9H/TZnQ l3uVpzR5XNElbh2AEs9dPX447Kh6BoPT53sekGLTpIejPOgjpa14PKLJNK2J4Mpd+eIY 02sUrq57si2KeRMjK2CT6s72Z7vaN32CJiVQshyBBwJocNjp2+dJbKIpdwJ6dDHlT2wJ 5rmc57tpERIiXQ0GBV9pxtBShMofWjR7nWXY0eQQ+nYmSPPykMuuyjWU8h0e3tmqEq9C QdeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733790314; x=1734395114; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XxV+mAVeS0Tuzvt9QheWEZ7UQEwvL15JnzRI7m+7QSk=; b=c1RV4eNEOQ29K3XVebmXsSTS/uu0WCMiv8PSvVZCUHBM2N35zKgv5pDqWcm2PZQaUe JKgJBn9s7LuICgHVfBhZl98Z/XN0zDdzGSQRSkWCYJaCAzOKTMlyrXL6dBc6S3UwW8Bj WsRsN70w0LqtUflVSZGwvWa3zNDlTnTd9E0eFJOebITbotx8eeuWCYCcCVpqRoQF9tfu 8WIeuYAl9lpreicoZ2EH0ShzZootSwhgqIXjkL/G1gXcE87ERatMtV7oRUSYfxAErc37 7U7oGo+PhQ0S5SFWpFZbMeqHmFpxJIx3geARzpR0uXSBDugYJBTm6m7BPPQ6bzM0RKE2 s3xg== X-Forwarded-Encrypted: i=1; AJvYcCUUmpI/JScQaIvWQQyALHAmMbrewF5oJqTexQ2mSoW4QWC1DOqFFq0nQ1in22NZpqqIt/6s@lists.bufferbloat.net X-Gm-Message-State: AOJu0YxpF8JbSFO5O2eGojARyE1QHdC9ef3POt6YwYq5OzRR2V06IAB9 20RWgHFVjijwuh2xk08kIdGgwb5mgH2zUICiigVKhZMRcMLGvd/b87w3WsrhvA8sX39jnyF9iC9 UWy+nVvqQF2AX6J41C8P8GoefN/o= X-Gm-Gg: ASbGncuKaQ3kndDrdT4NS3cNoTqeCugGIsfBgCFtbmC9KL1MrAaQR0DhoXIMG3ieOIU tktK6w40RB4ljaqscjGQFmhdPhet0x64W4xC2Xq/YItrh0kywb+URHfybzboYjMdeoF/FZA== X-Google-Smtp-Source: AGHT+IGptdCS2IgMtGirKWOIZXgbBA4mbJoBb81jtfTqrZAta/uP7HvPJDZWv8PjEFZFeHpM7y7wetAZkpFzAyI1KcA= X-Received: by 2002:a05:6870:c10d:b0:29e:5df2:3e50 with SMTP id 586e51a60fabf-29fee568a8fmr1565854fac.15.1733790314255; Mon, 09 Dec 2024 16:25:14 -0800 (PST) MIME-Version: 1.0 References: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com> <20241209155157.6a817bc5@kernel.org> In-Reply-To: <20241209155157.6a817bc5@kernel.org> From: Dave Taht Date: Mon, 9 Dec 2024 16:25:01 -0800 Message-ID: To: Jakub Kicinski Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Jiri Pirko , netdev@vger.kernel.org, Jamal Hadi Salim , cake@lists.bufferbloat.net, Eric Dumazet , Simon Horman , Cong Wang , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net-next] net_sched: sch_cake: Add drop reasons X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2024 00:25:15 -0000 On Mon, Dec 9, 2024 at 3:52=E2=80=AFPM Jakub Kicinski via Cake wrote: > > On Mon, 09 Dec 2024 13:02:18 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote= : > > Add three qdisc-specific drop reasons for sch_cake: > > > > 1) SKB_DROP_REASON_CAKE_CONGESTED > > Whenever a packet is dropped by the CAKE AQM algorithm because > > congestion is detected. > > > > 2) SKB_DROP_REASON_CAKE_FLOOD > > Whenever a packet is dropped by the flood protection part of the > > CAKE AQM algorithm (BLUE). > > > > 3) SKB_DROP_REASON_CAKE_OVERLIMIT > > Whenever the total queue limit for a CAKE instance is exceeded and = a > > packet is dropped to make room. > > Eric's patch was adding fairly FQ-specific reasons, other than flood > this seems like generic AQM stuff, no? From a very quick look the > congestion looks like fairly standard AQM, overlimit is also typical > for qdics? While I initially agreed with making this generic, preserving the qdisc fro= m where the drop came lets you safely inspect the cb block (timestamp, etc), format of which varies by qdisc. You also get insight as to which qdisc was dropping. Downside is we'll end up with SKB_DROP_REASON_XXX_OVERLIMIT for each of the qdiscs. Etc. > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CSO, LibreQos