From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x243.google.com (mail-qk0-x243.google.com [IPv6:2607:f8b0:400d:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id BA0C73B260 for ; Wed, 5 Oct 2016 11:53:40 -0400 (EDT) Received: by mail-qk0-x243.google.com with SMTP id j129so13556080qkd.2 for ; Wed, 05 Oct 2016 08:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=irvHgkkQZX12WSKmm18HqqqAp2tt7HirAXy2HwD6jzs=; b=kycwv+30MN+WcMyy6J+5U1TP+7PK9Feh8pY1TjbQPyQYLpBiRheCLf29N3PZc9sSHg Ww0PiWFCgAn9waWar0o9aAS2jpTpYdIG2MFBRZtQOijJdpwWycYvngtjhmedcVhtb1ED urNpEcV7+dnNo8kpQLqKpS0Kg5TS3JtCjzVErsNY7krprlI9BBKiqrcHRb7Jd9Wcfka0 PfThAsOHPFN8DrH5tXfxWAsszPoaR391PjuseftXAzOtP6/zQukShxkqfbC/UQ0yVI5y /FMEPNuKxo5yVW/MQMv95kSXmLuEwxnF/N+NAx5cZrKuO4BxNQJ6kVpNqqzbNgywzzEf jJ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=irvHgkkQZX12WSKmm18HqqqAp2tt7HirAXy2HwD6jzs=; b=hcIqR36zWdbVwn2ENNpcZZDZcOXiB2PukN5wUOoRjkh1I2pEtkeuvV01U6XyauuMeE RCHqpoOuvU+/+oa3LePn9BV3qt6EkYraqKDyzGA7GFCAjdtusriCpH9cAJTbYh8WtcgM KE8tEA34XH5jv1J6GlBmhtAXXsosYUIbzRDAj0eyf82rvtEd9vTcU2lbINHWYFG2wSef zcZfQt0vwHJbKZYldxmnpkadVaaPOVazEEjZIA15hUdQ5VVYXE7bUtzfE/3UWBC2mRBd s0aXVys37M728+CD5FV+Q7lD2xPVFXbevAhCRHCk7GTgXZlrE5/G41xSVfuG7fCG5AWh 84sQ== X-Gm-Message-State: AA6/9RlWXsPdPAfPZA7g/uk6fj9r9oeI/+XHh1HaNdHyjXE3hnIpNOHBeO4G6lI5YXCJQ5aoVyKaKj82LzcsgA== X-Received: by 10.55.121.67 with SMTP id u64mr10692644qkc.114.1475682820352; Wed, 05 Oct 2016 08:53:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.146.164 with HTTP; Wed, 5 Oct 2016 08:53:39 -0700 (PDT) In-Reply-To: <451e7412-2f27-1421-1bd6-ac2ef45f4cd8@darbyshire-bryant.me.uk> References: <70363372-13a0-a88f-840e-b8e10c685ed7@darbyshire-bryant.me.uk> <451e7412-2f27-1421-1bd6-ac2ef45f4cd8@darbyshire-bryant.me.uk> From: Dave Taht Date: Wed, 5 Oct 2016 08:53:39 -0700 Message-ID: To: Kevin Darbyshire-Bryant Cc: Jonathan Morton , cake@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] BUG_ON vs WARN_ON X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 15:53:40 -0000 I did test this version of cake yesterday, had no major problems, aside fro= m: 1) it seeming not to register drops under some circumstances in the statistics. (could be flent) 2) switching stuff like this tc qdisc add dev eth0 root cake bandwidth 700mbit tc qdisc replace dev eth0 root cake bandwidth 1100mbit # out of cpu, basically, at 700 mbit tc qdisc replace dev eth0 root cake unlimited # still stuck at 700mbit kept the thing at 700mbits (out of cpu at that point). tc qdisc del dev eth0 root cake tc qdisc add dev eth0 root cake unlimited # native rate of 1gbit achieved On Wed, Oct 5, 2016 at 8:45 AM, Kevin Darbyshire-Bryant wrote: > > > On 05/10/16 16:42, Jonathan Morton wrote: >> >> >>> On 5 Oct, 2016, at 18:24, Kevin Darbyshire-Bryant >>> wrote: >>> >>> How amenable are you to changing all 4 BUG_ON instances in cake to >>> WARN_ON? >>> >>> Linus isn't a complete fan and I'm thinking that producing a stack >>> trace and trying to carry on is more helpful to a remote accessed, >>> no serial interface type device than just killing the kernel dead. >>> >>> Quite possibly other bad things(tm) will happen shortly after...or >>> maybe there will be enough time look at dmesg for that stack >>> trace. >> >> >> The two in cake_heap_swap() can probably go away completely - they >> were there to make sure the heap algorithms were working correctly. >> They never did trigger, as it happens. >> >> The other two are genuine serious bugs (array overflow) if they ever >> trigger. It=E2=80=99s safer to leave them as-is. > > > Fair enough :-) I wonder what it was that caused yesterday's issues? I > really must try again when I've more time to get proper access. > > Kevin > > >> >> - Jonathan Morton >> > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org