From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id EE79B3B2A4 for ; Fri, 23 Feb 2024 12:03:43 -0500 (EST) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2d2305589a2so14365491fa.1 for ; Fri, 23 Feb 2024 09:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708707821; x=1709312621; darn=lists.bufferbloat.net; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jFzg91Uz0eTdvaw3hPv0DO9S+j3Cm8QDhH0oSW4VA3Y=; b=nDz/XkW57MylqpkjJ03RsRfRIBRyyL4vvjHJcKNpFNaeuEwsCVvzPeyTwGfogfqAiR TNgbFkb9zFQeas/8m0+E3elXQF+c0ihFvLCx7lMJRcujJW+BQy9VdwmQfqsws+Z59Q1f 09WJLjx+E+0O/LkcwKSzo8HI/40dUM4dDg6uDN+ayEsGsZ5hmkOAVz7SFHez2m9zrhfT P9MgSWJLTjqqAHWbmqDnRFQ64iXAOPmAFuk+OL5qyQUJwfSB80u15dgtEaWeNgdMkUcX VAfRLZ0/fEnRcY2ShxOWey7UTUCK9VE9DlmpUDJ0VZnOZy+O0PTeLiNIVvYygzJWQQYq weIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708707821; x=1709312621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jFzg91Uz0eTdvaw3hPv0DO9S+j3Cm8QDhH0oSW4VA3Y=; b=HHJKnSYTwCy5A+byBPuUk+TovwSUcA0nvaxXWxxABoM7XTyqbAeyHLHuiHaNPnMnon TFq1yGTmpzg58SnNOOUTbpnIJ/GnYN8syKYlbr19TJkrpZ6HXrH+Owvp40y+n71GUSFi HdQ4JCGczaHxgYbBrCE//bwLKBfC4jQljh95eH4UozGqdRw5JUgnL88fXvgZWY7PTZNb vnKc4QkNCgr+/IuTxkn9h92KKPJMma5FGS6rV3G7zu1T2GNsFezgrbwOp39VPc4VY3TN 15iL8kgmoIIG4WVSjWSO9V8VLgyXZWeM8lEOvc2w8Zl1P8PN9wT7FbUKGOXptNmAY7m0 fQsA== X-Gm-Message-State: AOJu0YwrWCyGJTCpluW2gDa0Tn1Q3QeDDtQyxV6n5S4IJM2vO1ophWtF jaJZRUKPycFINsorMjACVGwrdQgwL/YWoeRF8dRuWDLgQjQpBaV7WytkqjJJO2FJJEGDiwKiuj1 ajj/h3OUP4bLv6YKif1YUpeNsrYSod45Fm7o= X-Google-Smtp-Source: AGHT+IHxsrgUzcQ2/xXCtcaSGPfnNQ17xeZD3hk+MtdYpFVFWSQyG59vJUhm9aRfJh14Tap8meeoxk33qUMsiSWwRDw= X-Received: by 2002:a2e:9b4b:0:b0:2d2:2cff:fc49 with SMTP id o11-20020a2e9b4b000000b002d22cfffc49mr296993ljj.18.1708707821425; Fri, 23 Feb 2024 09:03:41 -0800 (PST) MIME-Version: 1.0 References: <875xyldhbk.fsf@toke.dk> <87sf1juobz.fsf@toke.dk> In-Reply-To: <87sf1juobz.fsf@toke.dk> From: Dave Taht Date: Fri, 23 Feb 2024 12:03:30 -0500 Message-ID: To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] cake's ack-filter vs GSO X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2024 17:03:44 -0000 My memory about all this stuff is extremely scrambled by the mvneta driver which ws the first thing that drove me to consider GSO splitting in the first place. That evolved significantly. I also remember XMIT_more costing us more bandwidth than it gained, on the wndr3800, due to eating more cpu or icache. Then there was the change in how inbound skbs were processed overall, and innumerable attempts to remove locks from pfifo_fast, and ... ghu knows what else has changed. How does packet pacing affect things? How much BBRv3 buffers? I am no longer certain of anything. I am pretty sure, however, that vikings were not black. https://gizmodo.com/google-anti-woke-babies-gemini-black-vikings-1851275422 I asked the latest AIs for summaries as to what fq_codel does, what products it is in, and it was slightly wrong in all cases. What products have fq_codel in them?" was pretty good. It just missed apple. Asking gemini again: "Is the pie aqm better than fq_codel? How do both compare to CAKE" was also= fun. It generated a really nice table. And made my skin itch at the inaccuracies= . Is the pie aqm better than fq_codel? How do both compare to CAKE? On Fri, Feb 23, 2024 at 11:39=E2=80=AFAM Toke H=C3=B8iland-J=C3=B8rgensen <= toke@toke.dk> wrote: > > Dave Taht writes: > > > On Sun, Feb 18, 2024 at 8:37=E2=80=AFAM Toke H=C3=B8iland-J=C3=B8rgense= n wrote: > >> > >> Dave Taht via Cake writes: > >> > >> > It has been years since I looked at cake's code. > >> > > >> > Does anyone remember why we do not ack-filter a gso-split? > >> > >> Because a GSO packet cannot be a pure ACK, so it wouldn't be filtered > >> anyway... > > > > But a GRO packet can, and most likely IS a pure ack packet train that > > could and should be thinned. I think. Yes? > > Erm, no, because those would have header differences and so wouldn't be > combined into a single GRO packet... > > -Toke --=20 https://blog.cerowrt.org/post/2024_predictions/ Dave T=C3=A4ht CSO, LibreQos