From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x242.google.com (mail-qt0-x242.google.com [IPv6:2607:f8b0:400d:c0d::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7E29D3B2A4 for ; Sun, 3 Dec 2017 22:32:48 -0500 (EST) Received: by mail-qt0-x242.google.com with SMTP id g10so19560265qtj.12 for ; Sun, 03 Dec 2017 19:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=fh9NVf5ew5FPFkttAR7QMjy03RtoTJ+SM07l+6b9KBY=; b=oq6GUGQoF5ZD2lAN4nG2hBdSZQ1WKULTreAb7hekVltkLbfvdu41OD/RiPN82dhE7f D4PLSvUR/ykZGtt5oc5dnIWbKyy3+X12WcOxJY0IZdCDEvJq1h7vYyduZtrlDtPyxBeZ hyU1Wj3f5EVWA41uvwNa7elLuWBtDDwYsZJdnXQK7ppUL+oOQG7E9bJXD+rDNISBi5I4 IuG9llqtEVSWl7S+3aKXAP+QWinjRSZe0wIDAODZRzRRLsslSNED2rFKSb/A4QO4tNuN sA7jkwS5Ji68TIEVLFJEOFfknGE6Yoalbwnlj1x4rtuShdVbg9dlkefDK/JUeL0Ae1Jk jG5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=fh9NVf5ew5FPFkttAR7QMjy03RtoTJ+SM07l+6b9KBY=; b=ujOfH5cg4dZDaz3d/9pyemo/aYp6PtaCDzZh/M3WtqvTCifC/C0wBD8cDyk/ZtAHE+ 3WJ425o9n4y9htNQo3da5/nWLyGOai7/mUI81G3A8c2ZjLfQIIUmn0Trc46KOgvFoBAj zwBFOiDM70xcsgE4d1LKpwQ5NC7I5NL8bn2cU2pH3SrN4whomebHcBtFOEYMvUkYtiPi i7NAu6cvxJBwm9Z9NEfQiHGujShEDBd46hjcGC6uhZN11WDmXtWwC/afv8MVdWb2GEKZ LLt+I8pohIyNNYKG55MEjgQJXxGSfG7z2zS1G8ETEauc+gpiqBjHVCHK0y1lbMpqMQ59 bGMQ== X-Gm-Message-State: AKGB3mI+0vIibkqrdfgOVH7pyTU4kh79bNvfSsMPEEQiUxTPFZ3GDum2 jXemoz7UuiZoN3OayFJOc+3k6zrSydP6qIMWf68= X-Google-Smtp-Source: AGs4zMakEkxOAaFfq/HB5aOOUAUa5temuLxje3AcX6cdUpj9ZO9WDfUXjsUAfkCEsZuUvrJ+pNIiFGNC/8F6e/SUIsM= X-Received: by 10.237.62.240 with SMTP id o45mr19072680qtf.141.1512358367976; Sun, 03 Dec 2017 19:32:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Sun, 3 Dec 2017 19:32:47 -0800 (PST) In-Reply-To: <20171201201158.25594-3-sthemmin@microsoft.com> References: <20171201201158.25594-1-sthemmin@microsoft.com> <20171201201158.25594-3-sthemmin@microsoft.com> From: Dave Taht Date: Sun, 3 Dec 2017 19:32:47 -0800 Message-ID: To: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Cake] Fwd: [PATCH net-next 2/2] veth: allow configuring GSO maximums X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 03:32:48 -0000 veth might gain gso support. ---------- Forwarded message ---------- From: Stephen Hemminger Date: Fri, Dec 1, 2017 at 12:11 PM Subject: [PATCH net-next 2/2] veth: allow configuring GSO maximums To: davem@davemloft.net Cc: netdev@vger.kernel.org, Stephen Hemminger Veth's can be used in environments (like Azure) where the underlying network device is impacted by large GSO packets. This patch allows gso maximum values to be passed in when creating the device via netlink. In theory, other pseudo devices could also use netlink attributes to set GSO maximums but for now veth is what has been observed to be an issue. Signed-off-by: Stephen Hemminger --- drivers/net/veth.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index f5438d0978ca..510c058ba227 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -410,6 +410,26 @@ static int veth_newlink(struct net *src_net, struct net_device *dev, if (ifmp && (dev->ifindex !=3D 0)) peer->ifindex =3D ifmp->ifi_index; + if (tbp[IFLA_GSO_MAX_SIZE]) { + u32 max_size =3D nla_get_u32(tbp[IFLA_GSO_MAX_SIZE]); + + if (max_size > GSO_MAX_SIZE) + return -EINVAL; + + peer->gso_max_size =3D max_size; + dev->gso_max_size =3D max_size; + } + + if (tbp[IFLA_GSO_MAX_SEGS]) { + u32 max_segs =3D nla_get_u32(tbp[IFLA_GSO_MAX_SEGS]); + + if (max_segs > GSO_MAX_SEGS) + return -EINVAL; + + peer->gso_max_segs =3D max_segs; + dev->gso_max_segs =3D max_segs; + } + err =3D register_netdevice(peer); put_net(net); net =3D NULL; -- 2.11.0 --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619