Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: Jonathan Morton <chromatix99@gmail.com>,
	Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] Lockup at high speeds
Date: Sat, 2 Jun 2018 10:08:43 -0700	[thread overview]
Message-ID: <CAA93jw4rXiWO+QhRFtcmBETno_G+gF2Qq9CySrWE+n=0ERwcVw@mail.gmail.com> (raw)
In-Reply-To: <871sdqmg8l.fsf@toke.dk>

How on earth are you getting these speeds? I'm stuck at a pathetic *4*
gbit here on the admittedly ancient 12 core boxes I'd got.
(I'll go rework my veth topology)

rcu stuff makes me nervous, what happens if that nat stuff is disabled entirely.

What if you made q.len and sparse/bullk flow counts atomic ops?

I tend to lean towards an overflow post 40gbit also.

On Fri, Jun 1, 2018 at 12:58 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> Jonathan Morton <chromatix99@gmail.com> writes:
>
>>> On 1 Jun, 2018, at 10:23 pm, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>>>
>>> Happens in unlimited mode and when the shaper is set to 60gbps, but not when it is set to 40gbps.
>>
>> Observations:
>>
>>  - The shaper converts a rate in B/s into a time-per-byte value stored
>>  in floating-point - cake_set_rate(). It is plausible that such a
>>  conversion becomes faulty when exposed to especially large values.
>
> Yeah. When changing the rate to a 64-bit value I changed the shifts in
> cake_set_rate() to the maximum possible to try to mitigate this...
>
>>  - 40Gbps is 5.0 GB/s, 0.2000 ns/B.  60Gbps is 7.5 GB/s, 0.1333 ns/B.
>>  No obvious power-of-two threshold is crossed; both are between 0.25
>>  and 0.125 ns/B, require 40 bits to store as bps and 33 as B/s.
>>
>>  - In unlimited mode, the time-per-byte should be zero and the shaper
>>  should therefore always pass traffic without advancing, but
>>  time_next_packet will be continually reset to the latest delivery
>>  time.
>
> Right. I was wondering if there was some way we could end up looping
> through cake_dequeue() forever if the shaper is not limiting things;
> there is both a while(1) and a couple of 'goto begin's in there. I guess
> if the sparse/bulk flow counts or sch->q.len accounting got messed up we
> might? But that shouldn't happen, should it?
>
>> What happens if a watchdog timer is set for a time that has already
>> elapsed?
>
> As far as I can tell from tracing through those functions, that just
> ends up inserting a timer value into an rbtree. So I don't think that in
> itself can cause bad things to happen...
>
> -Toke
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619

  reply	other threads:[~2018-06-02 17:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-01 17:46 Toke Høiland-Jørgensen
2018-06-01 17:49 ` Jonathan Morton
2018-06-01 17:53   ` Toke Høiland-Jørgensen
2018-06-01 19:03     ` Georgios Amanakis
2018-06-01 19:23       ` Toke Høiland-Jørgensen
     [not found]         ` <9A273CA6-FDF6-485D-B466-8B01D4573BD9@gmail.com>
2018-06-01 19:58           ` Toke Høiland-Jørgensen
2018-06-02 17:08             ` Dave Taht [this message]
2018-06-02 18:21               ` Toke Høiland-Jørgensen
2018-06-02 18:55                 ` Dave Taht
2018-06-02 19:25                   ` Toke Høiland-Jørgensen
2018-06-03 14:56                     ` Georgios Amanakis
2018-06-03 23:26                       ` Toke Høiland-Jørgensen
2018-06-05 11:46                         ` Pete Heist
2018-06-05 14:24                           ` Pete Heist

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA93jw4rXiWO+QhRFtcmBETno_G+gF2Qq9CySrWE+n=0ERwcVw@mail.gmail.com' \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox