From: Dave Taht <dave.taht@gmail.com>
To: George Amanakis <gamanakis@gmail.com>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] commit d187cd1 breaks on 4.9.64
Date: Fri, 24 Nov 2017 17:36:18 -0800 [thread overview]
Message-ID: <CAA93jw5-hbfoO5BzbZNf46T3+_hqAZkF0AfBY+0QgmHuPrsJBg@mail.gmail.com> (raw)
In-Reply-To: <59a87fb2-3a40-17af-448d-e4982797f4d0@gmail.com>
reverted. thanks for testing!
On Fri, Nov 24, 2017 at 4:35 PM, George Amanakis <gamanakis@gmail.com> wrote:
> FYI, I am testing the latest cobalt branch, and commit d187cd1 breaks
> compilation on 4.9.64.
>
>
> make -C /lib/modules/4.9.64-1-lts/build SUBDIRS=/home/scy/src2/sch_cake
> modules
> LDFLAGS_MODULE="--build-id=0xf3fb15754862299786d7e6cf1bc26e289a96dff9"
> CFLAGS_MODULE="-DCAKE_VERSION=\\\"f3fb15754862299786d7e6cf1bc26e289a96dff9\\\""
> make[1]: Entering directory '/usr/lib/modules/4.9.64-1-lts/build'
> CC [M] /home/scy/src2/sch_cake/sch_cake.o
> /home/scy/src2/sch_cake/sch_cake.c: In function ‘cake_init’:
> /home/scy/src2/sch_cake/sch_cake.c:2474:12: error: implicit declaration of
> function ‘kvzalloc’; did you mean ‘vzalloc’?
> [-Werror=implicit-function-declaration]
> q->tins = kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data),
> ^~~~~~~~
> vzalloc
> /home/scy/src2/sch_cake/sch_cake.c:2474:10: warning: assignment makes
> pointer from integer without a cast [-Wint-conversion]
> q->tins = kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data),
> ^
> /home/scy/src2/sch_cake/sch_cake.c: In function ‘cake_dump_stats’:
> /home/scy/src2/sch_cake/sch_cake.c:2581:30: warning: initialization makes
> pointer from integer without a cast [-Wint-conversion]
> struct tc_cake_xstats *st = kvzalloc(sizeof(*st), GFP_KERNEL);
> ^~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:300:
> /home/scy/src2/sch_cake/sch_cake.o] Error 1
> make[1]: *** [Makefile:1493: _module_/home/scy/src2/sch_cake] Error 2
> make[1]: Leaving directory '/usr/lib/modules/4.9.64-1-lts/build'
> make: *** [Makefile:8: default] Error 2
>
> George
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake
--
Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619
prev parent reply other threads:[~2017-11-25 1:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 0:35 George Amanakis
2017-11-25 1:36 ` Dave Taht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA93jw5-hbfoO5BzbZNf46T3+_hqAZkF0AfBY+0QgmHuPrsJBg@mail.gmail.com \
--to=dave.taht@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=gamanakis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox