From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x22f.google.com (mail-qt0-x22f.google.com [IPv6:2607:f8b0:400d:c0d::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7C3B53B2A4 for ; Fri, 24 Nov 2017 20:36:19 -0500 (EST) Received: by mail-qt0-x22f.google.com with SMTP id d15so33190792qte.4 for ; Fri, 24 Nov 2017 17:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dZDA7fbGp1IJkPOy0dJ8lT8bqs4K82tWV65c8tWwQlU=; b=Cmfv5WVYIDI1XQFmuYlo4T/BS9qpjxJx8gGnVG/ATNhgl+UFlCQuuhGF3DcMJBuX1n 6mfIPjwtS2mzWz8wlMj8kxYwTGnXpUT03PjhuXU3frPGcugMmD9AgyfIBfQksZG4a9gN rSJrIpST9NGp1CfOnweieDmXOupPL4SCnLbjV19huHltZTdBHmTp538LRmYRK/LrdN0J 2rLsFQG6CFF5WDL7SONc3j78aatce0t74QYMV2jX9PGsnoXtFxhu9necECt8y+BQ/Kzg RUB21BanlucfO70QifWOyqdRpMN5gzHQ6lfUS9Ddd/Oq8TKdOWGob/7X+V/bL5o7IwLY zhEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dZDA7fbGp1IJkPOy0dJ8lT8bqs4K82tWV65c8tWwQlU=; b=I5umKCjsMctRRehqudpCV608nGfWNICrlKUi+MKTHQD1FqtsqVbvqdSO5pD4aAUSrc oU0jlS0JOg6NMvNLB952AAijsQ1mGJwKDCy7iYWLE8EHiuDnXrI0XWzURJrZuLuvkaB4 m6JtxKnSQe0EmBf8YQXk0r/Wj4IG+T97SkMWfL+sJDLPb1cefAzFRb2kNR+a9CcuOT5q yxCz886WRNAkvAqFMydBFUMogMCIf2jpdfMxkcPWdbuR8EhsBa4P5i0M2fOtRbF5Nwnz Xv7oPgTB07s7BShUCVMitYgaJb9E6CMPNm8lY8ubD3U8RkctTD7UqQVaoXE+zsR2S843 I/hw== X-Gm-Message-State: AJaThX7dZQjS8NTkBFLP8YM3KZCeTXq1BwRwqeblB32F3zBCEfTX3jX9 LjCTfQ1G9uqwHEoF6S5Z5EKlWz4fmRCdYp8oPLI= X-Google-Smtp-Source: AGs4zMbSt70QxREmWYMcSXOWJKrDqs3nJ4DFBumSQ4+ok0a8/C1cFiANSpekaxYuYpTXPyROvVovZ4v14v/l5zuftk4= X-Received: by 10.237.55.9 with SMTP id i9mr2734768qtb.164.1511573779022; Fri, 24 Nov 2017 17:36:19 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Fri, 24 Nov 2017 17:36:18 -0800 (PST) In-Reply-To: <59a87fb2-3a40-17af-448d-e4982797f4d0@gmail.com> References: <59a87fb2-3a40-17af-448d-e4982797f4d0@gmail.com> From: Dave Taht Date: Fri, 24 Nov 2017 17:36:18 -0800 Message-ID: To: George Amanakis Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] commit d187cd1 breaks on 4.9.64 X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 01:36:19 -0000 reverted. thanks for testing! On Fri, Nov 24, 2017 at 4:35 PM, George Amanakis wrot= e: > FYI, I am testing the latest cobalt branch, and commit d187cd1 breaks > compilation on 4.9.64. > > > make -C /lib/modules/4.9.64-1-lts/build SUBDIRS=3D/home/scy/src2/sch_cake > modules > LDFLAGS_MODULE=3D"--build-id=3D0xf3fb15754862299786d7e6cf1bc26e289a96dff9= " > CFLAGS_MODULE=3D"-DCAKE_VERSION=3D\\\"f3fb15754862299786d7e6cf1bc26e289a9= 6dff9\\\"" > make[1]: Entering directory '/usr/lib/modules/4.9.64-1-lts/build' > CC [M] /home/scy/src2/sch_cake/sch_cake.o > /home/scy/src2/sch_cake/sch_cake.c: In function =E2=80=98cake_init=E2=80= =99: > /home/scy/src2/sch_cake/sch_cake.c:2474:12: error: implicit declaration o= f > function =E2=80=98kvzalloc=E2=80=99; did you mean =E2=80=98vzalloc=E2=80= =99? > [-Werror=3Dimplicit-function-declaration] > q->tins =3D kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data), > ^~~~~~~~ > vzalloc > /home/scy/src2/sch_cake/sch_cake.c:2474:10: warning: assignment makes > pointer from integer without a cast [-Wint-conversion] > q->tins =3D kvzalloc(CAKE_MAX_TINS * sizeof(struct cake_tin_data), > ^ > /home/scy/src2/sch_cake/sch_cake.c: In function =E2=80=98cake_dump_stats= =E2=80=99: > /home/scy/src2/sch_cake/sch_cake.c:2581:30: warning: initialization makes > pointer from integer without a cast [-Wint-conversion] > struct tc_cake_xstats *st =3D kvzalloc(sizeof(*st), GFP_KERNEL); > ^~~~~~~~ > cc1: some warnings being treated as errors > make[2]: *** [scripts/Makefile.build:300: > /home/scy/src2/sch_cake/sch_cake.o] Error 1 > make[1]: *** [Makefile:1493: _module_/home/scy/src2/sch_cake] Error 2 > make[1]: Leaving directory '/usr/lib/modules/4.9.64-1-lts/build' > make: *** [Makefile:8: default] Error 2 > > George > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619