From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 0097A3BA8E for ; Sat, 30 Sep 2017 23:10:44 -0400 (EDT) Received: by mail-qk0-x235.google.com with SMTP id z143so2699415qkb.3 for ; Sat, 30 Sep 2017 20:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=8Af7QIalgPb0vgLVjPE/ci5285unvAPOlI6rdV5rrTU=; b=Zupt5VQB+CJIJ7PXTWeUNAjjqP07JMgeLpHZ6kWfHQnc0q+uJyzrPYfY42kxie/1kH x39jpAWVxxf725LJjjtPgRcdwlW4+QpVfmJppqsBBvJkaHxGcTReMcjqgEusM/yqz9OQ GE2HIEjO6ZlDvRzE1pNbURgBvWT9r6eKW4/En5ZM8UlDQvuprcfH0EAjMDxhNXQtLCwD UmWGCvi+v4rP8lSW2tK0Mb1uNzLBHQkyoDlTM/canOmPQt5fV7rYEydqCCdjpON8Qubb F9vZiHCxv/xhkDjrWkRAlQENIQC0GgE2lhQkO+wlAK3f+WIC4lTxw3MRK457qR+hG4SM Dpww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=8Af7QIalgPb0vgLVjPE/ci5285unvAPOlI6rdV5rrTU=; b=UsRGBdeIMtw7WzME8gdPQddiMYOWLeNXFwSeMS7JFlC0WVCCXc5GMqKpvWdECwNeiS OhdAzzuCHhbV+cO01+68SoldC7lOLRQbg8DHBFfzNSSqq9o7neTgDnBB5nuSn3ZR/jhS oAWBL1q4xtc6wynISFEHYGylJBaRoC1/fnu5fyewFOM3WDYjUjc63cZ6/79S9aacUeYG kNWRBw8ga+FP5ABSTYHXOuKMy1rTryuQjubvT06pNiMzhiRcmE0rjxBZcrXYaf7V13kp rIYYzf34acaPyMk1EpwZP07Frsz4G2iYgQ/upRzBysJ/8CUPoRQsjTWUwwYb4WyOO1as P0Ig== X-Gm-Message-State: AMCzsaVluSConThirIaxGJkETwPUkd8LHWxjxsrA4LSDrk9f5yDorGwN 0jewnWt6IaAsx1EplHKLyyjblci05Wa5lNbIncgiFw== X-Google-Smtp-Source: AOwi7QDAsUJk3vIf6eD+6YLJj2fJxQk29xSQoMdAc2H+oWItNytkwyHdOhx7RTlDR6/eQTGGtbMGJ4oWeUDg2W77omM= X-Received: by 10.55.109.131 with SMTP id i125mr9311462qkc.17.1506827444330; Sat, 30 Sep 2017 20:10:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.195.67 with HTTP; Sat, 30 Sep 2017 20:10:43 -0700 (PDT) From: Dave Taht Date: Sat, 30 Sep 2017 20:10:43 -0700 Message-ID: To: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Cake] best way at getting at tcp ack data? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 03:10:45 -0000 I was thinking about how I'd go about adding saner ack filtering [1] to cake (or maybe to a tc filter), and perhaps it is way simple, now. Merely using the skb_flow_dissect stuff gives me all the flow related fields, from potentially deeply encapsulated packets - and seems to have grown FLOW_DISSECTOR_KEY_TCP at some point since I last looked. Seems promising. Not sure how to get at it in the context of cake? .... The infamous wondershaper filter looks like this: tc filter add dev $DEV parent 1: protocol ip prio 12 u32 \ match ip protocol 6 0xff \ match u8 0x05 0x0f at 0 \ match u16 0x0000 0xffc0 at 2 \ match u8 0x10 0xff at 33 \ flowid 1:10 And that filter is wrong for encapsulated traffic, and ipv6. [1] https://tools.ietf.org/html/rfc3449 --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619