From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x230.google.com (mail-oi0-x230.google.com [IPv6:2607:f8b0:4003:c06::230]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id D755D21F671 for ; Fri, 27 Nov 2015 06:43:35 -0800 (PST) Received: by oies6 with SMTP id s6so63516892oie.1 for ; Fri, 27 Nov 2015 06:43:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=f+gQWnzmPzr6lbBgMrjvf8Pw6VWY8lPXmdU6Iqrig+0=; b=YILjeniw3QaAZ+5SdkSqTp4U/lZGj5ZuogM4Eu8MiKmbmlpapRnEjnoDVAy+T0147R rJ+5BwZ03zUKHPy68VimVJR7ka2NSeaTH9R0TsUi9dDxjE4dZwobarKEc4H0d12a995/ wdG+E1FM05Iq81JhsJ46ZGBkta+HgK9ZV7RpW9gL1Ov93gAnFivVg6qt/woIQio+fsH5 am9f7l4YfOeHkBcSsh0qIN+xV4w+iBEWnJozlnDAFWqA+ytN4Zj39m708IAqddWXTAb6 RZz68WR+ObWpT3YXnCzzKg3thaYLOJuH0pBtdCQi8Q2GVL/YN+Kb3izGfev+rvU8vwwT 9zCQ== MIME-Version: 1.0 X-Received: by 10.202.205.137 with SMTP id d131mr33484137oig.56.1448635414788; Fri, 27 Nov 2015 06:43:34 -0800 (PST) Received: by 10.202.187.3 with HTTP; Fri, 27 Nov 2015 06:43:34 -0800 (PST) In-Reply-To: <56586B3F.1030408@darbyshire-bryant.me.uk> References: <56586B3F.1030408@darbyshire-bryant.me.uk> Date: Fri, 27 Nov 2015 15:43:34 +0100 Message-ID: From: Dave Taht To: Kevin Darbyshire-Bryant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] 2 commits - unintended changes? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 14:43:58 -0000 thx for the review. sorry for not keeping these commits more separated. this fixes the ecn calculation which otherwise wrapped. Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! https://www.gofundme.com/savewifi On Fri, Nov 27, 2015 at 3:39 PM, Kevin Darbyshire-Bryant wrote: > https://github.com/dtaht/sch_cake/commit/d6a890461ddb6df72e88c20c82ea5b14= eea39ef6 > 'move stats keeping out of inner loop' & > > https://github.com/dtaht/sch_cake/commit/24a0f840d3b0c9ff2f2a10c57d123887= 66f7792f > 'don't calculate rate unless doing autorate' > > mess with things other than that which they say they're messin': > > > struct cake_tin_data *b =3D &q->tins[q->cur_tin]; > struct cake_flow *flow; > struct list_head *head; > - u32 prev_drop_count, prev_ecn_mark; > + u16 prev_drop_count, prev_ecn_mark; > u32 len; > u64 now =3D ktime_get_ns(); > s32 i; > > b->tin_dropped +=3D flow->cvars.drop_count - prev_drop_count; > b->tin_ecn_mark +=3D flow->cvars.ecn_mark - prev_ecn_mark; > + flow->cvars.ecn_mark =3D 0; > flow->dropped +=3D flow->cvars.drop_count - prev_drop_count; > - flow->dropped +=3D flow->cvars.ecn_mark - prev_ecn_mark; > + //flow->dropped +=3D flow->cvars.ecn_mark - prev_ecn_mark; > > if (!skb) { > /* codel dropped the last packet in this queue; try again */ > > > 2nd commit: > > b->tin_ecn_mark +=3D flow->cvars.ecn_mark - prev_ecn_mark; > flow->cvars.ecn_mark =3D 0; > flow->dropped +=3D flow->cvars.drop_count - prev_drop_count; > - //flow->dropped +=3D flow->cvars.ecn_mark - prev_ecn_mark; > > if (!skb) { > /* codel dropped the last packet in this queue; try again */ > > > Intended to change 'prev_drop_count, prev_ecn_mark' & flow->dropped ? > > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake >