From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-x231.google.com (mail-ob0-x231.google.com [IPv6:2607:f8b0:4003:c01::231]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 323C421F96D for ; Tue, 29 Sep 2015 02:55:37 -0700 (PDT) Received: by obbda8 with SMTP id da8so1245458obb.1 for ; Tue, 29 Sep 2015 02:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=KXDX7CBT4HTM2wtxOYm/d9CosdZ2ViLwJCPZXaTCA0w=; b=O4iTjMpi7J57HQYjds4DOHvTwaBPZkdVLQM3FyT2o/Bx5zpamEWG2TusCIVcmDF0t4 +5041W7cIAyVnF8G5FWcMVClLrhm2TCJiakMmBAFGA4JWreowbUIe00+idwpU0Cn5c/k EPpCyyfjf/EFxeQWGJQ3cRXgrrsvT8ECAQJKJneuM70LNoMfhGTTNwPAwL3nRqgM8jt2 llF8KrSDh/zncIRchOsT48rS9bWKnwNJc0EMLJbvlwBKGUDwV246UDYhHLYxQwCwNWcZ 0WaCMyXqQU+brPz7+K8Qk4jmCMueSgb+M9m0P0Jf/0b335e/+Tkx+6wHyQqcw0Qom3jD 6RLw== MIME-Version: 1.0 X-Received: by 10.182.108.167 with SMTP id hl7mr13116766obb.57.1443520536992; Tue, 29 Sep 2015 02:55:36 -0700 (PDT) Received: by 10.202.108.212 with HTTP; Tue, 29 Sep 2015 02:55:36 -0700 (PDT) In-Reply-To: <560A5D19.3000405@darbyshire-bryant.me.uk> References: <56092A0F.3060108@darbyshire-bryant.me.uk> <560969FC.3040107@darbyshire-bryant.me.uk> <560A5D19.3000405@darbyshire-bryant.me.uk> Date: Tue, 29 Sep 2015 02:55:36 -0700 Message-ID: From: Dave Taht To: Kevin Darbyshire-Bryant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Update kernel version check in cake X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 09:56:00 -0000 On Tue, Sep 29, 2015 at 2:42 AM, Kevin Darbyshire-Bryant wrote: > > > On 29/09/15 00:01, Jonathan Morton wrote: >> >> I actually had the version check fix locally, but for some reason it >> hadn't been picked up by a push yet. >> > Yep, I have those moments. Just when I think I've got git sussed it > goes and does something completely logical but totally unexpected :-) >> >> Squashing would involve writing to the TOS byte, which is already done >> by ECN marking, via a helper function. >> > Ah, so if I can work out how that's done I'm 50% of the way there. > Should keep me amused for a few days. >> >> I tried removing the cow stuff once before. Everything promptly >> stopped working until I put it back. I have no idea why. >> > Well here's interesting. I got brave and put my suggested change into > action. So far: 1) router not blown up 2) tc -s still shows traffic in > different Classes (Dave, I prefer your term 'Bin' here too - I > considered 'Bucket' for a laugh) which suggests the reading of ip_hdr is > still working. 3) This hasn't been thoroughly tested in any way > whatsoever but i've tried diffserv4 & besteffort and both don't appear > broken. I agree with bin. Wouldn't mind it if that made it into the variable name instead of class. > Pull request: https://github.com/dtaht/sch_cake/pull/6 It would be my hope also that killing the cow would speed it up. Untested by me, but pulled. > Kevin >> >> - Jonathan Morton >> > > --=20 Dave T=C3=A4ht Do you want faster, better, wifi? https://www.patreon.com/dtaht