Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>
Cc: Jonathan Morton <chromatix99@gmail.com>, cake@lists.bufferbloat.net
Subject: Re: [Cake] [Codel] Proposing COBALT
Date: Tue, 28 Jun 2016 08:44:07 -0700	[thread overview]
Message-ID: <CAA93jw58MjCph57HuWzFqNyHAj-4SNCoOCCxy_G_rnxx1EBaSA@mail.gmail.com> (raw)
In-Reply-To: <577237F9.1080209@darbyshire-bryant.me.uk>

On Tue, Jun 28, 2016 at 1:40 AM, Kevin Darbyshire-Bryant
<kevin@darbyshire-bryant.me.uk> wrote:
>
>
> On 28/06/16 03:51, Jonathan Morton wrote:
>>>
>>> On 27 Jun, 2016, at 18:18, Kevin Darbyshire-Bryant
>>> <kevin@darbyshire-bryant.me.uk> wrote:
>>>
>>> How do you feel about switching that package to the cobalt variant for
>>> wider stress testing?
>>
>> I think the best way to do that would be to merge the cobalt branch to
>> master, but retaining it for further development.  It’s stable enough for
>> that.
>>
>> Except for the stats thing.  Best to fix that first.
>
> Would you like me to split out 'sparse_flows' and 'decaying_flows'? We have
> the space to do so, actually I've done it but won't push unless you say go.
>
> I can hear Dave groaning about stats overload from here:  To allay fears,
> the decaying_flows count is maintained as part of COBALT anyway so there's
> no extra overhead involved.  It nicely splits out the 'codel' flows from the
> 'blue' flows.

My "rule" is basically to keep no on-going (main loop) stats that are
not required for the correct functioning of the algorithm. It's
totally ok to calculate a complex stat when queried for, but there
are(were?) multiple stats in cake that are only used by a small subset
of humanity, and even those, infrequently. I'd have ripped them out
(or made them for debugging only) a long time ago if I'd got consensus
- or folk were trying to optimize again for speed. A good algorithm is
elegant and needs minimal state in the first place...

If you have a stat you need for the algorithm to work, by all means
report on it.

> Kevin
>
>>
>>   - Jonathan Morton
>>
>
> _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 
Dave Täht
Let's go make home routers and wifi faster! With better software!
http://blog.cerowrt.org

  parent reply	other threads:[~2016-06-28 15:44 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20 10:04 [Cake] " Jonathan Morton
2016-05-20 11:37 ` moeller0
2016-05-20 12:18   ` Jonathan Morton
2016-05-20 13:22     ` moeller0
2016-05-20 14:36       ` Jonathan Morton
2016-05-20 16:03         ` David Lang
2016-05-20 17:31           ` Jonathan Morton
2016-05-20 16:37         ` Luis E. Garcia
2016-05-20 16:43           ` Jonathan Morton
2016-05-20 16:55             ` Luis E. Garcia
2016-05-23 18:30             ` Jonathan Morton
2016-05-23 19:11               ` Luis E. Garcia
2016-05-24 13:47               ` [Cake] [Codel] " Jeff Weeks
2016-05-24 14:07                 ` Jonathan Morton
2016-05-24 15:52                   ` Dave Täht
2016-05-24 15:56                     ` Jonathan Morton
2016-05-24 16:02                       ` Dave Taht
2016-05-25  6:40                         ` Loganaden Velvindron
2016-05-25 12:00                         ` Benjamin Cronce
2016-05-26 12:33                     ` Jonathan Morton
2016-06-03 19:09                       ` Noah Causin
2016-06-03 19:34                         ` Jonathan Morton
2016-06-04  1:01                           ` Andrew McGregor
2016-06-04  6:23                             ` Jonathan Morton
2016-06-04 13:55                             ` Jonathan Morton
2016-06-04 14:01                               ` moeller0
2016-06-04 14:16                                 ` Vincent Frentzel
2016-06-04 14:16                                 ` Jonathan Morton
2016-06-04 15:03                                   ` moeller0
2016-06-04 17:10                               ` Noah Causin
2016-06-04 17:49                                 ` Eric Dumazet
2016-06-04 19:55                                   ` Jonathan Morton
2016-06-04 20:56                                     ` Eric Dumazet
2016-06-27  3:56                                     ` Jonathan Morton
2016-06-27  7:59                                       ` moeller0
2016-06-27 15:18                                       ` Kevin Darbyshire-Bryant
2016-06-28  2:51                                         ` Jonathan Morton
2016-06-28  8:40                                           ` Kevin Darbyshire-Bryant
2016-06-28 15:33                                             ` Jonathan Morton
2016-06-28 17:37                                               ` Kevin Darbyshire-Bryant
2016-06-29 15:22                                                 ` Kevin Darbyshire-Bryant
2016-06-30  8:16                                                   ` Kevin Darbyshire-Bryant
2016-06-28 15:44                                             ` Dave Taht [this message]
2016-05-20 13:41     ` [Cake] " David Lang
2016-05-20 13:46       ` moeller0
2016-05-20 14:04         ` David Lang
2016-05-20 15:12           ` Jonathan Morton
2016-05-20 16:05             ` David Lang
2016-05-20 17:06               ` Jonathan Morton
2016-05-20 16:20             ` [Cake] [Codel] " Rick Jones
2016-05-20 16:35               ` Jonathan Morton
2016-05-20 17:01                 ` Rick Jones
2016-05-20 17:07                   ` Jonathan Morton
2016-05-20 17:21                     ` Rick Jones
2016-05-20 17:26                     ` David Lang
2016-05-20 17:33                       ` Jonathan Morton
2016-05-20 14:09       ` [Cake] " Jonathan Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw58MjCph57HuWzFqNyHAj-4SNCoOCCxy_G_rnxx1EBaSA@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox