From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x22d.google.com (mail-qk0-x22d.google.com [IPv6:2607:f8b0:400d:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A29DD3B29E for ; Fri, 1 Dec 2017 23:36:37 -0500 (EST) Received: by mail-qk0-x22d.google.com with SMTP id c13so15743631qke.2 for ; Fri, 01 Dec 2017 20:36:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=QwjEYVDFDJ8kER3RuHBsZefuFKxTjSLRTBEzbjI3CRo=; b=Gb6+z3mR3Ai8G94VDjmYhNMQvfAFn9XSGwu57/QqlP2ZMV18su9fKj14p8zMvA97HI 85JOOk6QtU+dXWRh0lCgNohk8N6kVVvgu1PJCJeAWos1cXKbN7FQK85WFPZ1kcdvBZz2 VuznM9cqGWMAHXKndgyV1OJLxhcCNjRIbMKXleSe/3gbM2mtrK+7Y1rsmbDGzmFsaBmu wU070o6qsXMb/fLTII1fDZICujA1ysSOnjgJ2zs2AxzWUnACMhXR1ZT/95IJk0BbJ3N+ KjQcA9o+mxmJ740C92dAmfyJPqp7OcWP7xiYV8+kMk4NangtPOkViZUUkJGFYn1mIe3Z nrSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=QwjEYVDFDJ8kER3RuHBsZefuFKxTjSLRTBEzbjI3CRo=; b=ZIYz5YPd0YZERrimoufA69R5pe08/x8JVVthFQoeVz8CkxJqU/z/DR5yOsw/A9Kmhn uFF7s6XUiYT9OAt+6mp310hgIBxv/qnUVUg+EKDE9AdflCgjnmcvu+IcSKwU+tuCTnlS kBEedYVPQ5woNUmdwe9ZiN4bpiR4HVwG4eyU9/pFhDFsKf80rOphayLerm9PKgNYJbZa RdYk8ObWTJy1xDmosOhfivyTqiJpmHlasV5KGSPsy55pC4Ox387oTTQgGQtBGtRvCQMu ww2cAjikgBFfzynxYT8PQNWURubuQeIZiAFCcpDJfanioCSPXEv7rogEpg1jnwIRNrG4 e9+w== X-Gm-Message-State: AKGB3mLWTa7dV4939gWiDcIANsUWJioX6tCGm6G8+Asq7oV4QN4mhMmx e7jAF8TXpVgFWUfwHuMonUR81bY0yypjO4K5NadMRg== X-Google-Smtp-Source: AGs4zMbpYtfCxHFtRvt5ZGM7IutjH8+0QmJMjShOhrGDSW6oan8gVXodtSBEjepH6/azm6wzsDjcd9szXnyBuLlpIn8= X-Received: by 10.55.109.4 with SMTP id i4mr10681352qkc.17.1512189396782; Fri, 01 Dec 2017 20:36:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Fri, 1 Dec 2017 20:36:36 -0800 (PST) From: Dave Taht Date: Fri, 1 Dec 2017 20:36:36 -0800 Message-ID: To: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Cake] cake_heap* could use some comments X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Dec 2017 04:36:37 -0000 1) Cake_heap* functions could use a set of explanatory comments. In cake_heapify especially: 1a) m, mb, l are really not self explanatory. "major". "major byte". "lost"= ? r is right? l is left? a is CAKE_MAX_HEAP. 2) What's the operating principle of the overflow_timeout? 3) Why the divide by 2 here: static unsigned int cake_drop(struct Qdisc *sch, struct sk_buff **to_free) { struct cake_sched_data *q =3D qdisc_priv(sch); struct sk_buff *skb; u32 idx =3D 0, tin =3D 0, len; struct cake_tin_data *b; struct cake_flow *flow; struct cake_heap_entry qq; u64 now =3D cobalt_get_time(); if (!q->overflow_timeout) { int i; /* Build fresh max-heap */ for (i =3D CAKE_MAX_TINS * CAKE_QUEUES / 2; i >=3D 0; i--) cake_heapify(q, i); // --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619