From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id C3F583B29E for ; Sat, 11 Jan 2020 16:38:38 -0500 (EST) Received: by mail-io1-xd42.google.com with SMTP id i11so5736731ioi.12 for ; Sat, 11 Jan 2020 13:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ClH0A6CLXREvaVjXl9M8LLnQUh1+/K8DfwTZ4HEOQb4=; b=FS5NAk6oQXOpfCHMcLEQxbwnV18BcFM/vHrH5Aln7a+mvvcWNKYFnFhTZDuyxBDzCT imlnF6kNFkIvDrXcCIuUtfdyJWrJEUW2iw1N+qlN2zpOpcXarsZ7RggmrXSsZ0SrC4e1 R4+P5Fup6yjXx3LmnLmAmRbsYnweqEgQImhRE9pEwV1P5ABTWPolAaTQdXHZD1lqlZjX vxXfX+AejVquUvAVnYcVaBEilQuu2SGCsCl0p8OI4uVuSdUx5lD+LPVIckh2Xf+9CcwY L+I8Ao7SuBDuOdm0b0NPYYCfc0Z5334cxE2IOTHPJ74TRE1c2+kTX/sTVl+zNT9Wrihb tFOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ClH0A6CLXREvaVjXl9M8LLnQUh1+/K8DfwTZ4HEOQb4=; b=sKTmiVTwQMDvc+6EP/RXN6l8Jrij7C2GVU57+qfr9pyCmB+bAq61Qq9TFj6X6XHjmw 1fOE80/HHPk5oiZVGUFgKI9fO4ieLtBHvTVG9xqdpuovZxNtdqdUfl8mb2B/Sn8pqgaO yPnQywQqENKHGhffPOG0Rhakb84dzz9tLGl3wzrbcMUoYQVz6o7rp7Nvg3yk4HXhPT0v FOgugAS1FWg2yqJVmONnDbzWjWMO2hXeB7kydQLd6oFF0hkGCFY3EPjlvs+uiJg6g+WW B/AscoC1iGFDHIfM+fB4xzFeC7tTr8irNsqIkEr8KF/LpZ5/9LtavzNduusvg7Hr6VVh g19Q== X-Gm-Message-State: APjAAAX3QprXcsmL2bsmgq65le1EW9IWdCfXW7zFuTl+a+0/cU9BmGX0 bF7TI+fWpJx39aZf7B28SzeEOyiq6ITqrLBxpTWoLeZJUWE= X-Google-Smtp-Source: APXvYqxciK+SvV5wpdECGuDIAuZupxp0HQwoY7Q6pC/h1uijQnAXKBjh5AEpbclnz7VLCs6uEGoTnyk/APbCTknelso= X-Received: by 2002:a5d:9d10:: with SMTP id j16mr8019340ioj.0.1578778718225; Sat, 11 Jan 2020 13:38:38 -0800 (PST) MIME-Version: 1.0 References: <1578730684729@kroah.com> <13E6E54B-BCF8-44C7-9E0F-55127DB9A42C@darbyshire-bryant.me.uk> In-Reply-To: <13E6E54B-BCF8-44C7-9E0F-55127DB9A42C@darbyshire-bryant.me.uk> From: Dave Taht Date: Sat, 11 Jan 2020 13:38:27 -0800 Message-ID: To: "Kevin 'ldir' Darbyshire-Bryant" Cc: Cake List , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] Patch "sch_cake: avoid possible divide by zero in cake_enqueue()" has been added to the 4.19-stable tree X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jan 2020 21:38:38 -0000 Thank you for all the gymnastics to keep cake alive in openwrt. I would still like there to be a sce branch of the out of tree work that I could point people at in my lca talk this week, but I understand that's increasingly difficult. On Sat, Jan 11, 2020 at 1:20 PM Kevin 'ldir' Darbyshire-Bryant wrote: > > > > > On 11 Jan 2020, at 20:40, Dave Taht wrote: > > > > did this make it into openwrt already? > > It=E2=80=99s complicated and it depends what you mean by openwrt. > > First off, the fix relates to auto-bandwith mode or whatever it=E2=80=99s= called and I don=E2=80=99t think many people use it. Nonetheless: > > Is the fix in =E2=80=99net-next=E2=80=99: yes > Is the fix in 4.19 stable: In the queue for 4.19.95 > > Is openwrt on 4.19.95: No > Does openwrt use the in-tree version of Cake?: No > > Is the fix in the Out-Of-Tree cake git repo: Yes > > Has the openwrt CAKE package been bumped to follow cake git repo?: master= , yes, as of 2020/01/11 (earlier today) > > OpenWrt 19.07 has just been released, its concept of cake package has not= been bumped. Neither has 18.06. > > > It is worth noting that until yesterday/recently the out of tree cake rep= o had residue in it from some experimental stuff (SCE & updating conntrack = marks) and did not represent upstream in-tree CAKE anyway. That situation = was corrected AFAIK completely this morning. > > Ideally I would like openwrt to use the in-tree CAKE, with =E2=80=98featu= re backports=E2=80=99 from later kernels as backport patches. Unfortunatel= y some targets in openwrt are still on 4.14 kernels so there is no in-tree = CAKE to use. Dropping CAKE from pre 4.19 kernels caused a bit of an outcry= when I did it, so the next idea was to have a choice of cake kernel module= for K4.19 targets, in-tree & out-of-tree CAKE. Unfortunately that exposed= a weakness in package dependency selection, so that idea hasn=E2=80=99t fl= own either. I=E2=80=99m afraid enthusiasm levels then dropped. > > --=20 Make Music, Not War Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-435-0729