* [Cake] link_ms unused
@ 2018-03-08 17:29 Dave Taht
2018-03-08 21:33 ` Toke Høiland-Jørgensen
0 siblings, 1 reply; 3+ messages in thread
From: Dave Taht @ 2018-03-08 17:29 UTC (permalink / raw)
To: Cake List
And while I'm breaking things, the link_ms field is entirely unused in
struct tc_cake_traffic_stats {
__u32 packets;
__u32 link_ms;
__u64 bytes;
};
and thus packets could also be made 64 bits. We don't fill in all the
parameters of this
struct all the time, either.
--
Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Cake] link_ms unused
2018-03-08 17:29 [Cake] link_ms unused Dave Taht
@ 2018-03-08 21:33 ` Toke Høiland-Jørgensen
2018-03-08 21:38 ` Dave Taht
0 siblings, 1 reply; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2018-03-08 21:33 UTC (permalink / raw)
To: Dave Taht, Cake List
Dave Taht <dave.taht@gmail.com> writes:
> And while I'm breaking things, the link_ms field is entirely unused in
>
> struct tc_cake_traffic_stats {
> __u32 packets;
> __u32 link_ms;
> __u64 bytes;
> };
what was that field supposed to contain?
-Toke
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Cake] link_ms unused
2018-03-08 21:33 ` Toke Høiland-Jørgensen
@ 2018-03-08 21:38 ` Dave Taht
0 siblings, 0 replies; 3+ messages in thread
From: Dave Taht @ 2018-03-08 21:38 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: Cake List
On Thu, Mar 8, 2018 at 1:33 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> Dave Taht <dave.taht@gmail.com> writes:
>
>> And while I'm breaking things, the link_ms field is entirely unused in
>>
>> struct tc_cake_traffic_stats {
>> __u32 packets;
>> __u32 link_ms;
>> __u64 bytes;
>> };
>
> what was that field supposed to contain?
I think it is an artifact going way back in time to something
inherited from fq_codel.
>
> -Toke
--
Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-08 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 17:29 [Cake] link_ms unused Dave Taht
2018-03-08 21:33 ` Toke Høiland-Jørgensen
2018-03-08 21:38 ` Dave Taht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox