Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Ryan Mounce <ryan@mounce.com.au>, Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] CAKE upstreaming - testers wanted, ACK filtering rescuers needed
Date: Wed, 25 Apr 2018 20:23:09 -0700	[thread overview]
Message-ID: <CAA93jw5PK0CVgJQL-faQ3eSxYvmqZHroFciEARmdBTv03XovXA@mail.gmail.com> (raw)
In-Reply-To: <20180425183200.0877eaa2@xeon-e3>

On Wed, Apr 25, 2018 at 6:32 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Thu, 26 Apr 2018 10:40:29 +0930
> Ryan Mounce <ryan@mounce.com.au> wrote:
>
>> I'll investigate making the ACK filtering code safe, it is my mess after all :)
>>
>> Eric obviously understands this stuff a lot better than me, it looks
>> like there are two issues?
>> - Lack of minimum length check for TCP header, should be fairly
>> straight-forward to fix
>> - The possibility of unsafely filtering part of a split GSO super-packet?
>>
>> Regards,
>> Ryan Mounce
>>
>> ryan@mounce.com.au
>> 0415 799 929
>
>
> It makes more sense to move it out of Cake altogether. Cake is already one
> of those projects that seems to have Golden Hammer disease.
>   https://en.wikipedia.org/wiki/Law_of_the_instrument
>
> Why not in netfilter or XDP? Then it could be used in other contexts like
> tunnels or selectively based on route etc.

'cause it needs a queue and state. netfilter doesn't have a queue.

 _______________________________________________
> Cake mailing list
> Cake@lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake



-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619

  reply	other threads:[~2018-04-26  3:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 20:45 Toke Høiland-Jørgensen
2018-04-26  1:10 ` Ryan Mounce
2018-04-26  1:32   ` Stephen Hemminger
2018-04-26  3:23     ` Dave Taht [this message]
2018-04-26  6:39   ` Toke Høiland-Jørgensen
2018-04-26  6:54     ` Ryan Mounce
2018-04-26  7:14       ` Toke Høiland-Jørgensen
2018-04-26  7:19 ` Kevin Darbyshire-Bryant
2018-04-26  7:34   ` Toke Høiland-Jørgensen
2018-04-26  8:43     ` Jonas Mårtensson
2018-04-26  8:55       ` Toke Høiland-Jørgensen
2018-04-26 12:02         ` Jonas Mårtensson
     [not found] ` <mailman.301.1524727201.3573.cake@lists.bufferbloat.net>
2018-04-26  7:26   ` Jonathan Morton
2018-04-26  7:43     ` Sebastian Moeller
2018-04-26 14:42       ` Jonathan Morton
2018-04-26 15:25         ` Sebastian Moeller
2018-04-27  0:17       ` David Lang
2018-04-26  8:16     ` Kevin Darbyshire-Bryant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw5PK0CVgJQL-faQ3eSxYvmqZHroFciEARmdBTv03XovXA@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=ryan@mounce.com.au \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox