From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x230.google.com (mail-qt0-x230.google.com [IPv6:2607:f8b0:400d:c0d::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A0F143BA8E for ; Wed, 25 Apr 2018 23:23:11 -0400 (EDT) Received: by mail-qt0-x230.google.com with SMTP id m5-v6so354949qti.1 for ; Wed, 25 Apr 2018 20:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5zkX1hMqZc2MpqK87Ibw6qmktkQHLBMoSAErzt5Yojg=; b=qX5ygGasEarUhT7zvGD02CqG8Cb1d5BxR85GnJU2Hvldegckt8q13QXZcLJnHrFo3S TTw9m4lsptmwiOkyDq/IZe+7QlAhkNc+26uOfMwcaWDuRT/wL9XB6fVnS1hdnogGDzMQ IL/DBHjt6oZzksSLF30OP2MgYOZkWC90ywwThTzSRu9VYAng9nJJBv72FxKfqmGEapKZ nDGFTVDcNJV4921Oqmf5ljNG+50v2XZc8TLkkjKcuYkPMKbSdT75Bi1iPdSCo8wKDxfN CACqNe2bADVaePjjkLM2+XlYvauKwLFb6m5ulv8JsM+JykSnUFw0OliSljxTZQbLx5qp KoFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5zkX1hMqZc2MpqK87Ibw6qmktkQHLBMoSAErzt5Yojg=; b=iTHk27BWHsKSy2SIG1IuTSfakjY4gsWtWwUyU4mhGfcyrRchB32fj563A1jZgkqQ6J 2wx4kbj+ZUPbLNdI/X9n24T2/jEtx+gJL+/PH8M4JETmpcetB6JaJRwQhtdWmWbrD9uZ YInnHjgMyP1HLlWyonO4H4ga6A/9kQKAGVA8CilFsoRnWvTwaCEbwnOHaZ7dvf9Gvnu2 dqRtnfzbHp7sIju0GV1QwNBlIV74R2LtenYy8Qgg4+dl38ACn0pFj66E7OvTQiG0HSDy 0s8MJPYiXdggTPKGJ6+YQVFpB/osac1z5G6NhWqslFvabWY6nnwO1FOH5FsHgmV59ypi 97RA== X-Gm-Message-State: ALQs6tCNVjNMduOaoGfFTJzOgAFTKpy1NJxwliijsrDsePtg1KK2qtmE KoCgxKio8tXXEBYotbVZIh+cetey1M9V4V96Gbc= X-Google-Smtp-Source: AB8JxZp7T7fsAImV3JfY3GzRBWhEzToT3Ps1/MID776PbTAhDfY/bjt4kQAi+wuWb309kqSN9yM4zeALSDLYjj/R97g= X-Received: by 10.12.181.228 with SMTP id o36mr10693009qvf.116.1524712991154; Wed, 25 Apr 2018 20:23:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.243.147 with HTTP; Wed, 25 Apr 2018 20:23:09 -0700 (PDT) In-Reply-To: <20180425183200.0877eaa2@xeon-e3> References: <87vacf3th7.fsf@toke.dk> <20180425183200.0877eaa2@xeon-e3> From: Dave Taht Date: Wed, 25 Apr 2018 20:23:09 -0700 Message-ID: To: Stephen Hemminger Cc: Ryan Mounce , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] CAKE upstreaming - testers wanted, ACK filtering rescuers needed X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 03:23:11 -0000 On Wed, Apr 25, 2018 at 6:32 PM, Stephen Hemminger wrote: > On Thu, 26 Apr 2018 10:40:29 +0930 > Ryan Mounce wrote: > >> I'll investigate making the ACK filtering code safe, it is my mess after= all :) >> >> Eric obviously understands this stuff a lot better than me, it looks >> like there are two issues? >> - Lack of minimum length check for TCP header, should be fairly >> straight-forward to fix >> - The possibility of unsafely filtering part of a split GSO super-packet= ? >> >> Regards, >> Ryan Mounce >> >> ryan@mounce.com.au >> 0415 799 929 > > > It makes more sense to move it out of Cake altogether. Cake is already on= e > of those projects that seems to have Golden Hammer disease. > https://en.wikipedia.org/wiki/Law_of_the_instrument > > Why not in netfilter or XDP? Then it could be used in other contexts like > tunnels or selectively based on route etc. 'cause it needs a queue and state. netfilter doesn't have a queue. _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619