From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x243.google.com (mail-qt0-x243.google.com [IPv6:2607:f8b0:400d:c0d::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id BF0E13CB35 for ; Fri, 22 Dec 2017 10:55:18 -0500 (EST) Received: by mail-qt0-x243.google.com with SMTP id g10so36719109qtj.12 for ; Fri, 22 Dec 2017 07:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1J947LYKOK4rwuPIH8Ko5CF1eV3IohXP3CKug69HqJ0=; b=FgbliWKAdghX38qj+J1XV3ZQhJjQ4rdnJGghfOd7RDD98KRNfzwH9fh32SuDhU/NNA G/x1krFcH6TUBUr1sOO1socvkqGBpJ9ptcz77b6vhr5bVl0yI78hKjVL6koI2JAkfTrv rrL6PBiOfcBIO5f2GkCyLM7INHYKnMCUIkeTpjKeBxhhe5XmughfcHoaeUT5Ft8wQk93 i+Nma3i9/8xdX5rf2LpyZCcwdoQf/0F6d4pDT5cHlBY8RZc/5epaXPaX+AWUaWXEwmxl PmQ9Wax05AUOWJ3qVBNtZJvL0Z3JLQAidLEZesdreodzkd6hXo7rmmPgYqZEDnctTW+Z xf2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1J947LYKOK4rwuPIH8Ko5CF1eV3IohXP3CKug69HqJ0=; b=s2JN8ngpuB+MlUyQLfSRNbj7NX4czmsiYObPSrysHfMeqdzwUmsCYDEqIXtW9iS0Jq F7PhMConw09INMOyx7Lq1B2ww3Q8U9gYPJvXYD8gUkSwOFICJzq2ByQdMRvVCdzrRtAp swNxxHwdmlvfVb6tF3FhnZaObL7YtaW8V11QL+jCIrVd7842cB0TY6j1dyXt2VA6zoHe uu54ptRQZQRgkacc2dRuUHq42J2FPZRZ9pZh3czVBqQrKYkeEZeqRaHkCFJnppnknc49 1BWgR4v+BIZT+4+wvLZVNyovkPmvl68nzTMdSSU3IBXnnOm/H9U0jW+BUgld8/2KISIZ dh2Q== X-Gm-Message-State: AKGB3mL8DCyn69nql6LGvvfO+D3eoH7w1nwvWaX5i/meMay2nwarLxlv ajbB9arFaEYstW6F1u1GJxBlM//MUrn4FbQvsxc= X-Google-Smtp-Source: ACJfBot3fKtOQvAryG9x39YqGAidOIIJJkXUYZq+tunCMBSmOkl0Dxnu6OkrOnL9X6BKnUZ/63zRlTR035L8+WXxU0g= X-Received: by 10.200.39.148 with SMTP id w20mr22227167qtw.178.1513958118305; Fri, 22 Dec 2017 07:55:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Fri, 22 Dec 2017 07:55:17 -0800 (PST) In-Reply-To: References: <31d49a5d-02a2-3dc8-a455-52d453b83bdf@gmail.com> From: Dave Taht Date: Fri, 22 Dec 2017 07:55:17 -0800 Message-ID: To: Jonathan Morton Cc: Andy Furniss , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] overheads or rate calculation changed? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 15:55:18 -0000 Thx andy and jon for the bisect and the fix. I am deep in the jungles of nicaragua at the moment, and won't be doing much with any codebases until I get out in mid january - the internet is terrible here, and where I am hasn't had power in a couple days, either! Expect sparse emails from me til then. (But the food, surf, and alcohol are fantastic, and I'm trying to fix the local wifi AP pointed 8km into town). I kind of gave up on the mainlining attempt this go-round (I don't understand why the kbuildbot kicked it back, there's no stack use in the function it dislikes that I can see!?). if this shaper fix was 'the last bug" on the reorganized code, I'd support someone (with reliable internet) pushing it to lede. On Thu, Dec 21, 2017 at 10:38 PM, Jonathan Morton w= rote: >> On 21 Dec, 2017, at 2:54 am, Andy Furniss wrote: >> >> refactor cake_advance_shaper and ack_filter >> >> cake_advance_shaper now returns a modified len argument to >> reflect cake_overhead. >> skb_ack_filter variable replaced with ack > > Fixed. At one point cake_advance_shaper() was still getting a packet len= gth with overhead correction already applied, and was then applying it a se= cond time. > > - Jonathan Morton > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619