From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x229.google.com (mail-oi0-x229.google.com [IPv6:2607:f8b0:4003:c06::229]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 14DB821F603 for ; Mon, 16 Nov 2015 07:03:18 -0800 (PST) Received: by oies6 with SMTP id s6so85750716oie.1 for ; Mon, 16 Nov 2015 07:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Hl93Bo3GM1th1IP70Iwgq+SA+x4Xrln0VvOKBDVAbh0=; b=vfz3/VtmZtK978MG2/U5voCQYa4t+iMYma+vWrV38UoBTCod68cz7MHB/5HO3J+42N bklTEHLfkPY0uMLpPSGTvpZYSzB9eJyIeQSp4jK8/Oze77VoqpeMenyXsK5LAPHntYIP ZePTu4H1mS/Ph2H4TtLTHHfO8592mZeg+HXQ+Vluto0wY2CsU1qW1EBmI8Dzw+21Ih0K Y4+78QUPH9SdWQWH62o9nhMvxOFQLe0kuFs1Wub+QV3JC9PT9RI87TUJzyntKZOgGBrm Crvtq8XNKrvRkzgTU+bM1oJyo8UAPvUeUa/eKS3eknV6w3KIAVIyzC+wMXo1WP/GpUvH yf2w== MIME-Version: 1.0 X-Received: by 10.202.64.198 with SMTP id n189mr6289543oia.139.1447686197572; Mon, 16 Nov 2015 07:03:17 -0800 (PST) Received: by 10.202.50.130 with HTTP; Mon, 16 Nov 2015 07:03:17 -0800 (PST) In-Reply-To: <5649EF39.3060300@darbyshire-bryant.me.uk> References: <56420697.9080606@darbyshire-bryant.me.uk> <5649EF39.3060300@darbyshire-bryant.me.uk> Date: Mon, 16 Nov 2015 16:03:17 +0100 Message-ID: From: Dave Taht To: Kevin Darbyshire-Bryant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Announce - possible new feature - DSCP cleaning X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2015 15:03:41 -0000 I have not been doing any active development until... tomorrow. A goal I have for today is to actually build a version of openwrt + all this stuff for the linksys ac1200. I was not particularly huge on using another field (q->squash) to trigger squashing, and I cannot come up with a use case that makes sense to me. Under what circumstances do you think separating these two functions to be useful? Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! https://www.gofundme.com/savewifi On Mon, Nov 16, 2015 at 3:59 PM, Kevin Darbyshire-Bryant wrote: > Does anyone have any feedback on this? Good idea/bad idea? Good/bad > implementation? > > Any reason why 'squash' branches of both sch-cake & tc-adv shouldn't be > merged? > > On 10/11/15 15:00, Kevin Darbyshire-Bryant wrote: >> Greetings :-) >> >> A bit of a blast from the past this one, but one Sebastian Moeller of >> this list fame wrote a while ago " >> >> Just played a bit with the shiny new squash option. For my limited testi= ng it seems to work. I do wonder whether the automatic default to besteffor= t is the ideal behavior though. For example on egress it would be nice to b= e able to use the internal set DSCP markings but clean them from the outgoi= ng packets as not to leak =E2=80=9Cinformation=E2=80=9D to the ISP, similar= ly but more contrived the same could be agued for ingress " >> >> Well Mr Moeller, today is your lucky day because I've just pushed 'squas= h' branches to both cake & tc-adv that separate the 'DSCP squashing' behavi= our from diffserv behaviour. Specifying 'squash' sets diffserv mode to 'be= steffort' (ie 1 tin only) and squashes DSCP as before, however if you speci= fy something like 'diffserv4 squash' then DSCP codings are noted at qdisc e= nqueue so tins/bandwidths are used as marked, then the DSCP marking is squa= shed so on dequeue DSCP has been removed. >> >> The active bit of the change is (diff): >> >> /* extract the Diffserv Precedence field, if it exists */ >> - if (q->tin_mode !=3D CAKE_MODE_SQUASH) { >> + if (q->tin_mode !=3D CAKE_MODE_BESTEFFORT) { >> tin =3D q->tin_index[cake_get_diffserv(skb)]; >> if (unlikely(tin >=3D q->tin_cnt)) >> tin =3D 0; >> } else { >> - cake_squash_diffserv(skb); >> tin =3D 0; >> } >> >> + /* now clear DSCP bits if squashing */ >> + if (q->squash) >> + cake_squash_diffserv(skb); >> >> >> https://github.com/dtaht/sch_cake/tree/squash & https://github.com/dta= ht/tc-adv/tree/squash >> >> Needs testing (I've not managed to break it yet) and *thought before mer= ging* >> >> >> >> >> >> _______________________________________________ >> Cake mailing list >> Cake@lists.bufferbloat.net >> https://lists.bufferbloat.net/listinfo/cake > > > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake >