From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DB1FA3B29E for ; Sun, 5 Apr 2020 11:23:00 -0400 (EDT) Received: by mail-io1-xd29.google.com with SMTP id q9so12993143iod.4 for ; Sun, 05 Apr 2020 08:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=c6KFQ59p4wGdNJLCAVCTyz6N6TzQfGATBW14X2+rj+0=; b=fnuKCp1Wq+1C4JBzLXeg5L7rRWsQc9KxoIPoZY2dmLtt7AgOSXoQNTl8vfGi6CenVq Zo9BWE1HIodgnOj1TPaRMW4G0yNNwvi5uCM91lJho3gUr5msCticw67wgR7i3hQrEQcG t0k2hI/RX/c2daTnsAKXHoDSY9h+a83QJS6L3jjMZI0ESvI//DkmVlX44ovdxcUGP2d/ qgxbtq6EelZCUewTNkDpcaNoX7sEvIWwAL+lBOAxciD/n+9LFjn2ebDOXrvTcixELmfd MivRgcwH/M2D+Dy23dCs7YI/tUrNCPCQRCIiZ6AtCxo5FLvfaxhIIBYJZ+LL0Q3S1W4E cF8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c6KFQ59p4wGdNJLCAVCTyz6N6TzQfGATBW14X2+rj+0=; b=YpsalO0FB1Wpna81pi1hZZN301i/vBAo0V7+20vz6b6VamZ+wj4SfMgLGSdD0nf7iR BDrLfdLRp7IOeqyDGS0tnxNU/22y3Ak9JcAdLNQF5DxmOHfbTUDiIlnCbkM1KjtUrVZ7 lfwDIpnK/qUdF/awUNiRKFJxjsvWs4qAD1Y/G7GGzv+O5RFxhb5xAizu64pZHIfiaLAl WfqU7sf41C8ntWT2GarrPYwO/CCx3kZXA/EpIbJDYTDuBm8p3FODGuph0BHnUyVl7AMh GS4Vv9pOdBrNdexTyjJvlq7SksBYpaamRilWJsJvAEVuSUevnOAiKpay87NJu2UC01Qa fx1A== X-Gm-Message-State: AGi0PuZP8Dt0EGzFcJOGEJAi6xlQV1fii3RaWozaMFYpDpzrgA/v/CYr P9U/K3cCQ7ZXRsQpR+yHKdjDblm4zTt1pY0UreA= X-Google-Smtp-Source: APiQypI68fXBT/Rog5p4LWGPM7edBVCMguOMULiFQ9TxalyRBD6ZbVyJrF/ZyPMsvupTVjNBGW9OchyjacYqpFyvFcQ= X-Received: by 2002:a02:a605:: with SMTP id c5mr16178524jam.82.1586100180210; Sun, 05 Apr 2020 08:23:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Taht Date: Sun, 5 Apr 2020 08:22:48 -0700 Message-ID: To: Kevin Darbyshire-Bryant Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] cake and nat in openwrt... on by default? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 15:23:01 -0000 On Sun, Apr 5, 2020 at 12:57 AM Kevin Darbyshire-Bryant wrote: > > > > > On 5 Apr 2020, at 05:17, Dave Taht wrote: > > > > I see cake is moving to the upstreamed version. As best as I recall, > > nat mode was on by default in the openwrt code, but not the upstreamed > > code. > > > > People not setting nat mode on would explain a few things i've seen > > 'round the intertubes this week. > > From sch_cake repo and hence =E2=80=98out of tree=E2=80=99 cake > > if (tb[TCA_CAKE_NAT]) { > #if IS_REACHABLE(CONFIG_NF_CONNTRACK) > q->flow_mode &=3D ~CAKE_FLOW_NAT_FLAG; > q->flow_mode |=3D CAKE_FLOW_NAT_FLAG * > !!nla_get_u32(tb[TCA_CAKE_NAT]); > #else > #if LINUX_VERSION_CODE >=3D KERNEL_VERSION(4, 16, 0) > NL_SET_ERR_MSG_ATTR(extack, tb[TCA_CAKE_NAT], > "No conntrack support in kernel"); > #endif > return -EOPNOTSUPP; > #endif > } > > > From kernel 5.4 as found in openwrt build dir > > if (tb[TCA_CAKE_NAT]) { > #if IS_ENABLED(CONFIG_NF_CONNTRACK) > q->flow_mode &=3D ~CAKE_FLOW_NAT_FLAG; > q->flow_mode |=3D CAKE_FLOW_NAT_FLAG * > !!nla_get_u32(tb[TCA_CAKE_NAT]); > #else > NL_SET_ERR_MSG_ATTR(extack, tb[TCA_CAKE_NAT], > "No conntrack support in kernel"); > return -EOPNOTSUPP; > #endif > > > > cake_init(=E2=80=A6) in both does: > > q->flow_mode =3D CAKE_FLOW_TRIPLE; > > > So openwrt doesn=E2=80=99t, by default, enable NAT mode in cake. > > I honestly don=E2=80=99t think that there are enough instances of cake ou= t there, let alone instances of cake from openwrt, let alone instances of c= ake from master which switched to upstream cake 2-3 days ago, to make any s= ort of difference anyway. I'd still be willing to bet, then, that the majority of instances were not turning nat mode on, when they should have been. > > > > > -- > > Make Music, Not War > > > > Dave T=C3=A4ht > > CTO, TekLibre, LLC > > http://www.teklibre.com > > Tel: 1-831-435-0729 > > _______________________________________________ > > Cake mailing list > > Cake@lists.bufferbloat.net > > https://lists.bufferbloat.net/listinfo/cake > > > Cheers, > > Kevin D-B > > gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > --=20 Make Music, Not War Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-435-0729