From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 29A3B3CB35 for ; Thu, 19 Jul 2018 09:11:03 -0400 (EDT) Received: by mail-qk0-x233.google.com with SMTP id 27-v6so4204865qkv.0 for ; Thu, 19 Jul 2018 06:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=ZSWHe+JuwsHvhv5+y93Qa8ySlmjBsIhHaSD9pQkQg1o=; b=sMl+WbKSowgQPMGIVgvMjYG/Qe1V5vPCTt+t2T2Rz4U9ku+8DpooFMeUQySJR4nW59 pizfEinSfStRfGka0DMvqUUahgXbQZfsPzA07mwnjZRnJVgLJ+CjdysnHmP6SDd20EfC i4HTFO6S3qc/Ca6fWUrudzAKDZsqvKKcwMmWeb8ipE5kdBMXz4HinVg/ITZSzW2rhN9H 6xavtFjWB/VFlglHrEjWAiVezlhQHJgcpzMGDnzU/b8tIsI/pzcPJZqUKwvqSIvFXkS5 3Bc8CItPeMwnAaYcaEsaNuHAVlbByZtlTbB1rfRVM+5bHDLcaeWPki1Q1Wds5T6pE98I DgOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=ZSWHe+JuwsHvhv5+y93Qa8ySlmjBsIhHaSD9pQkQg1o=; b=D2TZKiEqS4lOsmgMc8aG9SmczY8BwfGTljcnUkNUmF+HQFU/p1tSxgdeX/xOlkW0fO eFzMMzyCJWHQVsGRYGtwYKWC1aOsnF/P9kwp5Y53wEsxNu1U8YYXiN+rpgwrWWa2Lp4s ojkuAKZWVzvsyw2rA4OnzHFssEc6WB6xCeI4mGc9lk0UtdIatWyYp4orrCq3uZBgYkBH M0Fyj295VGBzD8uQcl2fRI0yURO78mp6YbRgKHjFuKfWx8PbHxA1QRsEJzUxKv4f19Iv tdfp8ynrWMjwJ7Syc9lW2I1bnb+RdCAGVfwR+g+UJ3z+wm/SJBafq/xgjbRDbKwVpFoD iN5A== X-Gm-Message-State: AOUpUlFrj8htlNOnCnrz5eC55MaMmGxtMIWP96X8BIFprsGHdetoEyIF LnYx3mSV1piLGgti1bWjmo3xbFttEyIE+PQmyU5hJg== X-Google-Smtp-Source: AAOMgpeOMPExiStaG0z1yjJvxDL5/E856qQIeJnSfq7a+9dktm37ZAwgBGtftMEZyIJJKZzGdxRF7Y3rJxIGL0PTdZE= X-Received: by 2002:a37:21e6:: with SMTP id f99-v6mr8515269qki.206.1532005862353; Thu, 19 Jul 2018 06:11:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Taht Date: Thu, 19 Jul 2018 06:12:12 -0700 Message-ID: To: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Cake] Fwd: [PATCH net-next 0/4] TC: refactor act_mirred packets re-injection X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 13:11:03 -0000 It looks like backporting this to openwrt would be a pita, but a potential 10% improvement to inbound shaping is not to be sneezed at (and I imagine it could be better than that for non-intel cache-crippled routers) ---------- Forwarded message --------- From: Paolo Abeni Date: Thu, Jul 19, 2018 at 6:04 AM Subject: [PATCH net-next 0/4] TC: refactor act_mirred packets re-injection To: Cc: Jamal Hadi Salim , Cong Wang , Jiri Pirko , Daniel Borkmann , Marcelo Ricardo Leitner , Eyal Birger This series is aimed at improving the act_mirred redirect performances. Such action is used by OVS to represent TC S/W flows, and it's current larg= est bottle-neck is the need for a skb_clone() for each packet. The first 2 patches introduce some cleanup and safeguards to allow extendin= g tca_result: we will use it to store RCU protected redirect information. Then a new tca_action value is introduced: TC_ACT_MIRRED, similar to TC_ACT_REDIRECT, but preserving the mirred semantic. The last patch exploit= s the introduced infrastructure in the act_mirred action, to avoid a skb_clon= e, when possible. Overall this the above gives a ~10% performance improvement in forwarding t= put, when using the TC S/W datapath. v1 -> v2: - preserve the rcu lock in act_bpf - add and use a new action value to reinject the packets, preserving the m= irred semantic Paolo Abeni (4): tc/act: user space can't use TC_ACT_REDIRECT directly tc/act: remove unneeded RCU lock in action callback net/tc: introduce TC_ACT_MIRRED. act_mirred: use ACT_MIRRED when possible include/net/act_api.h | 2 +- include/net/sch_generic.h | 21 +++++++++++++++++++++ include/uapi/linux/pkt_cls.h | 2 ++ net/core/dev.c | 4 ++++ net/sched/act_api.c | 7 +++++++ net/sched/act_csum.c | 12 +++--------- net/sched/act_ife.c | 5 +---- net/sched/act_mirred.c | 35 +++++++++++++++++++++++------------ net/sched/act_sample.c | 4 +--- net/sched/act_skbedit.c | 10 +++------- net/sched/act_skbmod.c | 21 +++++++++------------ net/sched/act_tunnel_key.c | 6 +----- net/sched/act_vlan.c | 19 +++++++------------ 13 files changed, 83 insertions(+), 65 deletions(-) -- 2.17.1 --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619