From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x22c.google.com (mail-qk0-x22c.google.com [IPv6:2607:f8b0:400d:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 15D2E3B29E for ; Sat, 25 Nov 2017 11:48:39 -0500 (EST) Received: by mail-qk0-x22c.google.com with SMTP id v137so27776089qkb.1 for ; Sat, 25 Nov 2017 08:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dqf7JOm6c3Nq0sioaAwqxOgpdohxjcwCP0z//zIb594=; b=TryzD13ROQFv0vd8hLH4T97kOVq4k5pQ8Dc+XRwaByzk3mzCn2GGH4DUNxxC5xUcwL 6YNJSAk7PfmKcV7OXkNfZmSAV7z0LHYW0AGMTkeyUVfjIhTEKTnTg2hCfz9duKHTYP6h HGt0VHExeAnWak9LWPUxHpfkgxO03WuTzKOoSG83heOOzwyM3mKWbsq0/5aCeg2VhYfk 6JY4OhRyooa7BBgBIEO+SxtQK6fChaxRRXzeqjnYn314mQtrHdCz6ssphBwaxSvrHBOr AQCPd4ypw4echc2hJpCeLhPVF7KyJMe8lQEp2tqiRcMqLRsEDI0/5wSPB+VLqKfVpWLz USZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dqf7JOm6c3Nq0sioaAwqxOgpdohxjcwCP0z//zIb594=; b=R61qItk5UBBQ5Qm/4Zo4k+9lp2cjq5jbpueZ2R/fWEcIGsaQjjrPvJSrwvR5lYk/h6 5ssij6E5SxXPzfkQHzqYIMH6Dzsg9ILvszlvdvC4tbC5Ie7DHk57mZLrin3ZFjXNjIcG FMgiRT5HI7oxpvIGxi/zl61dJp314Edi4yMmL4Y5QuVebyRx/R/xEf0WxJPCSZtjSD0p Ly76O+VUxlLVTE/lu/T2cNIXUgRbH/l0OEaIMP4q23Oe+mTXGkltI8U8fkYJ6+As/c6F SxZbgj8WSjodeFdAWFlUIa25xKLw8/IIm7Fwqt9in5e//dcNQuCpZ7XL1SsspWVdExkC 2Gyw== X-Gm-Message-State: AJaThX4JqplSK5B/1HxNK8jU37KXkMehFtGoqAK97TMnGbLy1TpFc/9w CRY/Gvaztcx9I1thcznhr/kKVtXc/M2skTtLI2k= X-Google-Smtp-Source: AGs4zMa8oAgKJ++NA+XlHfhSpwOyfoLTU8XUXdZ2khPPEDZjr+k9EVC53sXEGJ2PqgPAHN/ZA4gcTCO67Eo1tMpONpo= X-Received: by 10.55.97.135 with SMTP id v129mr11149261qkb.305.1511628519620; Sat, 25 Nov 2017 08:48:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.193.93 with HTTP; Sat, 25 Nov 2017 08:48:39 -0800 (PST) In-Reply-To: <0D923D70-F9A2-4CB9-A516-B6B80FF4967B@gmail.com> References: <840D255A-5723-4D95-BEF3-50B411A7D0E8@darbyshire-bryant.me.uk> <0D923D70-F9A2-4CB9-A516-B6B80FF4967B@gmail.com> From: Dave Taht Date: Sat, 25 Nov 2017 08:48:39 -0800 Message-ID: To: Pete Heist Cc: Kevin Darbyshire-Bryant , Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] allocate_src allocate_dst X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 16:48:40 -0000 On Sat, Nov 25, 2017 at 8:28 AM, Pete Heist wrote: > >> On Nov 25, 2017, at 3:08 PM, Kevin Darbyshire-Bryant wrote: >> >>> On 25 Nov 2017, at 03:59, Dave Taht wrote: >>> >>> there is no place in the current code base where these are not both >>> true or both false. Thus redundant. >>> >>> ? >> >> Yes, interesting that. Been there since introduced in 5a6da2ba Add trip= le-isolation support. *EXPERIMENTAL* >> >> Have done a PR https://github.com/dtaht/sch_cake/pull/72 with a minor cl= eanup for that - been running on my router with no explosions :-) > > Woah, nice find. I=E2=80=99d been working through that function (looking = at setting srchost_hash and dsthost_hash to a packet mark value for custom = isolation) and between the gotos and ifdefs for kernel version support, it = takes some work to look at it. > > Could this function be refactored a bit for readability? I=E2=80=99d offe= r to do it, but this is an important piece of code with little room for err= or and more ways to plant hard to find problems, better played with by some= one who=E2=80=99s more familiar with it... I am unfond of the gotos as well. But I'm gonna go do laundry. :) If someone else beats me to it? --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619