From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 78CBE3B29E for ; Sun, 5 Apr 2020 14:04:01 -0400 (EDT) Received: by mail-io1-xd2f.google.com with SMTP id y17so11198188iow.9 for ; Sun, 05 Apr 2020 11:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=UuNNXpu74+L8uRQyhFMx9EhnRaFs4WHFAUiwYR7ATf8=; b=syt3GPPWI7Kds+A+EOkxtkCxFA5qC++uAXJkeJt8GonRB+dUOLIqxMSk7S5/7jK2Wi /tF0oHQnPEeZTmdT0vxhEfULKlbTF9Yno0vkuMPyEuY5oipB3VZ5tu06Qnpi/pKGawyb VnCNM+1sPlJWLnepb+sXHgqoOzzW0XCTe+PkRg6aqgfl6U20wcjgW4glEBDLU30vD5gc sEPCIQRbhLOZwgBbHly0LLx8HlwOL3ZOFNZw/2HBOHB6i1i3p8madfch0kpS0YyhpPMs Qh5+JMJLwPFpR9zunKWE0YsHeqDfprBlDojyc3fSYzSbsMZ9NoPeGxK3S7t5y8nPbmVo 7hhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=UuNNXpu74+L8uRQyhFMx9EhnRaFs4WHFAUiwYR7ATf8=; b=jBhaA3uvBoh1VRQyiVI+sO8zmO1sj3f84f6qokZRGBDAIH/nasXdXHweKYIObF8j7D MJheCKqmoGXbOlNQeOf0y2kzmTtx6G3m1tw/ANLGeEYqlXKZErA0jmPWA8plBnio8ITJ Bvj0DR3NrW2Fgb96XmODXvvzuDSbIOer1V5kV8CFy0UZA6pf2Met5I9URNrmS1XUcDVT 6WavGItOMQqIQKpoJI2AnJiEd07BLD7dVJaf/Juth9LBKTJ9l8Utbngg8br7lQCVJH6w zRUNGje7YmsoeTUfrUcQnChS14VeXFC8NlLJ9GkSZQ7/UDfDYpj6Ecn8/nQDVp38HTD8 Q9lw== X-Gm-Message-State: AGi0PuZ74C3VY66VyrMu5GlRX535ypxSRqMxKB/7XWoI35W6TwBpf7U/ 6L8SUWCGL1EzLqcN37R48/vt5DzWFE5s1CFlJ+jO/haHvcg= X-Google-Smtp-Source: APiQypKGLiHw/ZoCI32yi/boBnsbA/NoF0YrdBDG8HVF2kkkWSyN+XJ3h6EDyQhwWVL2ox0q3+FQ0Zb72Syr9S6glSI= X-Received: by 2002:a02:cd03:: with SMTP id g3mr2157202jaq.61.1586109840946; Sun, 05 Apr 2020 11:04:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Taht Date: Sun, 5 Apr 2020 11:03:48 -0700 Message-ID: To: Kevin Darbyshire-Bryant Cc: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] cake and nat in openwrt... on by default? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2020 18:04:01 -0000 https://www.reddit.com/search/?q=3Dbufferbloat&t=3Dweek anyway I posted a PSA. Grump. it looks like comment threads are not unified across forums. https://www.reddit.com/r/HomeNetworking/comments/fvhr4w/psa_sqm_cake_nat_an= d_bufferbloat_tuning/ I do wish our mailing lists showed up on google searches. On Sun, Apr 5, 2020 at 8:22 AM Dave Taht wrote: > > On Sun, Apr 5, 2020 at 12:57 AM Kevin Darbyshire-Bryant > wrote: > > > > > > > > > On 5 Apr 2020, at 05:17, Dave Taht wrote: > > > > > > I see cake is moving to the upstreamed version. As best as I recall, > > > nat mode was on by default in the openwrt code, but not the upstreame= d > > > code. > > > > > > People not setting nat mode on would explain a few things i've seen > > > 'round the intertubes this week. > > > > From sch_cake repo and hence =E2=80=98out of tree=E2=80=99 cake > > > > if (tb[TCA_CAKE_NAT]) { > > #if IS_REACHABLE(CONFIG_NF_CONNTRACK) > > q->flow_mode &=3D ~CAKE_FLOW_NAT_FLAG; > > q->flow_mode |=3D CAKE_FLOW_NAT_FLAG * > > !!nla_get_u32(tb[TCA_CAKE_NAT]); > > #else > > #if LINUX_VERSION_CODE >=3D KERNEL_VERSION(4, 16, 0) > > NL_SET_ERR_MSG_ATTR(extack, tb[TCA_CAKE_NAT], > > "No conntrack support in kernel"); > > #endif > > return -EOPNOTSUPP; > > #endif > > } > > > > > > From kernel 5.4 as found in openwrt build dir > > > > if (tb[TCA_CAKE_NAT]) { > > #if IS_ENABLED(CONFIG_NF_CONNTRACK) > > q->flow_mode &=3D ~CAKE_FLOW_NAT_FLAG; > > q->flow_mode |=3D CAKE_FLOW_NAT_FLAG * > > !!nla_get_u32(tb[TCA_CAKE_NAT]); > > #else > > NL_SET_ERR_MSG_ATTR(extack, tb[TCA_CAKE_NAT], > > "No conntrack support in kernel"); > > return -EOPNOTSUPP; > > #endif > > > > > > > > cake_init(=E2=80=A6) in both does: > > > > q->flow_mode =3D CAKE_FLOW_TRIPLE; > > > > > > So openwrt doesn=E2=80=99t, by default, enable NAT mode in cake. > > > > I honestly don=E2=80=99t think that there are enough instances of cake = out there, let alone instances of cake from openwrt, let alone instances of= cake from master which switched to upstream cake 2-3 days ago, to make any= sort of difference anyway. > > I'd still be willing to bet, then, that the majority of instances were > not turning nat mode on, when > they should have been. > > > > > > > > > -- > > > Make Music, Not War > > > > > > Dave T=C3=A4ht > > > CTO, TekLibre, LLC > > > http://www.teklibre.com > > > Tel: 1-831-435-0729 > > > _______________________________________________ > > > Cake mailing list > > > Cake@lists.bufferbloat.net > > > https://lists.bufferbloat.net/listinfo/cake > > > > > > Cheers, > > > > Kevin D-B > > > > gpg: 012C ACB2 28C6 C53E 9775 9123 B3A2 389B 9DE2 334A > > > > > -- > Make Music, Not War > > Dave T=C3=A4ht > CTO, TekLibre, LLC > http://www.teklibre.com > Tel: 1-831-435-0729 --=20 Make Music, Not War Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-435-0729