Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Cake List <cake@lists.bufferbloat.net>
Subject: [Cake] Fwd: [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection
Date: Mon, 30 Jul 2018 09:43:11 -0700	[thread overview]
Message-ID: <CAA93jw6+G8dTpDipT-hpTOf5MZK4ON_3O7TBJQ94VeHVoPwpWg@mail.gmail.com> (raw)
In-Reply-To: <20180730.093137.1779408128002483955.davem@davemloft.net>

I hope this shows up as an inbound shaping improvement for us.
skb_clone was *expensive*

---------- Forwarded message ---------
From: David Miller <davem@davemloft.net>
Date: Mon, Jul 30, 2018 at 9:32 AM
Subject: Re: [PATCH net-next v5 0/4] TC: refactor act_mirred packets
re-injection
To: <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>, <jhs@mojatatu.com>,
<xiyou.wangcong@gmail.com>, <jiri@resnulli.us>,
<daniel@iogearbox.net>, <marcelo.leitner@gmail.com>,
<eyal.birger@gmail.com>


From: Paolo Abeni <pabeni@redhat.com>
Date: Mon, 30 Jul 2018 14:30:41 +0200

> This series is aimed at improving the act_mirred redirect performances.
> Such action is used by OVS to represent TC S/W flows, and it's current largest
> bottle-neck is the need for a skb_clone() for each packet.
>
> The first 2 patches introduce some cleanup and safeguards to allow extending
> tca_result - we will use it to store RCU protected redirect information - and
> introduce a clear separation between user-space accessible tcfa_action
> values and internal values accessible only by the kernel.
> Then a new tcfa_action value is introduced: TC_ACT_REINJECT, similar to
> TC_ACT_REDIRECT, but preserving the mirred semantic. Such value is not
> accessible from user-space.
> The last patch exploits the newly introduced infrastructure in the act_mirred
> action, to avoid a skb_clone, when possible.
>
> Overall this the above gives a ~10% performance improvement in forwarding tput,
> when using the TC S/W datapath.
 ...

Series applied, thank you.


-- 

Dave Täht
CEO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-669-226-2619

           reply	other threads:[~2018-07-30 16:43 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20180730.093137.1779408128002483955.davem@davemloft.net>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw6+G8dTpDipT-hpTOf5MZK4ON_3O7TBJQ94VeHVoPwpWg@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox