From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x232.google.com (mail-qt0-x232.google.com [IPv6:2607:f8b0:400d:c0d::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D4AB43B29E for ; Mon, 30 Jul 2018 12:43:23 -0400 (EDT) Received: by mail-qt0-x232.google.com with SMTP id t5-v6so12774840qtn.3 for ; Mon, 30 Jul 2018 09:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=1cCVRhVer5zApb8S7pRBIJvX8QaIyZtqN2XqQBo7QP4=; b=RakZW2cHhAwjoXqS66iKTIYqb6RbcFzVJjLPCllAkCYxce+x5UdPbnRk3tyI03kqsL j1fLD+/y4nV8V2u4v7RIo2vQ1jPAEOMJDXqoRxCLz3d270usMCRDepLyZFBY0Adb0gA7 xrSnaL6cfxb4m46E1mpUeChDvmEHpIH8fPHQsxy4J/j5JyfmGSU3s4A2l7N8WQhkSoLN cAMCeyZs8FC6gW36bd584fHEBtEYLMhDB3nu6/qo+esJtnYA2VzPFpUpESM7lRhntpXZ AD6m08CUfWvckZQu0O0TfgP1G0H0b3j/pnCK7dTeKENrpPPYcp+J0cijvnuI0920zsmI E2oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=1cCVRhVer5zApb8S7pRBIJvX8QaIyZtqN2XqQBo7QP4=; b=DNUUWb+w6EeFdI6OmNvpnCaxmUAa1dQYDWInMLoKEPD7nhJhkvHmgRDgkUzjRtW2va xfmGU7lHpPW2jxkoiy+lLCE896DWGA9GSNq5hwjo00NWDCjiV5av+zN/St6GOF4RftGn GitBU7jvMa7EOjT0RrL0rqtbi8mPJ+TOjyMFza8dhkf5VSCV8+QwqNNnBt0V2B6pk1Cp JEbXh4nA/SI3bOrCslMMrxRHNl4qjZ3BXeGxJZXNGnATf+3wHCmXdnP+/dCBYqU3uNln Zy4ZoR22vo2NGWLpdunytB9gIpWA6OQZP6wELlV0hy1a5y9IC8j7MswdwkZto+cRGYF2 Dj5w== X-Gm-Message-State: AOUpUlH2fw7YM0iFL42OT+0ZVRQNuRllX/6YthW0n615+0lf4J4JQN8j sFw+Pp16XY0mFuncfoK0nC84Ak7nhQvqciawMrPSuw== X-Google-Smtp-Source: AAOMgpceJtaEvynDP6ULQlEiiUyt9FSbNeLXwFX516EnYeWHvOa395PYTGPua8egRTbXm9ovrK264MdPNy6+vYZj02s= X-Received: by 2002:a0c:9e5a:: with SMTP id z26-v6mr15859533qve.15.1532969002943; Mon, 30 Jul 2018 09:43:22 -0700 (PDT) MIME-Version: 1.0 References: <20180730.093137.1779408128002483955.davem@davemloft.net> In-Reply-To: <20180730.093137.1779408128002483955.davem@davemloft.net> From: Dave Taht Date: Mon, 30 Jul 2018 09:43:11 -0700 Message-ID: To: Cake List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Cake] Fwd: [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 16:43:23 -0000 I hope this shows up as an inbound shaping improvement for us. skb_clone was *expensive* ---------- Forwarded message --------- From: David Miller Date: Mon, Jul 30, 2018 at 9:32 AM Subject: Re: [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection To: Cc: , , , , , , From: Paolo Abeni Date: Mon, 30 Jul 2018 14:30:41 +0200 > This series is aimed at improving the act_mirred redirect performances. > Such action is used by OVS to represent TC S/W flows, and it's current la= rgest > bottle-neck is the need for a skb_clone() for each packet. > > The first 2 patches introduce some cleanup and safeguards to allow extend= ing > tca_result - we will use it to store RCU protected redirect information -= and > introduce a clear separation between user-space accessible tcfa_action > values and internal values accessible only by the kernel. > Then a new tcfa_action value is introduced: TC_ACT_REINJECT, similar to > TC_ACT_REDIRECT, but preserving the mirred semantic. Such value is not > accessible from user-space. > The last patch exploits the newly introduced infrastructure in the act_mi= rred > action, to avoid a skb_clone, when possible. > > Overall this the above gives a ~10% performance improvement in forwarding= tput, > when using the TC S/W datapath. ... Series applied, thank you. --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619