From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x233.google.com (mail-oi0-x233.google.com [IPv6:2607:f8b0:4003:c06::233]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 4DB2221F986 for ; Tue, 29 Sep 2015 04:10:52 -0700 (PDT) Received: by oibi136 with SMTP id i136so1659268oib.3 for ; Tue, 29 Sep 2015 04:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=zgOo1xgxfoZDLqjMjB0UFGtR4/QSdDMTZLUqIelZ7jY=; b=GdDSenIhSw9q0N+dZrasvDVGfJWMn8tFUlbPtDzhTTcO0omtqwcrgaXmrLsF/lFcgL 5KZmLq+0oaTdBCF/VfDmkdSYr4k6/nbz7VD5RujarPmjbWxQAt9W6ApxY/cjha7BwmBJ 7XegIjBaZmqYh1HOKRQeqlrq0jEw46AZf9ErvswixNcBTJKgbv3f5G99jDA+7eBZwOpm lE6FeFXkmD8QSan6A+eJAWPMWHDgMQdTTE2TUmY7YyBOdXrh1le7CPOdzsCMYm/Yax2z NlcgVlBk14NBHpg4A8+dxC80DocIHl6bJlZdL7kGIR7F8LOXjNkcccUH9dLozDcySN4y CKQw== MIME-Version: 1.0 X-Received: by 10.202.45.9 with SMTP id t9mr13424822oit.75.1443525051934; Tue, 29 Sep 2015 04:10:51 -0700 (PDT) Received: by 10.202.108.212 with HTTP; Tue, 29 Sep 2015 04:10:51 -0700 (PDT) In-Reply-To: References: <56092A0F.3060108@darbyshire-bryant.me.uk> <560969FC.3040107@darbyshire-bryant.me.uk> <560A5D19.3000405@darbyshire-bryant.me.uk> Date: Tue, 29 Sep 2015 04:10:51 -0700 Message-ID: From: Dave Taht To: Kevin Darbyshire-Bryant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Update kernel version check in cake X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2015 11:11:15 -0000 I added support for squashing to both sch_cake and tc-adv repos. Sort of compile tested only. (my laptop's kernel is 3.16 and doesn't build, my virtuals in linode do not come with kernel sources, snapon crashed two weeks ago, and so on) but it was nice to write a few lines of code, knowing that someone here will fix 'em if I broke something. On Tue, Sep 29, 2015 at 2:55 AM, Dave Taht wrote: > On Tue, Sep 29, 2015 at 2:42 AM, Kevin Darbyshire-Bryant > wrote: >> >> >> On 29/09/15 00:01, Jonathan Morton wrote: >>> >>> I actually had the version check fix locally, but for some reason it >>> hadn't been picked up by a push yet. >>> >> Yep, I have those moments. Just when I think I've got git sussed it >> goes and does something completely logical but totally unexpected :-) >>> >>> Squashing would involve writing to the TOS byte, which is already done >>> by ECN marking, via a helper function. >>> >> Ah, so if I can work out how that's done I'm 50% of the way there. >> Should keep me amused for a few days. >>> >>> I tried removing the cow stuff once before. Everything promptly >>> stopped working until I put it back. I have no idea why. >>> >> Well here's interesting. I got brave and put my suggested change into >> action. So far: 1) router not blown up 2) tc -s still shows traffic in >> different Classes (Dave, I prefer your term 'Bin' here too - I >> considered 'Bucket' for a laugh) which suggests the reading of ip_hdr is >> still working. 3) This hasn't been thoroughly tested in any way >> whatsoever but i've tried diffserv4 & besteffort and both don't appear >> broken. > > I agree with bin. Wouldn't mind it if that made it into the variable > name instead of class. > >> Pull request: https://github.com/dtaht/sch_cake/pull/6 > > It would be my hope also that killing the cow would speed it up. > > Untested by me, but pulled. > > >> Kevin >>> >>> - Jonathan Morton >>> >> >> > > > > -- > Dave T=C3=A4ht > Do you want faster, better, wifi? https://www.patreon.com/dtaht --=20 Dave T=C3=A4ht Do you want faster, better, wifi? https://www.patreon.com/dtaht