Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>,
	cake@lists.bufferbloat.net
Subject: Re: [Cake] BUG_ON vs WARN_ON
Date: Wed, 5 Oct 2016 09:38:19 -0700	[thread overview]
Message-ID: <CAA93jw6CLtYQw+3OH48PUqD+-vSd-Uiuu-KY5X_yYBe5cSvCZg@mail.gmail.com> (raw)
In-Reply-To: <4F964B3B-632D-44DA-8601-F498B21AC7A8@gmail.com>

I cannot repeat that result this morning, with either replace or
change. I *was* running far more extensive tests between changing
things that way than I just did, but a string of quick tests, changing
the bandwidth, changing it to unlimited, etc got the correct behaviors
throughout for both replace and change. But, changing it to 50mbit
shows the capacity estimate here to still be 700Mbit.

d@apu2:~$ tc -s qdisc show dev enp2s0

qdisc cake 800f: root refcnt 9 bandwidth 50Mbit diffserv4 flows rtt 100.0ms raw

 Sent 7573781243 bytes 5002790 pkt (dropped 6, overlimits 1270728
requeues 19055)

 backlog 0b 0p requeues 19055

 memory used: 729504b of 4Mb

 capacity estimate: 700Mbit

                 Bulk   Best Effort      Video       Voice

  thresh      3125Kbit      50Mbit      25Mbit   12500Kbit

  target         5.8ms       5.0ms       5.0ms       5.0ms

  interval     100.8ms     100.0ms     100.0ms     100.0ms

  pk_delay         0us       4.6ms         1us        69us

  av_delay         0us       3.2ms         0us         4us

  sp_delay         0us         5us         0us         3us

  pkts               0     2991920           1          89

  bytes              0  4529561380          90       26451

  way_inds           0           0           0           0

  way_miss           0          38           1           2

  way_cols           0           0           0           0

  drops              0           6           0           0

  marks              0           0           0           0

  sp_flows           0           0           0           0

  bk_flows           0           0           0           1

  un_flows           0           0           0           0

  max_len            0       19682          90         927


I am still not seeing the number of drops I would expect in the cake
statistics. 4 with 4 flows going at 50mbit on a 30 second test doesn't
strike me as enough. I will do a capture later to see if they add up.

That said, I did have to patch out on this particular kernel, this:

Linux apu2 4.5.0-fqmac3.5-wt-ath # yes, I'm running 3 kernels behind mainline.


diff --git a/sch_cake.c b/sch_cake.c

index f613ab4..92c5078 100644

--- a/sch_cake.c

+++ b/sch_cake.c

@@ -64,7 +64,7 @@

 #endif



 #if (KERNEL_VERSION(4,4,11) > LINUX_VERSION_CODE) ||
((KERNEL_VERSION(4,5,0) <= LINUX_VERSION_CODE) &&
(KERNEL_VERSION(4,5,5) > LINUX_VERSION_CODE))

-#define qdisc_tree_reduce_backlog(_a,_b,_c) qdisc_tree_decrease_qlen(_a,_b)

+// #define qdisc_tree_reduce_backlog(_a,_b,_c) qdisc_tree_decrease_qlen(_a,_b)

 #endif

  reply	other threads:[~2016-10-05 16:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 15:24 Kevin Darbyshire-Bryant
2016-10-05 15:42 ` Jonathan Morton
2016-10-05 15:45   ` Kevin Darbyshire-Bryant
2016-10-05 15:53     ` Jonathan Morton
2016-10-05 18:53       ` Jonathan Morton
2016-10-07 13:27         ` Kevin Darbyshire-Bryant
2016-10-07 13:35           ` Jonathan Morton
2016-10-07 13:43             ` Kevin Darbyshire-Bryant
2016-10-05 15:53     ` Dave Taht
2016-10-05 15:55       ` Kevin Darbyshire-Bryant
2016-10-05 15:57         ` Jonathan Morton
2016-10-05 16:38           ` Dave Taht [this message]
2016-10-06  3:59             ` Kevin Darbyshire-Bryant
2016-10-06  4:19               ` Dave Taht
2016-10-06  8:12                 ` Jonathan Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw6CLtYQw+3OH48PUqD+-vSd-Uiuu-KY5X_yYBe5cSvCZg@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    --cc=kevin@darbyshire-bryant.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox