From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D46633B25E for ; Wed, 5 Oct 2016 12:38:19 -0400 (EDT) Received: by mail-qk0-x242.google.com with SMTP id j129so13619263qkd.2 for ; Wed, 05 Oct 2016 09:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=swWfnebiwsxTCTAkFcKzti0R7V4ognN/K1OBSKOasyE=; b=dNtWmLkOfg9VA+FGKnezwQXszjufX1AVMiI7qMCDMgiB1aK94eYJnBNfvkztr8cS1o wUa4EWPO7qA55XLa+FaFxMby1tdWkDE2355B352xxQjKYzpO4gGknjb9X3VzNTA3S+rc 6hAzInn4Odbtr8Bknni6w7OMSLSAcsEXY/0jO2gki3Tf9kr50SnQsEGFCLth0hZ3p6WT Ake0JpCaEwokdVUvHeW6YffnZQmmzwdbpC9G5JejDqllSkqGwyr4vLpoNSf5jYo+6XWi 1xGvW5VkkIYuXA8VNQtvBo6ar4g3pK3TuErmElPc2IYzrWie8Af6AbXjWFGGcZejgXfu h/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=swWfnebiwsxTCTAkFcKzti0R7V4ognN/K1OBSKOasyE=; b=ND5qWlBJNQmeIswMUeCqhD1o1u4hEw+phb0wWn7MPb/32SSY4reYtP8JIEXRilPxWp A0vIrVs7kTUI41Y7sj7d/RhyvZEA1r/M217q8xGTUNNzEmDzWfk3TtWrCGGb9IKXsii+ WfpnW/X/5QjmlDg10BVPCSJgSotajHB0O1JNoGMuz8bIWZQBirDhuZfICNrbfTlhca3R IeoUAeFHsUD1qQoYgRT1MqW75tlMBu7LFbP2r3rfKQfPMhJ6Asv1L7YvhpdK9G3Z+73s SpRI4TW1u4kqq6wBxAQB9LTEG0FJiLwgzs6pwo5JHnfzowrlfZXI87/UJgoL95+XJdlI bj5g== X-Gm-Message-State: AA6/9RnhkfuYzcwo6CBGhkEuDEV7A2F4MbY0yQ0EDZa+G09LRHB1+ctC1jtdjpu/CRLkhBgKiop5/UAIzrr+lA== X-Received: by 10.55.69.72 with SMTP id s69mr9820153qka.153.1475685499487; Wed, 05 Oct 2016 09:38:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.146.164 with HTTP; Wed, 5 Oct 2016 09:38:19 -0700 (PDT) In-Reply-To: <4F964B3B-632D-44DA-8601-F498B21AC7A8@gmail.com> References: <70363372-13a0-a88f-840e-b8e10c685ed7@darbyshire-bryant.me.uk> <451e7412-2f27-1421-1bd6-ac2ef45f4cd8@darbyshire-bryant.me.uk> <4F964B3B-632D-44DA-8601-F498B21AC7A8@gmail.com> From: Dave Taht Date: Wed, 5 Oct 2016 09:38:19 -0700 Message-ID: To: Jonathan Morton Cc: Kevin Darbyshire-Bryant , cake@lists.bufferbloat.net Content-Type: text/plain; charset=UTF-8 Subject: Re: [Cake] BUG_ON vs WARN_ON X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 16:38:19 -0000 I cannot repeat that result this morning, with either replace or change. I *was* running far more extensive tests between changing things that way than I just did, but a string of quick tests, changing the bandwidth, changing it to unlimited, etc got the correct behaviors throughout for both replace and change. But, changing it to 50mbit shows the capacity estimate here to still be 700Mbit. d@apu2:~$ tc -s qdisc show dev enp2s0 qdisc cake 800f: root refcnt 9 bandwidth 50Mbit diffserv4 flows rtt 100.0ms raw Sent 7573781243 bytes 5002790 pkt (dropped 6, overlimits 1270728 requeues 19055) backlog 0b 0p requeues 19055 memory used: 729504b of 4Mb capacity estimate: 700Mbit Bulk Best Effort Video Voice thresh 3125Kbit 50Mbit 25Mbit 12500Kbit target 5.8ms 5.0ms 5.0ms 5.0ms interval 100.8ms 100.0ms 100.0ms 100.0ms pk_delay 0us 4.6ms 1us 69us av_delay 0us 3.2ms 0us 4us sp_delay 0us 5us 0us 3us pkts 0 2991920 1 89 bytes 0 4529561380 90 26451 way_inds 0 0 0 0 way_miss 0 38 1 2 way_cols 0 0 0 0 drops 0 6 0 0 marks 0 0 0 0 sp_flows 0 0 0 0 bk_flows 0 0 0 1 un_flows 0 0 0 0 max_len 0 19682 90 927 I am still not seeing the number of drops I would expect in the cake statistics. 4 with 4 flows going at 50mbit on a 30 second test doesn't strike me as enough. I will do a capture later to see if they add up. That said, I did have to patch out on this particular kernel, this: Linux apu2 4.5.0-fqmac3.5-wt-ath # yes, I'm running 3 kernels behind mainline. diff --git a/sch_cake.c b/sch_cake.c index f613ab4..92c5078 100644 --- a/sch_cake.c +++ b/sch_cake.c @@ -64,7 +64,7 @@ #endif #if (KERNEL_VERSION(4,4,11) > LINUX_VERSION_CODE) || ((KERNEL_VERSION(4,5,0) <= LINUX_VERSION_CODE) && (KERNEL_VERSION(4,5,5) > LINUX_VERSION_CODE)) -#define qdisc_tree_reduce_backlog(_a,_b,_c) qdisc_tree_decrease_qlen(_a,_b) +// #define qdisc_tree_reduce_backlog(_a,_b,_c) qdisc_tree_decrease_qlen(_a,_b) #endif