From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x22c.google.com (mail-qk0-x22c.google.com [IPv6:2607:f8b0:400d:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 412CE3BA8E for ; Sat, 28 Jul 2018 13:53:06 -0400 (EDT) Received: by mail-qk0-x22c.google.com with SMTP id o2-v6so5364512qkc.13 for ; Sat, 28 Jul 2018 10:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HcZt/anve4iqduTi6LtWeB2jnW262EwR1wXuEqQITZE=; b=n/qwTTl0DBwby7mdgSnFVXE+ZdA51lwiCU6K/eCGIApM3t6i5kc6NPZVYGrrLQMX3z NRl7BTTtiFfZsAr8KI+4JugDKPmW5rezleKA8ZV/VDE2sQ7liSRkG+1GVGkBYz7YN8Jx sBdE7Cch4CRc7R6LfWKT343rE2ZYv0g5d7amWZ1/wQUfKHlZk+hpbpua23UvByKSi0nu JLNQ5mKIOW9eLxhDy4gEilaxvHwMEQy9/r2iq9xeG1bunGdRfc4yy0YwyVVJtw1AJJvZ xFpJcL5E8kplgCq5Gmnw+YQGqEnCTSl+xWFw9+v2i1588If0/HPRVInDWl0p+ufHQl9y yufA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HcZt/anve4iqduTi6LtWeB2jnW262EwR1wXuEqQITZE=; b=XWViTGdujwETOoBkU9KWLlfohdSEEH0wnFBVDkGrFZFbrk9EUKlpGw9U2/48m4MoCa cpQFljbzYME86FCR808W7Xx94jCifLieffOwDFyxEy5CmtwZk+KxcdMBM7dpVY52zPGl Xz7oOn6wysN6KMneBwpcqtjpd9od9+2XUhfT4UwRIlnWR8ePdmxzALgtvSby3k4v/ak2 a4Rpru8RfOCTByL3Ofcp2VEgpvRPgPdLzvEa87/59MXx1n88y7QK4p2FVVoxsMJrxAG3 2SNXqwsuBL+jZOktBYo/AbOkoQ//ow6kZeVEhTvoSM/kbMyc8svAetWLqdLA6vK24B2v maSg== X-Gm-Message-State: AOUpUlFII8F4aIYvBuklPukj8+oRtj15L2yspLaoQ0IYZxHHwV06Xf5V lNy359Cgslq3B76ysayHow/FZ6gGHqna1UI50XE= X-Google-Smtp-Source: AAOMgpevG0Mn13xVQp4LOLvdoV2jyOHowMyvwnd8Zpn67rVEvSWsvsCd7+Yna8FsEdtvmH9bFAn6l6s21/DLGQEXA0U= X-Received: by 2002:a37:4d1:: with SMTP id 200-v6mr9873850qke.35.1532800385799; Sat, 28 Jul 2018 10:53:05 -0700 (PDT) MIME-Version: 1.0 References: <1357421162.31089.1531812291583@webmail.strato.de> <1c323544b3076c0ab31b887d6113f25f572e41ae.camel@coverfire.com> <87woth28rw.fsf@toke.dk> <87tvol1z6h.fsf@toke.dk> <87wotfzql8.fsf@toke.dk> In-Reply-To: From: Dave Taht Date: Sat, 28 Jul 2018 10:52:53 -0700 Message-ID: To: Pete Heist Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Cake List Content-Type: multipart/mixed; boundary="0000000000008202e8057212e6ec" Subject: Re: [Cake] =?utf-8?q?Using_cake_to_shape_1000=E2=80=99s_of_users=2E?= X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2018 17:53:06 -0000 --0000000000008202e8057212e6ec Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jul 28, 2018 at 10:38 AM Pete Heist wrote: > > > On Jul 28, 2018, at 10:56 AM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > Note that with the existing tc classifier stuff we already added to > Cake, we basically have this already (eBPF can map traffic to tin and > flow however it pleases). > > > Sorry, this just jostled in my brain now that I may be able to implement = member fairness today, based on what you wrote earlier in a thread that I e= ntirely missed: https://lists.bufferbloat.net/pipermail/cake/2018-May/00381= 1.html > > George posted an example of assigning packets to a tin: https://lists.buf= ferbloat.net/pipermail/cake/2018-May/003809.html > > How does one send packets to a specific flow / queue? It's essentially above. I think you can actually do it in pure bpf without skbedit, I'd written a tc bpf flow classifier for acks quite some time ago. The not current version is attached. I really need to finish up some ack related stuff. Using a bpf map to this then setting the flowid directly? > This wouldn=E2=80=99t give both per-member and per-flow fairness, but at = least per-member fairness might be possible. There are 1024(?) queues avail= able and 800 members, so I=E2=80=99m just speculating that I could map memb= ers to a number from 0 to 800 (active member IDs packed and zero-based woul= d work) and assign each member to their own flow. Thanks... :) > > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake -- Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619 --0000000000008202e8057212e6ec Content-Type: application/octet-stream; name="ack_recognise.c" Content-Disposition: attachment; filename="ack_recognise.c" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jk5ppnb40 LyogYWNrX3JlY29nbmlzZXI6IEFuIGVCUEYgcHJvZ3JhbSB0aGF0IGNvcnJlY3RseSByZWNvZ25p c2VzIG1vZGVybiBUQ1AgQUNLcywKICAgd2l0aCB0Y3Agb3B0aW9uIGZpZWxkcy4KICovCgojaW5j bHVkZSAiYnBmX2FwaS5oIgojaW5jbHVkZSAidWFwaS9saW51eC9pZl9ldGhlci5oIgojaW5jbHVk ZSAidWFwaS9saW51eC9pcC5oIgojaW5jbHVkZSAidWFwaS9saW51eC9pbi5oIgovLyAjaW5jbHVk ZSAidWFwaS9saW51eC9pcHY2LmgiIC8vIGlwcm91dGUyIGRvZXNuJ3QgaW1wb3J0IHRoaXMgaGVh ZGVyCiNpbmNsdWRlICJ1YXBpL2xpbnV4L3RjcC5oIgoKLyogSWRlYWxpemVkIHN5bnRheCBleGFt cGxlIHRvIG1vdmUgYWNrcyBpbnRvIGEgcHJpb3JpdHkgcXVldWU6Cgp0YyBxZGlzYyBkZWwgZGV2 ICRJRkFDRSByb290IDI+IC9kZXYvbnVsbAp0YyBxZGlzYyBhZGQgZGV2ICRJRkFDRSByb290IGhh bmRsZSAxOiBwcmlvIGJhbmRzIDMgcHJpb21hcCAxIDEgMSAxIDEgMSAxIDEgMSAxIDEgMSAxIDEg MSAxCnRjIHFkaXNjIGFkZCBkZXYgJElGQUNFIHBhcmVudCAxOjEgaGFuZGxlIDEwOjEgZnFfY29k ZWwKdGMgcWRpc2MgYWRkIGRldiAkSUZBQ0UgcGFyZW50IDE6MiBoYW5kbGUgMjA6MSBmcV9jb2Rl bAp0YyBxZGlzYyBhZGQgZGV2ICRJRkFDRSBwYXJlbnQgMTozIGhhbmRsZSAzMDoxIGZxX2NvZGVs Cgp0YyBmaWx0ZXIgYWRkIGRldiAkSUZBQ0UgIHByaW8gMSBicGYgb2JqZWN0LWZpbGUgYWNrX3Jl Y29nbmlzZS5vIGRhIGFja19tYXRjaCBmbG93aWQgMTA6MSAjIDE6MT8KCiovCgovKiBBIHB1cmUg YWNrIGNvbnRhaW5zIHRoZSBpcCBoZWFkZXIsIHRoZSB0Y3AgaGVhZGVyICsgb3B0aW9ucywgZmxh Z3Mgd2l0aCB0aGUKICogYWNrIGZpZWxkIHNldCwgYW5kIG5vIGFkZGl0aW9uYWwgcGF5bG9hZC4g VGhhdCBsYXN0IGJpdCBpcyB3aGF0IGV2ZXJ5IHByaW9yCiAqIGFjayBmaWx0ZXIgZ2V0cyB3cm9u ZywgdGhleSB0eXBpY2FsbHkgYXNzdW1lIGFuIG9ic29sZXRlIDY0IGJ5dGVzLgogKi8KCl9fc2Vj dGlvbl9jbHNfZW50cnkKaW50IGFja19tYXRjaChzdHJ1Y3QgX19za19idWZmICpza2IpCnsKCXZv aWQgKmRhdGEgPSAodm9pZCAqKShsb25nKXNrYi0+ZGF0YTsKCXZvaWQgKmRhdGFfZW5kID0gKHZv aWQgKikobG9uZylza2ItPmRhdGFfZW5kOwoJc3RydWN0IGV0aGhkciAqZXRoID0gZGF0YTsKCXN0 cnVjdCBpcGhkciAqaXBoID0gZGF0YSArIHNpemVvZigqZXRoKTsKCXN0cnVjdCB0Y3BoZHIgKnRj cDsKCWludCBsZW4sIGlzaXplOwoKCWlmIChkYXRhICsgc2l6ZW9mKCpldGgpICsgc2l6ZW9mKCpp cGgpICsgc2l6ZW9mKCp0Y3ApID4gZGF0YV9lbmQpCgkJcmV0dXJuIDA7CgoJaWYgKGV0aC0+aF9w cm90byAhPSBodG9ucyhFVEhfUF9JUCkpCgkJcmV0dXJuIDA7CgoJaWYgKGlwaC0+dmVyc2lvbiA9 PSA0KSB7CgkJaWYoaXBoLT5wcm90b2NvbCAhPSBJUFBST1RPX1RDUCkKCQkJcmV0dXJuIDA7CgkJ bGVuID0gaXBoLT50b3RfbGVuOyAvLyBodG9ucz8KCQlpZihpcGgtPmlobCA+IDQpIHsKCQkJaXNp emUgPSAoaXBoLT5paGwrMSkgKiA0IC0gc2l6ZW9mKCppcGgpOwoJCQl0Y3AgPSBkYXRhICsgc2l6 ZW9mKCpldGgpICsgaXNpemU7CgkJfSBlbHNlIHsKCQkJcmV0dXJuIDA7CgkJfQovKiBncnVtcDog aXByb3V0ZTIgZG9lcyBub3QgZXhwb3J0IGlwNmhkcnMKCX0gZWxzZSAgaWYgKGlwaC0+dmVyc2lv biA9PSA2KSB7CgkJc3RydWN0IGlwdjZoZHIgaXBoNiA9IChzdHJ1Y3QgaXB2NmhkciAqKSBpcGg7 Ci8vIEZJWE1FOiB3YWxrIGlwNmhkcnMgYXBwcm9wcmlhdGVseQoJCWlmKGlwaDYtPm5leHRoZHIg IT0gSVBQUk9UT19UQ1ApCgkJCXJldHVybiAwOwoJCWxlbiA9IGlwaDYtPnBheWxvYWRfbGVuOwoJ CWlzaXplID0gc2l6ZW9mKCppcGg2KSArID8/OwoJCXRjcCA9IGRhdGEgKyBzaXplb2YoKmV0aCkg KyBpc2l6ZTsKCQkqLwoJfSBlbHNlCgkJcmV0dXJuIDA7CgoJaWYgKCF0Y3AtPmFjaykgcmV0dXJu IDA7CgoJaWYgKGlzaXplICsgc2l6ZW9mKCp0Y3ApICsgdGNwLT5kb2ZmKjQgPT0gbGVuKQoJCXJl dHVybiAtMTsgLy8gV2UgbWF0Y2hlZCwgcmV0dXJuIFRDX0FDVF9SRUNMQVNTSUZZPwoKCXJldHVy biAwOwp9CgpjaGFyIF9fbGljZW5zZVtdIF9fc2VjdGlvbigibGljZW5zZSIpID0gIkdQTCI7Cg== --0000000000008202e8057212e6ec--