From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-x229.google.com (mail-qt0-x229.google.com [IPv6:2607:f8b0:400d:c0d::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 04FD83CB3B for ; Thu, 22 Dec 2016 14:43:56 -0500 (EST) Received: by mail-qt0-x229.google.com with SMTP id c47so244107380qtc.2 for ; Thu, 22 Dec 2016 11:43:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=Kzm0ApRlIIIPItPpsnzmDZ6MlbIjxB2eizHYz2kXm/E=; b=vX3Qi1uSowSTNp/o3hZNNjCXJDsZGYUCkAvo2/FBNgRK4aVekLXJ7nZDfrPwh++6pU UzwW2XYfYjNL54Wpn3X/jxTjpg4yLicExcFpEjxEIPGQXJmsijR129Sc1NH/2sutZ187 xq1qq6ylSdDtwDm29LuCiGniwA1DrWrhnkWoH3WIlGpqsjL3uGm++NRKtVsS5TC5gv7U 9dyYRQqsNwRFmtYB25DCkPoN50v7GPUJ8318kewjC/zK/GhxN0gXE9SODS1r5VeXwA5V M6caf3NQoW+ssTvo+dGLGLIffbmRVAjANxS1BByO6Ze9mKaVs5Fh54mvw4CGNXSq+Esw DShQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=Kzm0ApRlIIIPItPpsnzmDZ6MlbIjxB2eizHYz2kXm/E=; b=Zvi1aSyQNRjP1A8fUSXIUfmdMSRjdvltIxwU7edTfYesr5e7SN7X1S9lJv6KH4Zs2Y 8LgGxUpjpfrMSK2ppKSyHdGR4BxZDPZdXgCTBSSPDgBWHGXnAhkt1jKcXAmXVc/XWsUi OwNWvpZVRY2QItUWGtOA3Wp36C+wFwocE/wGGHUQ0ucfTOskR2HZglRtcYexLhomYwul GaycBqNM72CDYIRGWfB2O5Zno7y8UQTz+CmjzQ+aZkHrVlol9fT7QXtQtfciOP0znBcA nj19nQXSU196lxLIFQS6GBGbziN2GjLjblNhHdex9uiUvPc/jy+9jYCsDBYf9Pj92C1V JKAA== X-Gm-Message-State: AIkVDXJnaTsKMPDQwoptnjOvI5eL6WIhPRm70wa8jmEI/N25LOQ57MPVxl8gn9UzA8ov3Zv/9TGeNHpAGvnOcA== X-Received: by 10.200.34.73 with SMTP id p9mr12983849qtp.25.1482435836537; Thu, 22 Dec 2016 11:43:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.152.197 with HTTP; Thu, 22 Dec 2016 11:43:56 -0800 (PST) From: Dave Taht Date: Thu, 22 Dec 2016 11:43:56 -0800 Message-ID: To: cake@lists.bufferbloat.net, Stephen Hemminger Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Cake] upstreaming cake in 2017? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 19:43:57 -0000 I think most of the reasons why cake could not be upstreamed are now on their way towards being resolved, and after lede ships, I can't think of any left to stop an upstreaming push. Some reasons for not upstreaming were: * Because the algorithms weren't stable enough * Because it wasn't feature complete until last month (denatting, triple-isolate, and a 3 tier sqm) * Because it had to work on embedded products going back to 3.12 or so * Because I was busy with make-wifi-fast - which we got upstream as soon as humanly possible. * Because it was gated on having the large tester base we have with lede (4.4 based) * Because it rather abuses the tc statistics tool to generate tons of stats * Because DSCP markings remain in flux at the ietf * We ignore the packet priority fields entirely * We don't know what diffserv models and ratios truly make sense Anyone got more reasons not to upstream? Any more desirable features? In looking over the sources today I see a couple issues: * usage of // comments and overlong lines * could just use constants for the diffserv lookup tables (I just pushed th= e revised gen_cake_const.c file for the sqm mode, but didn't rip out the relevant code in sch_cake). I note that several of my boxes have 64 hw queues now * I would rather like to retire "precedence" entirely * cake cannot shape above 40Gbit (32 bit setting). Someday +40Gbit is possi= ble * we could split gso segments at quantum rather than always * could use some profiling on x86, arm, and mips arches * Need long RTT tests and stuff that abuses cobalt features * Are we convinced the atm and overhead compensators are correct? * ipv6 nat? * ipsec recognition and prioritization? * I liked deprioritizing ping in sqm-scripts Hardware mq is bugging me - a single queued version of cake on the root qdisc has much lower latency than a bql'd mq with cake on each queue and *almost* the same throughput. --=20 Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org