From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x233.google.com (mail-oi0-x233.google.com [IPv6:2607:f8b0:4003:c06::233]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id D1EFD21FA2D for ; Tue, 13 Oct 2015 04:53:10 -0700 (PDT) Received: by oiao187 with SMTP id o187so7838728oia.2 for ; Tue, 13 Oct 2015 04:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Udybw1xKXk/QxC48i0F4+gcs2EuIBUtb0yrI1uHE54M=; b=fOzZxAExl19EvuTx8xlhNaO3Bhcm/N2RVTef/SIUYfqoQUpf/w/o0XuTCer0d6IjhY /8qq/UfOgOzEB7KmgzON6B0hkGjLwyEe0eknrodcAuz7LIBO8vuYIiw5LTNDnYAElvWQ dOR4hASpQCPz5zW1CcvqSnh/CrNI07LJTuYsFjYSgTl8SHdniLYNfVjdDyAH69CM0EWm pvCmcv/qB7LugUt73Rv6+ah2nhPe9fYPmVoWWNohjm+VUBXc3KkalZDLcWBm2s9visdb kdjLE1IzScGQgJrUiNYMEq1RHJFOw6ipQHRnLTfyF5ANIzkkPSm5eVoYf3TW0P4WJcGm VW1g== MIME-Version: 1.0 X-Received: by 10.202.11.72 with SMTP id 69mr18087666oil.110.1444737189404; Tue, 13 Oct 2015 04:53:09 -0700 (PDT) Received: by 10.202.108.212 with HTTP; Tue, 13 Oct 2015 04:53:09 -0700 (PDT) In-Reply-To: <561CEA6D.6010703@darbyshire-bryant.me.uk> References: <561CDB4E.4000000@darbyshire-bryant.me.uk> <561CEA6D.6010703@darbyshire-bryant.me.uk> Date: Tue, 13 Oct 2015 13:53:09 +0200 Message-ID: From: Dave Taht To: Kevin Darbyshire-Bryant Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Cake parameter anomaly? X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2015 11:53:33 -0000 nuke it then. On Tue, Oct 13, 2015 at 1:26 PM, Kevin Darbyshire-Bryant wrote: > I can't find anything that uses "TCA_CAKE_ACTIVE_FLOWS" in the current > codebase of ether cake or tc-adv, so if we're in the current business of > breaking API/ABI stuff then shouldn't it go? > > The output of 'sparse & bulk' flows is still there in the output stats > shown by tc, so is obviously in use. > > On 13/10/15 11:34, Dave Taht wrote: >> active_flows was a parameter that was in one version or another that >> was exposed to the API. It was very useful and interesting. >> >> On Tue, Oct 13, 2015 at 12:22 PM, Kevin Darbyshire-Bryant >> wrote: >>> Hi List, >>> >>> In pkt_sched.h we see an enumeration for 'TCA_CAKE_ACTIVE_FLOWS': >>> >>> /* CAKE */ >>> enum { >>> TCA_CAKE_UNSPEC, >>> TCA_CAKE_BASE_RATE, >>> TCA_CAKE_DIFFSERV_MODE, >>> TCA_CAKE_ATM, >>> TCA_CAKE_FLOW_MODE, >>> TCA_CAKE_OVERHEAD, >>> TCA_CAKE_ACTIVE_FLOWS, >>> TCA_CAKE_RTT, >>> TCA_CAKE_TARGET, >>> __TCA_CAKE_MAX >>> }; >>> #define TCA_CAKE_MAX (__TCA_CAKE_MAX - 1) >>> >>> These enumerations are normally used for passing options from tc into >>> the cake module, but at the present time, nowhere in either cake or tc >>> can I see use of 'ACTIVE_FLOWS'. It's not read as an input into cake, >>> nor is it sent out of cake back to tc via the nla_policy. >>> >>> Is this a 'typo' from when bulk/sparse flows reporting was put into the >>> stats, or is it some as yet unimplemented feature? >>> >>> I've meant to ask about this before but it sort of got lost. >>> >>> Kevin >>> >>> >>> _______________________________________________ >>> Cake mailing list >>> Cake@lists.bufferbloat.net >>> https://lists.bufferbloat.net/listinfo/cake >>> >> >> > > --=20 Dave T=C3=A4ht Do you want faster, better, wifi? https://www.patreon.com/dtaht