From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5064B3CB35 for ; Thu, 13 Sep 2018 10:13:33 -0400 (EDT) Received: by mail-qk1-x744.google.com with SMTP id g13-v6so3241983qki.9 for ; Thu, 13 Sep 2018 07:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=tt+5DHhoRRkPe/3gGjeocgAevUY75C9t0uTpD6Up5TM=; b=jEO+9XkB/0uKJh69nLiNEVUcoMI1cvCMchUzcgDo1L0G+HEhJsJ2d4IDpKPt8jLqce 3VYc00jqHxNdOSwD1tNgz1SRLFrozTZlPP3ntMBO7KfhrkIuxg3Ao/TtWlQ/PkmHxe3B V/2yxXK1JQXjEYlr5GgVKImEqBqxkMEUXdYK8Y/gfWtVGCWBxM0+Q+bteOrEHdLWRJN+ 4Ni3hkozf8UciQwsvmcEg0xbgfxNeLZf4vl9qby5CyuinfcgHkuVfHKA4nYsyU2U7svv G2pGNQJUxVSzeRF71ak6c88ozuSB5ymrxdpzEVd+5bk0qrqKmX9Powr9cmdVF3wjIEC7 in0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=tt+5DHhoRRkPe/3gGjeocgAevUY75C9t0uTpD6Up5TM=; b=tRUqbx5TZJ6mLrauOgg2oim6A9faGUm6szOj6ikBm+tznrfcCvUEaKIssRHoYs/NWH TkAbPLUhwVYruC/LSC2t0g135BOSWi6nVYQOlhw1AT9rD0Ch6SGEF/tcgpvZ9shrvlxo t4xPVgm/zjhcD+mkP7lKUOTC7t1HUg1pi89e1R6Pazm6dCGZkdcWvl6cqUIQCxMwWdCH DqS1EMScC2I7+5lrxLCNJXFHVauo1gB+0DWhBevNiuNMZaknnaU4arP+DOmgRsZW5K8T GwFPxp1hvPenV24RB87bRABxyep0oLl8dcAHQg7eMT3QB1rQ5Dyo/ikLCXvZ51EWukr5 TSmQ== X-Gm-Message-State: APzg51A+g7YVq6ukdt24BFbErNH6P+od/EsJqWmMDP2oglY9igEI5ekj FifwAJ2ZM9znblEc2GzDleZy1DNcwSSoHxFshHbfVQ== X-Google-Smtp-Source: ANB0VdbMmd7E1chf0WJ3QH4lrJF3dzr3Z0WW2VVinA/2LKV9GpoeY4/kBqmD3xPpEyDtUBJ68LZYnySB59JKuvGqOaI= X-Received: by 2002:a37:6e82:: with SMTP id j124-v6mr5033354qkc.179.1536848012684; Thu, 13 Sep 2018 07:13:32 -0700 (PDT) MIME-Version: 1.0 References: <153670437243.12756.693381878569982309.stgit@alrua-kau> <5dc16f03-7cd2-f797-1bda-592d5f5462b5@gmail.com> In-Reply-To: <5dc16f03-7cd2-f797-1bda-592d5f5462b5@gmail.com> From: Dave Taht Date: Thu, 13 Sep 2018 07:14:30 -0700 Message-ID: To: Eric Dumazet Cc: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Linux Kernel Network Developers , Cake List , Eric Dumazet Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Cake] [PATCH net] gso_segment: Reset skb->mac_len after modifying network header X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 14:13:33 -0000 On Thu, Sep 13, 2018 at 7:11 AM Eric Dumazet wrote= : > > > > On 09/11/2018 03:19 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > When splitting a GSO segment that consists of encapsulated packets, the > > skb->mac_len of the segments can end up being set wrong, causing packet > > drops in particular when using act_mirred and ifb interfaces in > > combination with a qdisc that splits GSO packets. > > > > This happens because at the time skb_segment() is called, network_heade= r > > will point to the inner header, throwing off the calculation in > > skb_reset_mac_len(). The network_header is subsequently adjust by the > > outer IP gso_segment handlers, but they don't set the mac_len. > > > > Fix this by adding skb_reset_mac_len() calls to both the IPv4 and IPv6 > > gso_segment handlers, after they modify the network_header. > > > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > > Looks good but I would have appreciated a thanks or something > after the help I gave on this problem. > > Reviewed-by: Eric Dumazet Thanks, eric! (post-hoc) Acked-by: Dave Taht > _______________________________________________ > Cake mailing list > Cake@lists.bufferbloat.net > https://lists.bufferbloat.net/listinfo/cake --=20 Dave T=C3=A4ht CEO, TekLibre, LLC http://www.teklibre.com Tel: 1-669-226-2619