Re: [Cake] Announce - possible new feature - DSCP cleaning

[Dave Taht <dave.taht@gmail.com>]

switch (q->tin_mode) { case CAKE_MODE_SQUASH: case
CAKE_MODE_BESTEFFORT: default: cake_config_besteffort(sch); break;

?
Dave Täht
Let's go make home routers and wifi faster! With better software!
https://www.gofundme.com/savewifi


On Mon, Nov 16, 2015 at 7:32 PM, Sebastian Moeller <moeller0@gmx.de> wrote:
> Hi Dave,
>
>
> On Nov 16, 2015, at 19:25 , Dave Taht <dave.taht@gmail.com> wrote:
>
>> I grok...
>>
>> short rate_overhead;// kind of stands out. s16 is the equivalent....
>>
>> so the intent here is to have the rate flags get twiddled by userspace
>> to enable squashing
>> separately? one "feature" of squashing the old way was we did not need
>> to allocate more than
>> one tin…
>
>         But you still do not need to squash, I believe defaults to the besteffort 1tin setup, only if the user requests "squash diffserv4" or so she will get what she asked for ;). While I have not tested that, I believe that is how Kevin explained it, and this looks in line with cake’s (extended) rationale of making the defaults sane and efficient (and the crazy possible ;) not sure whether there is consensus yet on this extension…)
>
>
> Best Regards
>         Sebastian
>
>> Dave Täht
>> Let's go make home routers and wifi faster! With better software!
>> https://www.gofundme.com/savewifi
>>
>>
>> On Mon, Nov 16, 2015 at 7:11 PM, Kevin Darbyshire-Bryant
>> <kevin@darbyshire-bryant.me.uk> wrote:
>>> tin_cnt *is* u16, in fact struct cake_sched_data has been restored to
>>> the same state as it was before I introduced 'u8 squash'.
>>>
>>> On 16/11/15 17:59, Dave Taht wrote:
>>>> yes and nooo..... I thought tin_cnt needed to be a 10 bit number at
>>>> least.... (did it become an 8 bitter somewhere?)
>>>>
>>>>
>>>> but I have not looked at the code in quite some time. Tomorrow I hope
>>>> to finally have a fresh head.
>>>>
>>>> Right now I'm merely wrestling with getting a build to complete.
>>>> Dave Täht
>>>> Let's go make home routers and wifi faster! With better software!
>>>> https://www.gofundme.com/savewifi
>>>>
>>>>
>>>> On Mon, Nov 16, 2015 at 6:47 PM, Kevin Darbyshire-Bryant
>>>> <kevin@darbyshire-bryant.me.uk> wrote:
>>>>> Does this
>>>>> https://github.com/dtaht/sch_cake/commit/d05cf7e003d9c13d8382c881655807bda7ab3616
>>>>> improve your happiness factor?
>>>>>
>>>>> Kevin
>>>>>
>>>>> On 16/11/15 15:57, Dave Taht wrote:
>>>>>> isn't there some other boolean variable somewhere ?
>>>>>>
>>>>>> Dave Täht
>>>>>> Let's go make home routers and wifi faster! With better software!
>>>>>> https://www.gofundme.com/savewifi
>>>>>>
>>>>>>
>>>>>> On Mon, Nov 16, 2015 at 4:20 PM, Kevin Darbyshire-Bryant
>>>>>> <kevin@darbyshire-bryant.me.uk> wrote:
>>>>>>> On 16/11/15 15:03, Dave Taht wrote:
>>>>>>>> I have not been doing any active development until... tomorrow.
>>>>>>>>
>>>>>>>> A goal I have for today is to actually build a version of openwrt +
>>>>>>>> all this stuff for the linksys ac1200.
>>>>>>>>
>>>>>>>> I was not particularly huge on using another field (q->squash) to
>>>>>>>> trigger squashing, and I cannot come up with a use case that makes
>>>>>>>> sense to me.
>>>>>>>>
>>>>>>>> Under what circumstances do you think separating these two functions
>>>>>>>> to be useful?
>>>>>>> I wanted to be able to use diffserv marking for internal bandwidth
>>>>>>> policing purposes whilst clearing those bits by the time they hit the
>>>>>>> ISP.  On ingress it makes no sense, on egress I can see a use.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>
>>>
>>>
>> _______________________________________________
>> Cake mailing list
>> Cake@lists.bufferbloat.net
>> https://lists.bufferbloat.net/listinfo/cake
>