From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by huchra.bufferbloat.net (Postfix) with ESMTPS id 8E8D621F405 for ; Mon, 16 Nov 2015 10:35:09 -0800 (PST) Received: by wmvv187 with SMTP id v187so191288448wmv.1 for ; Mon, 16 Nov 2015 10:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=nKfINE3wCnhbsUdsJCFOQZ3OPdHMR1ZUeZoDCmg6BDo=; b=ypqWsvzXWWtV9RjEEzul7laDcw0iRj65lk5GWwm4tAJlL7qSat2WzJgW6+ZyYX4BYS cBOZR7kt7Cd8EyTWzE5CZEKDvIyW89DranzLJwJdQbKAGWo+9O0pff307xxH/pH9b0K8 RdW8TyfBcugy7gamWN2eSLFtd5NccAQKINpzY+2H9KQTF2Lyr0mzddLlgl6M4GPXp8xY oVnT58xPzpFhQV3Uo4In8LjgpgAMLqGw55rY5DQmyFzWVh/AfhQA9AuGFBDQJKXdFlYb xKV7GVjyZ6t3v9gxOcJmBEJUeprZVRpqQhM6CmQCE7gjX0bJ8LhFMnls362bC2fDGxa6 syuA== MIME-Version: 1.0 X-Received: by 10.194.115.129 with SMTP id jo1mr38864675wjb.28.1447698907363; Mon, 16 Nov 2015 10:35:07 -0800 (PST) Received: by 10.194.42.168 with HTTP; Mon, 16 Nov 2015 10:35:07 -0800 (PST) In-Reply-To: <1265B943-4AB3-4AF4-9389-71CA46801A69@gmx.de> References: <56420697.9080606@darbyshire-bryant.me.uk> <5649EF39.3060300@darbyshire-bryant.me.uk> <5649F423.40000@darbyshire-bryant.me.uk> <564A169D.1060307@darbyshire-bryant.me.uk> <564A1C6D.3050303@darbyshire-bryant.me.uk> <1265B943-4AB3-4AF4-9389-71CA46801A69@gmx.de> Date: Mon, 16 Nov 2015 19:35:07 +0100 Message-ID: From: Dave Taht To: Sebastian Moeller Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: cake@lists.bufferbloat.net Subject: Re: [Cake] Announce - possible new feature - DSCP cleaning X-BeenThere: cake@lists.bufferbloat.net X-Mailman-Version: 2.1.13 Precedence: list List-Id: Cake - FQ_codel the next generation List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2015 18:35:32 -0000 switch (q->tin_mode) { case CAKE_MODE_SQUASH: case CAKE_MODE_BESTEFFORT: default: cake_config_besteffort(sch); break; ? Dave T=C3=A4ht Let's go make home routers and wifi faster! With better software! https://www.gofundme.com/savewifi On Mon, Nov 16, 2015 at 7:32 PM, Sebastian Moeller wrote: > Hi Dave, > > > On Nov 16, 2015, at 19:25 , Dave Taht wrote: > >> I grok... >> >> short rate_overhead;// kind of stands out. s16 is the equivalent.... >> >> so the intent here is to have the rate flags get twiddled by userspace >> to enable squashing >> separately? one "feature" of squashing the old way was we did not need >> to allocate more than >> one tin=E2=80=A6 > > But you still do not need to squash, I believe defaults to the be= steffort 1tin setup, only if the user requests "squash diffserv4" or so she= will get what she asked for ;). While I have not tested that, I believe th= at is how Kevin explained it, and this looks in line with cake=E2=80=99s (e= xtended) rationale of making the defaults sane and efficient (and the crazy= possible ;) not sure whether there is consensus yet on this extension=E2= =80=A6) > > > Best Regards > Sebastian > >> Dave T=C3=A4ht >> Let's go make home routers and wifi faster! With better software! >> https://www.gofundme.com/savewifi >> >> >> On Mon, Nov 16, 2015 at 7:11 PM, Kevin Darbyshire-Bryant >> wrote: >>> tin_cnt *is* u16, in fact struct cake_sched_data has been restored to >>> the same state as it was before I introduced 'u8 squash'. >>> >>> On 16/11/15 17:59, Dave Taht wrote: >>>> yes and nooo..... I thought tin_cnt needed to be a 10 bit number at >>>> least.... (did it become an 8 bitter somewhere?) >>>> >>>> >>>> but I have not looked at the code in quite some time. Tomorrow I hope >>>> to finally have a fresh head. >>>> >>>> Right now I'm merely wrestling with getting a build to complete. >>>> Dave T=C3=A4ht >>>> Let's go make home routers and wifi faster! With better software! >>>> https://www.gofundme.com/savewifi >>>> >>>> >>>> On Mon, Nov 16, 2015 at 6:47 PM, Kevin Darbyshire-Bryant >>>> wrote: >>>>> Does this >>>>> https://github.com/dtaht/sch_cake/commit/d05cf7e003d9c13d8382c8816558= 07bda7ab3616 >>>>> improve your happiness factor? >>>>> >>>>> Kevin >>>>> >>>>> On 16/11/15 15:57, Dave Taht wrote: >>>>>> isn't there some other boolean variable somewhere ? >>>>>> >>>>>> Dave T=C3=A4ht >>>>>> Let's go make home routers and wifi faster! With better software! >>>>>> https://www.gofundme.com/savewifi >>>>>> >>>>>> >>>>>> On Mon, Nov 16, 2015 at 4:20 PM, Kevin Darbyshire-Bryant >>>>>> wrote: >>>>>>> On 16/11/15 15:03, Dave Taht wrote: >>>>>>>> I have not been doing any active development until... tomorrow. >>>>>>>> >>>>>>>> A goal I have for today is to actually build a version of openwrt = + >>>>>>>> all this stuff for the linksys ac1200. >>>>>>>> >>>>>>>> I was not particularly huge on using another field (q->squash) to >>>>>>>> trigger squashing, and I cannot come up with a use case that makes >>>>>>>> sense to me. >>>>>>>> >>>>>>>> Under what circumstances do you think separating these two functio= ns >>>>>>>> to be useful? >>>>>>> I wanted to be able to use diffserv marking for internal bandwidth >>>>>>> policing purposes whilst clearing those bits by the time they hit t= he >>>>>>> ISP. On ingress it makes no sense, on egress I can see a use. >>>>>>> >>>>>>> >>>>>>> >>>>> >>> >>> >> _______________________________________________ >> Cake mailing list >> Cake@lists.bufferbloat.net >> https://lists.bufferbloat.net/listinfo/cake >