From: Dave Taht <dave.taht@gmail.com>
To: Pete Heist <pete@heistp.net>
Cc: Cake List <cake@lists.bufferbloat.net>
Subject: Re: [Cake] cake infinite loop(?) with hfsc on one-armed router
Date: Tue, 8 Jan 2019 14:33:16 -0800 [thread overview]
Message-ID: <CAA93jw6i70AeB+SDRpyr3sbsoqwDJOoPAFXMhcHknTNjCeHyug@mail.gmail.com> (raw)
In-Reply-To: <749130B2-8A84-4F88-AF23-385B438C04DA@heistp.net>
On Tue, Jan 8, 2019 at 2:01 PM Pete Heist <pete@heistp.net> wrote:
>
> I should have done that: https://www.heistp.net/downloads/htb_split_gso_patched/
>
> Note that I changed the names in the plots to match the convention of my first email, but it should be clear which is which and I left all plots in. The text output is there too as I sometimes like to open several up in different browser tabs and switch between tabs to compare values.
>
> It looks like about 100 usec to me. Throughput also looks consistently about 0.3 Mbit higher (~1.3%) in the split results.
My guess is with ecn on would have the highest latency and the same
throughput. ?
Since we started this effort in an era when seconds of added latency
was common, a mere 100us improvement seems insignificant, except that
that's a 10% improvement over the present-day baseline, and *that's
worth it*. ;) This is also a function of the number of flows, kernel
scheduling time, etc, etc. Theoretically,
were there no other delays in the system, we seem to actually be at
the minimal RTT achievable (4*130ms in each direction for the fat
flows = 1040us) but given the fast/slow queue abstraction the best
possible result would be 10s of us for the measurement flows.
I have noticed that BQL's values can get quite large with cake doing
the shaping, btw, much larger than they do with htb.
> > On Jan 8, 2019, at 9:44 PM, Dave Taht <dave.taht@gmail.com> wrote:
> >
> > On Tue, Jan 8, 2019 at 12:03 PM Pete Heist <pete@heistp.net> wrote:
> >>
> >> Here’s the re-test with the patched version and HTB. Looks like success, nice work!
> >
> > I note that I'm big on having the flent.gz files around also. In this
> > case, by eyeball, split-gso appears to have about 130us less latency,
> > but a cdf comparison of split vs no-split woud show that more easily.
> >
> >> Split GSO on:
> >>
> >> https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_split1.svg
> >> https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_split2.svg
> >> https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_split3.svg
> >>
> >> Split GSO off:
> >>
> >> https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_no_split1.svg
> >> https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_no_split2.svg
> >> https://www.heistp.net/downloads/htb_split_gso_patched/htb_cakep_no_split3.svg
> >>
> >> Your patch in the latest kernels looks simpler. Bringing the patch back to prior kernel versions would be appreciated, but I can understand how 3.16 becomes less and less relevant as time goes on, although, it’s not at end of life yet. :)
> >>
> >> Interesting how download rate control in each of the graphs with GSO splitting on looks accurate to the point where flent’s throughput graph scale is at 0.02 Mbit per step, and one can see that values coming back from netperf are probably quantized to 0.01 Mbit...
> >>
> >>> On Jan 7, 2019, at 4:07 PM, Pete Heist <pete@heistp.net> wrote:
> >>>
> >>> Sorry, that’s without the patch, will give that a try when I have a chance and post the results, probably tomorrow...
> >>>
> >>>> On Jan 7, 2019, at 12:30 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> >>>>
> >>>> Pete Heist <pete@heistp.net> writes:
> >>>>
> >>>>>> On Jan 6, 2019, at 9:56 PM, Toke Høiland-Jørgensen <toke@toke.dk> wrote:
> >>>>>>
> >>>>>> Pete Heist <pete@heistp.net> writes:
> >>>>>>
> >>>>>>> Lastly, is using cake as a leaf to htb risky until a fix is made? I’ve
> >>>>>>> been doing that for a while without any apparent issues, though I’m
> >>>>>>> hesitating now to try that in a production environment.
> >>>>>>
> >>>>>> Hmm, that's a good question. I would expect so; but I would also expect
> >>>>>> the issue to show up pretty much straight away, so if you haven't hit it
> >>>>>> yet, I may be wrong. I'll do some more digging... Should probably also
> >>>>>> try to replicate all this stuff on my own machine :)
> >>>>>
> >>>>>
> >>>>> Ok, after what I’m seeing on my APU1 tests on 3.16.7, I’m definitely
> >>>>> not putting split GSO into production. I just turned it on and off
> >>>>> three times and here’s what I got:
> >>>>>
> >>>>> Split GSO on:
> >>>>>
> >>>>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_split_gso.svg
> >>>>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_split_gso2.svg
> >>>>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_split_gso3.svg
> >>>>>
> >>>>> Split GSO off:
> >>>>>
> >>>>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_no_split_gso.svg
> >>>>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_no_split_gso2.svg
> >>>>> https://www.heistp.net/downloads/htb_split_gso/htb_cake_no_split_gso3.svg
> >>>>>
> >>>>> I’ve seen these square waves before with htb and wondered where they
> >>>>> came from, and I think we may finally have an answer! What manner of
> >>>>> thing causes this I don’t know, but there’s a chance you may end up
> >>>>> finding out… :)
> >>>>
> >>>> Is this without the patch to CAKE that adjusts the qlen? And have you
> >>>> tried running with that patch (with HTB)?
> >>>>
> >>>> -Toke
> >>>
> >>
> >> _______________________________________________
> >> Cake mailing list
> >> Cake@lists.bufferbloat.net
> >> https://lists.bufferbloat.net/listinfo/cake
> >
> >
> >
> > --
> >
> > Dave Täht
> > CTO, TekLibre, LLC
> > http://www.teklibre.com
> > Tel: 1-831-205-9740
>
--
Dave Täht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-205-9740
next prev parent reply other threads:[~2019-01-08 22:33 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-27 23:30 Pete Heist
2018-12-28 12:58 ` Pete Heist
2018-12-28 21:22 ` Pete Heist
2018-12-28 22:07 ` Jonathan Morton
2018-12-28 22:42 ` Pete Heist
2019-01-04 21:34 ` Toke Høiland-Jørgensen
2019-01-04 22:10 ` Pete Heist
2019-01-04 22:12 ` Pete Heist
2019-01-04 22:34 ` Toke Høiland-Jørgensen
2019-01-05 5:58 ` Pete Heist
2019-01-05 10:06 ` Toke Høiland-Jørgensen
2019-01-05 10:59 ` Pete Heist
2019-01-05 11:06 ` Pete Heist
2019-01-05 11:18 ` Toke Høiland-Jørgensen
2019-01-05 11:26 ` Pete Heist
2019-01-05 11:35 ` Pete Heist
2019-01-05 12:38 ` Toke Høiland-Jørgensen
2019-01-05 12:51 ` Pete Heist
2019-01-05 13:10 ` Toke Høiland-Jørgensen
2019-01-05 13:20 ` Pete Heist
2019-01-05 13:35 ` Toke Høiland-Jørgensen
2019-01-05 15:34 ` Pete Heist
2019-01-05 15:52 ` Jonathan Morton
2019-01-05 16:32 ` Toke Høiland-Jørgensen
2019-01-05 19:27 ` Sebastian Moeller
2019-01-05 20:01 ` Pete Heist
2019-01-05 20:10 ` Toke Høiland-Jørgensen
2019-01-05 20:31 ` Pete Heist
2019-01-05 22:27 ` Toke Høiland-Jørgensen
2019-01-05 22:41 ` Pete Heist
2019-01-06 9:37 ` Pete Heist
2019-01-06 20:56 ` Toke Høiland-Jørgensen
2019-01-07 0:30 ` Pete Heist
2019-01-07 2:11 ` Dave Taht
2019-01-07 11:30 ` Toke Høiland-Jørgensen
2019-01-07 15:07 ` Pete Heist
2019-01-08 20:03 ` Pete Heist
2019-01-08 20:44 ` Dave Taht
2019-01-08 22:01 ` Pete Heist
2019-01-08 22:33 ` Dave Taht [this message]
2019-01-09 6:13 ` Pete Heist
2019-01-08 22:27 ` Toke Høiland-Jørgensen
2019-01-09 5:29 ` Pete Heist
2019-01-09 8:36 ` Toke Høiland-Jørgensen
2019-01-06 20:55 ` Toke Høiland-Jørgensen
2019-01-05 10:44 ` Jonathan Morton
2019-01-05 11:17 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA93jw6i70AeB+SDRpyr3sbsoqwDJOoPAFXMhcHknTNjCeHyug@mail.gmail.com \
--to=dave.taht@gmail.com \
--cc=cake@lists.bufferbloat.net \
--cc=pete@heistp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox