Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: Sebastian Moeller <moeller0@gmx.de>
Cc: Jonathan Morton <chromatix99@gmail.com>, cake@lists.bufferbloat.net
Subject: Re: [Cake] upstreaming cake in 2017?
Date: Fri, 23 Dec 2016 09:01:36 -0800	[thread overview]
Message-ID: <CAA93jw7+0pXvMRPHiJqLv_1_yWgPPwzQH2Qs-d+BhooAObJ0Bw@mail.gmail.com> (raw)
In-Reply-To: <BB1B837A-88ED-4EAB-AF64-821BCEF66F60@gmx.de>

I have largely been focused on make-wifi-fast until the last week,
only doing a code review on cake over the last few days and submitting
a few patches thus far.

I have sometimes been frustrated enough on the squash/wash issue to
want to fork cake to "just do it", because RFC compliance actually
mandates that the traffic be re-marked appropriately upon transiting a
domain, and seeing CS1 enter my network from comcast really messes up
if it is passed directly through to wifi. It is far, far better to
squash on ingress, and to do it without a tc filter.

In other patches:

https://github.com/dtaht/sch_cake/pull/42 constifies things. (compile
tested only, btw)

And:

I was not aware of this "feature": https://github.com/dtaht/sch_cake/issues/41
until yesterday and it needs testing against real traffic, on real
RTTs. I think a lot of latency sensitive (and marked thus) traffic is
now pretty bursty (videoconferencing in particular, as well as
anything transiting a wifi hop beforehand) and (IMHO) the literature
on short queues is now invalid and out of date for all but voice
traffic. (that said, I'm willing to test first)

...

stats keeping seems broken: https://github.com/dtaht/sch_cake/issues/43

I have always been allergic to all the stats in the first place.
Keeping inaccurate stats is worse than no stats at all.

...

I will gladly re-roll a patch for squashing.

...

I would really like cake reviewed for suitability for mainlining
before it becomes part of lede's next release. In particular the
cobalt.*c* include has gotta go.

...

I've done a bit of profiling on it, basically cpu-wise it eats about
the same as htb+fq-codel does.

  reply	other threads:[~2016-12-23 17:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-22 19:43 Dave Taht
2016-12-22 20:02 ` Sebastian Moeller
2016-12-23  1:43   ` Stephen Hemminger
2016-12-23  3:44     ` Jonathan Morton
2016-12-23  8:42       ` Sebastian Moeller
2016-12-23  9:53         ` Jonathan Morton
2016-12-23 12:40           ` Sebastian Moeller
2016-12-23 14:06             ` Jonathan Morton
2016-12-23 16:24               ` Sebastian Moeller
2016-12-23 17:01                 ` Dave Taht [this message]
2016-12-24 15:55           ` Benjamin Cronce
2016-12-24 17:22             ` Jonathan Morton
2016-12-24 21:15               ` Benjamin Cronce
2016-12-30  7:42 ` Y

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw7+0pXvMRPHiJqLv_1_yWgPPwzQH2Qs-d+BhooAObJ0Bw@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=chromatix99@gmail.com \
    --cc=moeller0@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox